From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Pavel Machek <pavel@denx.de>
Cc: stable@kernel.org, kernel list <linux-kernel@vger.kernel.org>,
davem@davemloft.net, gregkh@linuxfoundation.org
Subject: Re: net: atm: Spectre v1 fix introduced bug in bcb964012d1b in -stable
Date: Mon, 20 May 2019 11:54:59 -0500 [thread overview]
Message-ID: <2afe2a95-6297-4448-3942-9ba10e306e96@embeddedor.com> (raw)
In-Reply-To: <20190520161549.GB25789@amd>
On 5/20/19 11:15 AM, Pavel Machek wrote:
> On Mon 2019-05-20 09:15:50, Gustavo A. R. Silva wrote:
>>
>>
>> On 5/20/19 7:40 AM, Pavel Machek wrote:
>>>
>>> In lecd_attach, if arg is < 0, it was treated as 0. Spectre v1 fix
>>> changed that. Bug does not exist in mainline AFAICT.
>>>
>>
>> NACK
>>
>> array_index_nospec() macro returns zero if *arg* is out of bounds.
>
> No, it does not. Take a look:
>
> #define array_index_nospec(index, size)
> ...
> (typeof(_i)) (_i & _mask);
> })
>
Tell me more about that _mask.
Also, don't ignore the backward compatibility; otherwise you
would be forking your own kernel.
--
Gustavo
prev parent reply other threads:[~2019-05-20 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 12:40 net: atm: Spectre v1 fix introduced bug in bcb964012d1b in -stable Pavel Machek
2019-05-20 14:00 ` Greg KH
2019-05-20 14:26 ` Gustavo A. R. Silva
2019-05-20 21:00 ` Pavel Machek
2019-05-20 16:15 ` Pavel Machek
2019-05-20 14:15 ` Gustavo A. R. Silva
2019-05-20 16:15 ` Pavel Machek
2019-05-20 16:54 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2afe2a95-6297-4448-3942-9ba10e306e96@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@denx.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).