* [PATCH] ARM: dts: berlin: switch to earlycon
@ 2018-05-29 15:41 Thomas Hebb
2018-07-04 9:14 ` Jisheng Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Hebb @ 2018-05-29 15:41 UTC (permalink / raw)
To: linux-kernel
Cc: Thomas Hebb, Jisheng Zhang, Sebastian Hesselbarth, Rob Herring,
Mark Rutland, moderated list:ARM/Synaptics Berlin SoC support,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
The Synopsys DesignWare 8250 UART in Berlin SoCs is now supported by
8250_early, so we can use earlycon for early console output instead
of earlyprintk, which requires an SoC-specific kernel.
Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
---
arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts | 2 +-
arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 2 +-
arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts b/arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts
index 1c475796d17f..f98798bb684f 100644
--- a/arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts
+++ b/arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts
@@ -45,7 +45,7 @@
compatible = "sony,nsz-gs7", "marvell,berlin2", "marvell,berlin";
chosen {
- bootargs = "earlyprintk";
+ bootargs = "earlycon";
stdout-path = "serial0:115200n8";
};
diff --git a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
index ca24def0ce13..20f31cdeaf38 100644
--- a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
+++ b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
@@ -46,7 +46,7 @@
compatible = "google,chromecast", "marvell,berlin2cd", "marvell,berlin";
chosen {
- bootargs = "earlyprintk";
+ bootargs = "earlycon";
stdout-path = "serial0:115200n8";
};
diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
index 57aa5f8a7c77..9834e84a0797 100644
--- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
+++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
@@ -49,7 +49,7 @@
};
chosen {
- bootargs = "earlyprintk";
+ bootargs = "earlycon";
stdout-path = "serial0:115200n8";
};
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: berlin: switch to earlycon
2018-05-29 15:41 [PATCH] ARM: dts: berlin: switch to earlycon Thomas Hebb
@ 2018-07-04 9:14 ` Jisheng Zhang
2018-07-04 21:14 ` Tom Hebb
0 siblings, 1 reply; 3+ messages in thread
From: Jisheng Zhang @ 2018-07-04 9:14 UTC (permalink / raw)
To: Thomas Hebb
Cc: linux-kernel, Sebastian Hesselbarth, Rob Herring, Mark Rutland,
moderated list:ARM/Synaptics Berlin SoC support,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hi Thomas,
On Tue, 29 May 2018 11:41:42 -0400 Thomas Hebb wrote:
> The Synopsys DesignWare 8250 UART in Berlin SoCs is now supported by
> 8250_early, so we can use earlycon for early console output instead
> of earlyprintk, which requires an SoC-specific kernel.
IIRC, earlyprintk still works during the decompress progress while the
earlycon doesn't.
>
> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> ---
> arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts | 2 +-
> arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 2 +-
> arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts b/arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts
> index 1c475796d17f..f98798bb684f 100644
> --- a/arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts
> +++ b/arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts
> @@ -45,7 +45,7 @@
> compatible = "sony,nsz-gs7", "marvell,berlin2", "marvell,berlin";
>
> chosen {
> - bootargs = "earlyprintk";
> + bootargs = "earlycon";
Is there something missing here? example, uart8250,mmio,<addr>?
> stdout-path = "serial0:115200n8";
> };
>
> diff --git a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
> index ca24def0ce13..20f31cdeaf38 100644
> --- a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
> +++ b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
> @@ -46,7 +46,7 @@
> compatible = "google,chromecast", "marvell,berlin2cd", "marvell,berlin";
>
> chosen {
> - bootargs = "earlyprintk";
> + bootargs = "earlycon";
> stdout-path = "serial0:115200n8";
> };
>
> diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> index 57aa5f8a7c77..9834e84a0797 100644
> --- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> +++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> @@ -49,7 +49,7 @@
> };
>
> chosen {
> - bootargs = "earlyprintk";
> + bootargs = "earlycon";
> stdout-path = "serial0:115200n8";
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: berlin: switch to earlycon
2018-07-04 9:14 ` Jisheng Zhang
@ 2018-07-04 21:14 ` Tom Hebb
0 siblings, 0 replies; 3+ messages in thread
From: Tom Hebb @ 2018-07-04 21:14 UTC (permalink / raw)
To: Jisheng Zhang
Cc: linux-kernel, Sebastian Hesselbarth, Rob Herring, Mark Rutland,
moderated list:ARM/Synaptics Berlin SoC support,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hi Jisheng,
On 07/04/2018 05:14 AM, Jisheng Zhang wrote:
> Hi Thomas,
>
> On Tue, 29 May 2018 11:41:42 -0400 Thomas Hebb wrote:
>
>> The Synopsys DesignWare 8250 UART in Berlin SoCs is now supported by
>> 8250_early, so we can use earlycon for early console output instead
>> of earlyprintk, which requires an SoC-specific kernel.
>
> IIRC, earlyprintk still works during the decompress progress while the
> earlycon doesn't.
Yes, I believe that's correct. My original rationale for this patch was
that earlycon is generally preferred over earlyprintk since it doesn't
require SoC-specific kernels, but now I'm not convinced that either of
the two parameters belongs in the dts file. As you point out,
earlyprintk can do things that earlycon cannot, and in the common case,
neither are needed.
Perhaps removing the bootargs property altogether is more correct. I'm
happy to send another patch to do that if you concur.
>>
>> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
>> ---
>> arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts | 2 +-
>> arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 2 +-
>> arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts b/arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts
>> index 1c475796d17f..f98798bb684f 100644
>> --- a/arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts
>> +++ b/arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts
>> @@ -45,7 +45,7 @@
>> compatible = "sony,nsz-gs7", "marvell,berlin2", "marvell,berlin";
>>
>> chosen {
>> - bootargs = "earlyprintk";
>> + bootargs = "earlycon";
>
> Is there something missing here? example, uart8250,mmio,<addr>?
No explicit MMIO info is needed for earlycon on DT systems where an
stdout-path property is present. I've tested the patch as-is and the
early output works fine.
>> stdout-path = "serial0:115200n8";
>> };
>>
>> diff --git a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
>> index ca24def0ce13..20f31cdeaf38 100644
>> --- a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
>> +++ b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
>> @@ -46,7 +46,7 @@
>> compatible = "google,chromecast", "marvell,berlin2cd", "marvell,berlin";
>>
>> chosen {
>> - bootargs = "earlyprintk";
>> + bootargs = "earlycon";
>> stdout-path = "serial0:115200n8";
>> };
>>
>> diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
>> index 57aa5f8a7c77..9834e84a0797 100644
>> --- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
>> +++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
>> @@ -49,7 +49,7 @@
>> };
>>
>> chosen {
>> - bootargs = "earlyprintk";
>> + bootargs = "earlycon";
>> stdout-path = "serial0:115200n8";
>> };
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-04 21:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-29 15:41 [PATCH] ARM: dts: berlin: switch to earlycon Thomas Hebb
2018-07-04 9:14 ` Jisheng Zhang
2018-07-04 21:14 ` Tom Hebb
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).