* [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board
@ 2016-07-28 21:01 Sheng-Hui J. Chu
2016-07-28 21:09 ` Greg KH
2016-08-08 10:28 ` Johan Hovold
0 siblings, 2 replies; 4+ messages in thread
From: Sheng-Hui J. Chu @ 2016-07-28 21:01 UTC (permalink / raw)
To: linux-usb, johan, linux-kernel, gregkh
BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO IC.
To support BCM920706V2_EVAL dev board for WICED development on Linux. Add the VID(0a5c) and
PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board.
Signed-off-by: Sheng-Hui J. Chu <s.jeffrey.chu@gmail.com>
---
drivers/usb/serial/ftdi_sio.c | 1 +
drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++++
2 files changed, 7 insertions(+)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 0082080..ef19af4 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -1008,6 +1008,7 @@ static const struct usb_device_id id_table_combined[] = {
{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7560U_PID) },
{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7561U_PID) },
{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7563U_PID) },
+ { USB_DEVICE(WICED_USB_VID, WICED_USB20706V2_PID) },
{ } /* Terminating entry */
};
diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
index c5d6c1e..b29f280 100644
--- a/drivers/usb/serial/ftdi_sio_ids.h
+++ b/drivers/usb/serial/ftdi_sio_ids.h
@@ -1485,3 +1485,11 @@
#define CHETCO_SEASMART_DISPLAY_PID 0xA5AD /* SeaSmart NMEA2000 Display */
#define CHETCO_SEASMART_LITE_PID 0xA5AE /* SeaSmart Lite USB Adapter */
#define CHETCO_SEASMART_ANALOG_PID 0xA5AF /* SeaSmart Analog Adapter */
+
+/*
+ * WICED USB UART
+ */
+#define WICED_USB_VID 0x0A5C
+#define WICED_USB20706V2_PID 0x6422
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board
2016-07-28 21:01 [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board Sheng-Hui J. Chu
@ 2016-07-28 21:09 ` Greg KH
2016-07-28 21:22 ` Sheng-Hui J. Chu
2016-08-08 10:28 ` Johan Hovold
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2016-07-28 21:09 UTC (permalink / raw)
To: Sheng-Hui J. Chu; +Cc: linux-usb, johan, linux-kernel
On Thu, Jul 28, 2016 at 05:01:45PM -0400, Sheng-Hui J. Chu wrote:
> BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO IC.
>
> To support BCM920706V2_EVAL dev board for WICED development on Linux. Add the VID(0a5c) and
> PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board.
>
> Signed-off-by: Sheng-Hui J. Chu <s.jeffrey.chu@gmail.com>
> ---
> drivers/usb/serial/ftdi_sio.c | 1 +
> drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 0082080..ef19af4 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1008,6 +1008,7 @@ static const struct usb_device_id id_table_combined[] = {
> { USB_DEVICE(ICPDAS_VID, ICPDAS_I7560U_PID) },
> { USB_DEVICE(ICPDAS_VID, ICPDAS_I7561U_PID) },
> { USB_DEVICE(ICPDAS_VID, ICPDAS_I7563U_PID) },
> + { USB_DEVICE(WICED_USB_VID, WICED_USB20706V2_PID) },
> { } /* Terminating entry */
> };
>
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> index c5d6c1e..b29f280 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -1485,3 +1485,11 @@
> #define CHETCO_SEASMART_DISPLAY_PID 0xA5AD /* SeaSmart NMEA2000 Display */
> #define CHETCO_SEASMART_LITE_PID 0xA5AE /* SeaSmart Lite USB Adapter */
> #define CHETCO_SEASMART_ANALOG_PID 0xA5AF /* SeaSmart Analog Adapter */
> +
> +/*
> + * WICED USB UART
> + */
> +#define WICED_USB_VID 0x0A5C
> +#define WICED_USB20706V2_PID 0x6422
> --
> 2.1.4
Yeah!!!
I'll let Johan queue this up, and forward it on to my trees in a few
days. Thanks so much for sticking with this.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board
2016-07-28 21:09 ` Greg KH
@ 2016-07-28 21:22 ` Sheng-Hui J. Chu
0 siblings, 0 replies; 4+ messages in thread
From: Sheng-Hui J. Chu @ 2016-07-28 21:22 UTC (permalink / raw)
To: 'Greg KH'; +Cc: linux-usb, johan, linux-kernel
From: Greg KH [mailto:gregkh@linuxfoundation.org]
Sent: Thursday, July 28, 2016 5:09 PM
To: Sheng-Hui J. Chu <s.jeffrey.chu@gmail.com>
Cc: linux-usb@vger.kernel.org; johan@kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board
On Thu, Jul 28, 2016 at 05:01:45PM -0400, Sheng-Hui J. Chu wrote:
> BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO IC.
>
> To support BCM920706V2_EVAL dev board for WICED development on Linux. Add the VID(0a5c) and
> PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board.
>
> Signed-off-by: Sheng-Hui J. Chu <s.jeffrey.chu@gmail.com>
> ---
> drivers/usb/serial/ftdi_sio.c | 1 +
> drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 0082080..ef19af4 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1008,6 +1008,7 @@ static const struct usb_device_id id_table_combined[] = {
> { USB_DEVICE(ICPDAS_VID, ICPDAS_I7560U_PID) },
> { USB_DEVICE(ICPDAS_VID, ICPDAS_I7561U_PID) },
> { USB_DEVICE(ICPDAS_VID, ICPDAS_I7563U_PID) },
> + { USB_DEVICE(WICED_USB_VID, WICED_USB20706V2_PID) },
> { } /* Terminating entry */
> };
>
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> index c5d6c1e..b29f280 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -1485,3 +1485,11 @@
> #define CHETCO_SEASMART_DISPLAY_PID 0xA5AD /* SeaSmart NMEA2000 Display */
> #define CHETCO_SEASMART_LITE_PID 0xA5AE /* SeaSmart Lite USB Adapter */
> #define CHETCO_SEASMART_ANALOG_PID 0xA5AF /* SeaSmart Analog Adapter */
> +
> +/*
> + * WICED USB UART
> + */
> +#define WICED_USB_VID 0x0A5C
> +#define WICED_USB20706V2_PID 0x6422
> --
> 2.1.4
Yeah!!!
I'll let Johan queue this up, and forward it on to my trees in a few
days. Thanks so much for sticking with this.
greg k-h
Thank you very much for your patience and guidance.
-Jeffrey
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board
2016-07-28 21:01 [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board Sheng-Hui J. Chu
2016-07-28 21:09 ` Greg KH
@ 2016-08-08 10:28 ` Johan Hovold
1 sibling, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2016-08-08 10:28 UTC (permalink / raw)
To: Sheng-Hui J. Chu; +Cc: linux-usb, johan, linux-kernel, gregkh
On Thu, Jul 28, 2016 at 05:01:45PM -0400, Sheng-Hui J. Chu wrote:
> BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO IC.
>
> To support BCM920706V2_EVAL dev board for WICED development on Linux. Add the VID(0a5c) and
> PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board.
>
> Signed-off-by: Sheng-Hui J. Chu <s.jeffrey.chu@gmail.com>
> ---
> drivers/usb/serial/ftdi_sio.c | 1 +
> drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 0082080..ef19af4 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1008,6 +1008,7 @@ static const struct usb_device_id id_table_combined[] = {
> { USB_DEVICE(ICPDAS_VID, ICPDAS_I7560U_PID) },
> { USB_DEVICE(ICPDAS_VID, ICPDAS_I7561U_PID) },
> { USB_DEVICE(ICPDAS_VID, ICPDAS_I7563U_PID) },
> + { USB_DEVICE(WICED_USB_VID, WICED_USB20706V2_PID) },
> { } /* Terminating entry */
> };
>
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> index c5d6c1e..b29f280 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -1485,3 +1485,11 @@
> #define CHETCO_SEASMART_DISPLAY_PID 0xA5AD /* SeaSmart NMEA2000 Display */
> #define CHETCO_SEASMART_LITE_PID 0xA5AE /* SeaSmart Lite USB Adapter */
> #define CHETCO_SEASMART_ANALOG_PID 0xA5AF /* SeaSmart Analog Adapter */
> +
> +/*
> + * WICED USB UART
> + */
> +#define WICED_USB_VID 0x0A5C
> +#define WICED_USB20706V2_PID 0x6422
This patch still failed to apply:
Applying: usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board
fatal: corrupt patch at line 11
Patch failed at 0001 usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board
and checkpatch also complained about possible line wrapping.
I fixed it up here before applying, but next time please try sending the
patch to yourself and make sure it still applies before posting to the
list.
Thanks,
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-08 10:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-28 21:01 [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board Sheng-Hui J. Chu
2016-07-28 21:09 ` Greg KH
2016-07-28 21:22 ` Sheng-Hui J. Chu
2016-08-08 10:28 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).