From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: "ludovic.desroches@microchip.com"
<ludovic.desroches@microchip.com>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
"ak@it-klinger.de" <ak@it-klinger.de>,
"jic23@kernel.org" <jic23@kernel.org>,
"eugen.hristev@microchip.com" <eugen.hristev@microchip.com>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v2 0/8] iio: core: wrap IIO device into an iio_dev_opaque object
Date: Fri, 22 May 2020 06:58:13 +0000 [thread overview]
Message-ID: <036bd63f14707d9c99273e334ac21eb68b29ea4c.camel@analog.com> (raw)
In-Reply-To: <20200514131710.84201-1-alexandru.ardelean@analog.com>
On Thu, 2020-05-14 at 16:17 +0300, Alexandru Ardelean wrote:
> This change starts to hide some internal fields of the IIO device into
> the framework.
>
> Because the iio_priv_to_dev() will be hidden some pre-work is done to
> try to remove it from some interrupt handlers.
> iio_priv_to_dev() will become a function call and won't be expandable
> into place (as-is now as an inline function).
>
I'll defer this series.
A cleanup of iio_priv_to_dev() doesn't look like a bit detour.
> Changelog v1 -> v2:
> - add pre-work patches that remove some calls to iio_priv_to_dev() from
> interrupt handlers
> - renamed iio_dev_priv -> iio_dev_opaque
> - moved the iio_dev_opaque to 'include/linux/iio/iio-opaque.h' this way
> it should be usable for debugging
> - the iio_priv() call, is still an inline function that returns an
> 'indio_dev->priv' reference; this field is added to 'struct iio_dev';
> the reference is computed in iio_device_alloc() and should be
> cacheline aligned
> - the to_iio_dev_opaque() container is in the
> 'include/linux/iio/iio-opaque.h' header; it's still implemented with
> some pointer arithmetic; one idea was to do it via an
> 'indio_dev->opaque' field; that may still be an optionif there are
> some opinions in that direction
>
> Alexandru Ardelean (8):
> iio: proximity: ping: pass reference to IIO device via call-stack
> iio: at91-sama5d2_adc: pass ref to IIO device via param for int
> function
> iio: at91_adc: pass ref to IIO device via param for int function
> iio: stm32-dfsdm-adc: pass iio device as arg for the interrupt handler
> iio: stm32-adc: pass iio device as arg for the interrupt handler
> iio: core: wrap IIO device into an iio_dev_opaque object
> iio: core: simplify alloc alignment code
> iio: core: move debugfs data on the private iio dev info
>
> drivers/iio/adc/at91-sama5d2_adc.c | 7 ++-
> drivers/iio/adc/at91_adc.c | 5 +-
> drivers/iio/adc/stm32-adc.c | 10 ++--
> drivers/iio/adc/stm32-dfsdm-adc.c | 6 +--
> drivers/iio/industrialio-core.c | 75 ++++++++++++++++++++----------
> drivers/iio/proximity/ping.c | 5 +-
> include/linux/iio/iio-opaque.h | 27 +++++++++++
> include/linux/iio/iio.h | 24 +++-------
> 8 files changed, 99 insertions(+), 60 deletions(-)
> create mode 100644 include/linux/iio/iio-opaque.h
>
prev parent reply other threads:[~2020-05-22 6:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 13:17 [PATCH v2 0/8] iio: core: wrap IIO device into an iio_dev_opaque object Alexandru Ardelean
2020-05-14 13:17 ` [PATCH v2 1/8] iio: proximity: ping: pass reference to IIO device via call-stack Alexandru Ardelean
2020-05-16 17:12 ` Jonathan Cameron
2020-05-14 13:17 ` [PATCH v2 2/8] iio: at91-sama5d2_adc: pass ref to IIO device via param for int function Alexandru Ardelean
2020-05-16 17:15 ` Jonathan Cameron
2020-05-14 13:17 ` [PATCH v2 3/8] iio: at91_adc: " Alexandru Ardelean
2020-05-16 17:17 ` Jonathan Cameron
2020-05-18 8:32 ` Ardelean, Alexandru
2020-05-21 18:19 ` Jonathan Cameron
2020-05-14 13:17 ` [PATCH v2 4/8] iio: stm32-dfsdm-adc: pass iio device as arg for the interrupt handler Alexandru Ardelean
2020-05-16 17:20 ` Jonathan Cameron
2020-05-14 13:17 ` [PATCH v2 5/8] iio: stm32-adc: " Alexandru Ardelean
2020-05-16 17:21 ` Jonathan Cameron
2020-05-14 13:17 ` [PATCH v2 6/8] iio: core: wrap IIO device into an iio_dev_opaque object Alexandru Ardelean
2020-05-16 17:28 ` Jonathan Cameron
2020-05-14 13:17 ` [PATCH v2 7/8] iio: core: simplify alloc alignment code Alexandru Ardelean
2020-05-15 7:12 ` Sa, Nuno
2020-05-15 11:47 ` Ardelean, Alexandru
2020-05-15 12:37 ` Sa, Nuno
2020-05-16 17:30 ` Jonathan Cameron
2020-05-14 13:17 ` [PATCH v2 8/8] iio: core: move debugfs data on the private iio dev info Alexandru Ardelean
2020-05-22 6:58 ` Ardelean, Alexandru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=036bd63f14707d9c99273e334ac21eb68b29ea4c.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=ak@it-klinger.de \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=eugen.hristev@microchip.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=ludovic.desroches@microchip.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).