* [PATCH] clk: mediatek: mt81xx: Ensure fhctl code is available
@ 2023-03-20 9:13 Arnd Bergmann
2023-03-20 9:15 ` AngeloGioacchino Del Regno
2023-03-20 19:25 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2023-03-20 9:13 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Matthias Brugger, Chen-Yu Tsai,
AngeloGioacchino Del Regno
Cc: Arnd Bergmann, Edward-JW Yang, Miles Chen, Johnson Wang,
Fabien Parent, linux-clk, linux-kernel, linux-arm-kernel,
linux-mediatek
From: Arnd Bergmann <arnd@arndb.de>
Just like in commit eddc63094855 ("clk: mediatek: Ensure fhctl code is
available for COMMON_CLK_MT6795"), these three need the shared driver
code, otherwise they run into link errors such as:
aarch64-linux/bin/aarch64-linux-ld: drivers/clk/mediatek/clk-mt8192-apmixedsys.o: in function `clk_mt8192_apmixed_probe':
clk-mt8192-apmixedsys.c:(.text+0x134): undefined reference to `fhctl_parse_dt'
Fixes: 45a5cbe05d1f ("clk: mediatek: mt8173: Add support for frequency hopping through FHCTL")
Fixes: 4d586e10c428 ("clk: mediatek: mt8192: Add support for frequency hopping through FHCTL")
Fixes: da4a82dc67b0 ("clk: mediatek: mt8195: Add support for frequency hopping through FHCTL")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/mediatek/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig
index c707c6fe45a3..61e3266d2346 100644
--- a/drivers/clk/mediatek/Kconfig
+++ b/drivers/clk/mediatek/Kconfig
@@ -478,6 +478,7 @@ config COMMON_CLK_MT8173
tristate "Clock driver for MediaTek MT8173"
depends on ARM64 || COMPILE_TEST
select COMMON_CLK_MEDIATEK
+ select COMMON_CLK_MEDIATEK_FHCTL
default ARCH_MEDIATEK
help
This driver supports MediaTek MT8173 basic clocks and clocks
@@ -686,6 +687,7 @@ config COMMON_CLK_MT8192
tristate "Clock driver for MediaTek MT8192"
depends on ARM64 || COMPILE_TEST
select COMMON_CLK_MEDIATEK
+ select COMMON_CLK_MEDIATEK_FHCTL
default ARM64
help
This driver supports MediaTek MT8192 basic clocks.
@@ -766,6 +768,7 @@ config COMMON_CLK_MT8195
bool "Clock driver for MediaTek MT8195"
depends on ARM64 || COMPILE_TEST
select COMMON_CLK_MEDIATEK
+ select COMMON_CLK_MEDIATEK_FHCTL
default ARCH_MEDIATEK
help
This driver supports MediaTek MT8195 clocks.
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: mediatek: mt81xx: Ensure fhctl code is available
2023-03-20 9:13 [PATCH] clk: mediatek: mt81xx: Ensure fhctl code is available Arnd Bergmann
@ 2023-03-20 9:15 ` AngeloGioacchino Del Regno
2023-03-20 19:25 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-20 9:15 UTC (permalink / raw)
To: Arnd Bergmann, Michael Turquette, Stephen Boyd, Matthias Brugger,
Chen-Yu Tsai
Cc: Arnd Bergmann, Edward-JW Yang, Miles Chen, Johnson Wang,
Fabien Parent, linux-clk, linux-kernel, linux-arm-kernel,
linux-mediatek
Il 20/03/23 10:13, Arnd Bergmann ha scritto:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Just like in commit eddc63094855 ("clk: mediatek: Ensure fhctl code is
> available for COMMON_CLK_MT6795"), these three need the shared driver
> code, otherwise they run into link errors such as:
>
> aarch64-linux/bin/aarch64-linux-ld: drivers/clk/mediatek/clk-mt8192-apmixedsys.o: in function `clk_mt8192_apmixed_probe':
> clk-mt8192-apmixedsys.c:(.text+0x134): undefined reference to `fhctl_parse_dt'
>
> Fixes: 45a5cbe05d1f ("clk: mediatek: mt8173: Add support for frequency hopping through FHCTL")
> Fixes: 4d586e10c428 ("clk: mediatek: mt8192: Add support for frequency hopping through FHCTL")
> Fixes: da4a82dc67b0 ("clk: mediatek: mt8195: Add support for frequency hopping through FHCTL")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
....and sorry for this big miss.
Regards,
Angelo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: mediatek: mt81xx: Ensure fhctl code is available
2023-03-20 9:13 [PATCH] clk: mediatek: mt81xx: Ensure fhctl code is available Arnd Bergmann
2023-03-20 9:15 ` AngeloGioacchino Del Regno
@ 2023-03-20 19:25 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2023-03-20 19:25 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Arnd Bergmann, Chen-Yu Tsai,
Matthias Brugger, Michael Turquette
Cc: Arnd Bergmann, Edward-JW Yang, Miles Chen, Johnson Wang,
Fabien Parent, linux-clk, linux-kernel, linux-arm-kernel,
linux-mediatek
Quoting Arnd Bergmann (2023-03-20 02:13:42)
> From: Arnd Bergmann <arnd@arndb.de>
>
> Just like in commit eddc63094855 ("clk: mediatek: Ensure fhctl code is
> available for COMMON_CLK_MT6795"), these three need the shared driver
> code, otherwise they run into link errors such as:
>
> aarch64-linux/bin/aarch64-linux-ld: drivers/clk/mediatek/clk-mt8192-apmixedsys.o: in function `clk_mt8192_apmixed_probe':
> clk-mt8192-apmixedsys.c:(.text+0x134): undefined reference to `fhctl_parse_dt'
>
> Fixes: 45a5cbe05d1f ("clk: mediatek: mt8173: Add support for frequency hopping through FHCTL")
> Fixes: 4d586e10c428 ("clk: mediatek: mt8192: Add support for frequency hopping through FHCTL")
> Fixes: da4a82dc67b0 ("clk: mediatek: mt8195: Add support for frequency hopping through FHCTL")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-20 19:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-20 9:13 [PATCH] clk: mediatek: mt81xx: Ensure fhctl code is available Arnd Bergmann
2023-03-20 9:15 ` AngeloGioacchino Del Regno
2023-03-20 19:25 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).