* [PATCH] fpga: xilinx-pr-decoupler: Use readl wrapper instead of pure readl
@ 2023-03-21 15:33 Michal Simek
2023-03-21 17:10 ` Tom Rix
0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2023-03-21 15:33 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Moritz Fischer, Tom Rix, Wu Hao, Xu Yilun, linux-arm-kernel, linux-fpga
Driver has IO wrappers but xlnx_pr_decouple_read() is not used and readl is
used instead which is just wrong.
It is also generating sparse issue that xlnx_pr_decouple_read() is unused.
Signed-off-by: Michal Simek <michal.simek@amd.com>
---
Created based on discussion with Tom here
https://lore.kernel.org/r/20230317230617.1673923-1-trix@redhat.com
---
drivers/fpga/xilinx-pr-decoupler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
index 2d9c491f7be9..b76d85449b8f 100644
--- a/drivers/fpga/xilinx-pr-decoupler.c
+++ b/drivers/fpga/xilinx-pr-decoupler.c
@@ -69,7 +69,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
if (err)
return err;
- status = readl(priv->io_base);
+ status = xlnx_pr_decouple_read(priv, CTRL_OFFSET);
clk_disable(priv->clk);
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fpga: xilinx-pr-decoupler: Use readl wrapper instead of pure readl
2023-03-21 15:33 [PATCH] fpga: xilinx-pr-decoupler: Use readl wrapper instead of pure readl Michal Simek
@ 2023-03-21 17:10 ` Tom Rix
2023-03-25 7:38 ` Xu Yilun
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rix @ 2023-03-21 17:10 UTC (permalink / raw)
To: Michal Simek, linux-kernel, monstr, michal.simek, git
Cc: Moritz Fischer, Wu Hao, Xu Yilun, linux-arm-kernel, linux-fpga
On 3/21/23 8:33 AM, Michal Simek wrote:
> Driver has IO wrappers but xlnx_pr_decouple_read() is not used and readl is
> used instead which is just wrong.
> It is also generating sparse issue that xlnx_pr_decouple_read() is unused.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> Created based on discussion with Tom here
> https://lore.kernel.org/r/20230317230617.1673923-1-trix@redhat.com
> ---
> drivers/fpga/xilinx-pr-decoupler.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> index 2d9c491f7be9..b76d85449b8f 100644
> --- a/drivers/fpga/xilinx-pr-decoupler.c
> +++ b/drivers/fpga/xilinx-pr-decoupler.c
> @@ -69,7 +69,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
> if (err)
> return err;
>
> - status = readl(priv->io_base);
> + status = xlnx_pr_decouple_read(priv, CTRL_OFFSET);
Thanks for the change.
Reviewed-by: Tom Rix <trix@redhat.com>
>
> clk_disable(priv->clk);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fpga: xilinx-pr-decoupler: Use readl wrapper instead of pure readl
2023-03-21 17:10 ` Tom Rix
@ 2023-03-25 7:38 ` Xu Yilun
0 siblings, 0 replies; 3+ messages in thread
From: Xu Yilun @ 2023-03-25 7:38 UTC (permalink / raw)
To: Tom Rix
Cc: Michal Simek, linux-kernel, monstr, michal.simek, git,
Moritz Fischer, Wu Hao, linux-arm-kernel, linux-fpga
On 2023-03-21 at 10:10:14 -0700, Tom Rix wrote:
>
> On 3/21/23 8:33 AM, Michal Simek wrote:
> > Driver has IO wrappers but xlnx_pr_decouple_read() is not used and readl is
> > used instead which is just wrong.
> > It is also generating sparse issue that xlnx_pr_decouple_read() is unused.
> >
> > Signed-off-by: Michal Simek <michal.simek@amd.com>
> > ---
> >
> > Created based on discussion with Tom here
> > https://lore.kernel.org/r/20230317230617.1673923-1-trix@redhat.com
> > ---
> > drivers/fpga/xilinx-pr-decoupler.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> > index 2d9c491f7be9..b76d85449b8f 100644
> > --- a/drivers/fpga/xilinx-pr-decoupler.c
> > +++ b/drivers/fpga/xilinx-pr-decoupler.c
> > @@ -69,7 +69,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
> > if (err)
> > return err;
> > - status = readl(priv->io_base);
> > + status = xlnx_pr_decouple_read(priv, CTRL_OFFSET);
>
> Thanks for the change.
>
> Reviewed-by: Tom Rix <trix@redhat.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Applied.
>
> > clk_disable(priv->clk);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-25 7:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-21 15:33 [PATCH] fpga: xilinx-pr-decoupler: Use readl wrapper instead of pure readl Michal Simek
2023-03-21 17:10 ` Tom Rix
2023-03-25 7:38 ` Xu Yilun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).