* [PATCH net-next] net/smc: remove unused inline function smc_curs_read
@ 2020-04-29 13:26 YueHaibing
2020-04-29 15:15 ` Karsten Graul
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-04-29 13:26 UTC (permalink / raw)
To: ubraun, kgraul, davem, kuba, yuehaibing; +Cc: linux-s390, netdev, linux-kernel
commit bac6de7b6370 ("net/smc: eliminate cursor read and write calls")
left behind this.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/smc/smc_cdc.h | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/net/smc/smc_cdc.h b/net/smc/smc_cdc.h
index 861dc24c588c..5a19e5e2280e 100644
--- a/net/smc/smc_cdc.h
+++ b/net/smc/smc_cdc.h
@@ -97,23 +97,6 @@ static inline void smc_curs_add(int size, union smc_host_cursor *curs,
}
}
-/* SMC cursors are 8 bytes long and require atomic reading and writing */
-static inline u64 smc_curs_read(union smc_host_cursor *curs,
- struct smc_connection *conn)
-{
-#ifndef KERNEL_HAS_ATOMIC64
- unsigned long flags;
- u64 ret;
-
- spin_lock_irqsave(&conn->acurs_lock, flags);
- ret = curs->acurs;
- spin_unlock_irqrestore(&conn->acurs_lock, flags);
- return ret;
-#else
- return atomic64_read(&curs->acurs);
-#endif
-}
-
/* Copy cursor src into tgt */
static inline void smc_curs_copy(union smc_host_cursor *tgt,
union smc_host_cursor *src,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net/smc: remove unused inline function smc_curs_read
2020-04-29 13:26 [PATCH net-next] net/smc: remove unused inline function smc_curs_read YueHaibing
@ 2020-04-29 15:15 ` Karsten Graul
0 siblings, 0 replies; 2+ messages in thread
From: Karsten Graul @ 2020-04-29 15:15 UTC (permalink / raw)
To: YueHaibing, ubraun, davem, kuba; +Cc: linux-s390, netdev, linux-kernel
On 29/04/2020 15:26, YueHaibing wrote:
> commit bac6de7b6370 ("net/smc: eliminate cursor read and write calls")
> left behind this.
>
Thanks, good catch. Your patch will be part of our next patch submission.
Regards, Karsten
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> net/smc/smc_cdc.h | 17 -----------------
> 1 file changed, 17 deletions(-)
>
> diff --git a/net/smc/smc_cdc.h b/net/smc/smc_cdc.h
> index 861dc24c588c..5a19e5e2280e 100644
> --- a/net/smc/smc_cdc.h
> +++ b/net/smc/smc_cdc.h
> @@ -97,23 +97,6 @@ static inline void smc_curs_add(int size, union smc_host_cursor *curs,
> }
> }
>
> -/* SMC cursors are 8 bytes long and require atomic reading and writing */
> -static inline u64 smc_curs_read(union smc_host_cursor *curs,
> - struct smc_connection *conn)
> -{
> -#ifndef KERNEL_HAS_ATOMIC64
> - unsigned long flags;
> - u64 ret;
> -
> - spin_lock_irqsave(&conn->acurs_lock, flags);
> - ret = curs->acurs;
> - spin_unlock_irqrestore(&conn->acurs_lock, flags);
> - return ret;
> -#else
> - return atomic64_read(&curs->acurs);
> -#endif
> -}
> -
> /* Copy cursor src into tgt */
> static inline void smc_curs_copy(union smc_host_cursor *tgt,
> union smc_host_cursor *src,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-29 15:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29 13:26 [PATCH net-next] net/smc: remove unused inline function smc_curs_read YueHaibing
2020-04-29 15:15 ` Karsten Graul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).