From: Peter Oberparleiter <oberpar@linux.ibm.com>
To: Tri Vo <trong@android.com>
Cc: ghackmann@android.com, ndesaulniers@google.com,
linux-kernel@vger.kernel.org, kernel-team@android.com,
Trilok Soni <tsoni@quicinc.com>,
Prasad Sodagudi <psodagud@quicinc.com>
Subject: Re: [PATCH 3/4] gcov: clang: link/unlink profiling data set.
Date: Wed, 16 Jan 2019 17:14:03 +0100 [thread overview]
Message-ID: <03d3a8d0-b9cd-28e9-6365-d74adcd4db59@linux.ibm.com> (raw)
In-Reply-To: <20190114210426.177543-4-trong@android.com>
On 14.01.2019 22:04, Tri Vo wrote:
> From: Nick Desaulniers <ndesaulniers@google.com>
>
> gcov.h defines an interface to access gcov_info data.
>
> Add Clang implementation of gcov_info_link/gcov_info_unlink interfaces.
>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Tri Vo <trong@android.com>
> Tested-by: Trilok Soni <tsoni@quicinc.com>
> Tested-by: Prasad Sodagudi <psodagud@quicinc.com>
> Tested-by: Tri Vo <trong@android.com>
> ---
> kernel/gcov/clang.c | 33 ++++++++++++++++++++++++++++-----
> 1 file changed, 28 insertions(+), 5 deletions(-)
Please merge this patch into patch 2 as it fixes a number of problems in
that patch.
>
> diff --git a/kernel/gcov/clang.c b/kernel/gcov/clang.c
> index b00795d28137..ea42deb852f7 100644
> --- a/kernel/gcov/clang.c
> +++ b/kernel/gcov/clang.c
[...]
> +/**
> + * gcov_info_unlink - unlink/remove profiling data set from the list
> + * @prev: previous profiling data set
> + * @info: profiling data set
> + */
> +void gcov_info_unlink(struct gcov_info *prev, struct gcov_info *info)
> +{
> + if (prev)
> + list_del(&prev->head);
This is incorrect - gcov_info_unlink should remove info from the list,
not its predecessor prev.
--
Peter Oberparleiter
Linux on Z Development - IBM Germany
next prev parent reply other threads:[~2019-01-16 16:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 21:04 [PATCH 0/4] gcov: add Clang support Tri Vo
2019-01-14 21:04 ` [PATCH 1/4] gcov: clang: move common gcc code into gcc_base.c Tri Vo
2019-01-16 15:32 ` Peter Oberparleiter
2019-01-14 21:04 ` [PATCH 2/4] gcov: clang support Tri Vo
2019-01-16 16:06 ` Peter Oberparleiter
2019-01-14 21:04 ` [PATCH 3/4] gcov: clang: link/unlink profiling data set Tri Vo
2019-01-16 16:14 ` Peter Oberparleiter [this message]
2019-01-14 21:04 ` [PATCH 4/4] gcov: clang: pick GCC vs Clang format depending on compiler Tri Vo
2019-01-14 21:11 ` Nick Desaulniers
2019-01-15 1:24 ` Masahiro Yamada
2019-01-15 17:52 ` Tri Vo
2019-01-14 21:32 ` [PATCH 0/4] gcov: add Clang support Nick Desaulniers
2019-01-14 21:53 ` Tri Vo
2019-01-14 22:00 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03d3a8d0-b9cd-28e9-6365-d74adcd4db59@linux.ibm.com \
--to=oberpar@linux.ibm.com \
--cc=ghackmann@android.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=psodagud@quicinc.com \
--cc=trong@android.com \
--cc=tsoni@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).