linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tri Vo <trong@android.com>
To: oberpar@linux.ibm.com
Cc: ghackmann@android.com, ndesaulniers@google.com,
	linux-kernel@vger.kernel.org, kernel-team@android.com,
	Tri Vo <trong@android.com>
Subject: [PATCH 4/4] gcov: clang: pick GCC vs Clang format depending on compiler
Date: Mon, 14 Jan 2019 13:04:26 -0800	[thread overview]
Message-ID: <20190114210426.177543-5-trong@android.com> (raw)
In-Reply-To: <20190114210426.177543-1-trong@android.com>

Clang gcov format is only supported by Clang compiler, and Clang
compiler only supports Clang format.

We set gcov format to depend on which compiler (GCC or Clang) is used.

Automatic format detection behavior is preserved because:
If GCC is used, one of the GCC gcov formats is selected.
If Clang is used, Clang gcov format is selected.

Signed-off-by: Tri Vo <trong@android.com>
---
 kernel/gcov/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
index eb428e570923..37ec551d4039 100644
--- a/kernel/gcov/Kconfig
+++ b/kernel/gcov/Kconfig
@@ -60,6 +60,8 @@ choice
 	In such a case, change this option to adjust the format used in the
 	kernel accordingly.
 
+	Select Clang gcov format if building with Clang compiler.
+
 config GCOV_FORMAT_3_4
 	bool "GCC 3.4 format"
 	depends on CC_IS_GCC && GCC_VERSION < 40700
@@ -68,11 +70,13 @@ config GCOV_FORMAT_3_4
 
 config GCOV_FORMAT_4_7
 	bool "GCC 4.7 format"
+	depends on CC_IS_GCC
 	---help---
 	Select this option to use the format defined by GCC 4.7.
 
 config GCOV_FORMAT_CLANG
 	bool "Clang format"
+	depends on CC_IS_CLANG
 	---help---
 	Select this option to use the format defined by Clang.
 
-- 
2.20.1.97.g81188d93c3-goog


  parent reply	other threads:[~2019-01-14 21:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 21:04 [PATCH 0/4] gcov: add Clang support Tri Vo
2019-01-14 21:04 ` [PATCH 1/4] gcov: clang: move common gcc code into gcc_base.c Tri Vo
2019-01-16 15:32   ` Peter Oberparleiter
2019-01-14 21:04 ` [PATCH 2/4] gcov: clang support Tri Vo
2019-01-16 16:06   ` Peter Oberparleiter
2019-01-14 21:04 ` [PATCH 3/4] gcov: clang: link/unlink profiling data set Tri Vo
2019-01-16 16:14   ` Peter Oberparleiter
2019-01-14 21:04 ` Tri Vo [this message]
2019-01-14 21:11   ` [PATCH 4/4] gcov: clang: pick GCC vs Clang format depending on compiler Nick Desaulniers
2019-01-15  1:24   ` Masahiro Yamada
2019-01-15 17:52     ` Tri Vo
2019-01-14 21:32 ` [PATCH 0/4] gcov: add Clang support Nick Desaulniers
2019-01-14 21:53   ` Tri Vo
2019-01-14 22:00     ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114210426.177543-5-trong@android.com \
    --to=trong@android.com \
    --cc=ghackmann@android.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=oberpar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).