From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz,
tiwai@suse.com, rohitkr@codeaurora.org,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Subject: Re: [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API
Date: Mon, 21 Sep 2020 22:20:22 +0100 [thread overview]
Message-ID: <040290a8-26a3-ab9c-04dc-beb23ee827e8@linaro.org> (raw)
In-Reply-To: <1600409084-29093-4-git-send-email-srivasam@codeaurora.org>
On 18/09/2020 07:04, Srinivasa Rao Mandadapu wrote:
> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>
> Signed-off-by: Srinivasa Rao <srivasam@codeaurora.org>
> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> ---
> sound/soc/qcom/lpass-cpu.c | 2 +-
> sound/soc/qcom/lpass-platform.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c
> index 1ee6d8b..5d84f63 100644
> --- a/sound/soc/qcom/lpass-cpu.c
> +++ b/sound/soc/qcom/lpass-cpu.c
> @@ -575,7 +575,7 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev)
>
> of_lpass_cpu_parse_dai_data(dev, drvdata);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-lpaif");
Interesting!! this patch
https://lore.kernel.org/alsa-devel/1597402388-14112-11-git-send-email-rohitkr@codeaurora.org/
just took it out and you add it back in!
Index is always preferred over name w.r.t device tree bindings, so lets
stick with that for now!
Unless you have any strong reason to lookup resource by name?
--srini
>
> drvdata->lpaif = devm_ioremap_resource(dev, res);
> if (IS_ERR((void const __force *)drvdata->lpaif)) {
> diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c
> index df692ed..35aead1 100644
> --- a/sound/soc/qcom/lpass-platform.c
> +++ b/sound/soc/qcom/lpass-platform.c
> @@ -638,7 +638,7 @@ int asoc_qcom_lpass_platform_register(struct platform_device *pdev)
> struct lpass_variant *v = drvdata->variant;
> int ret;
>
> - drvdata->lpaif_irq = platform_get_irq(pdev, 0);
> + drvdata->lpaif_irq = platform_get_irq_byname(pdev, "lpass-irq-lpaif");
> if (drvdata->lpaif_irq < 0)
> return -ENODEV;
>
>
next prev parent reply other threads:[~2020-09-21 21:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 6:04 [PATCH v6 0/5] Qualcomm's lpass-hdmi ASoC driver to support audio over dp port Srinivasa Rao Mandadapu
2020-09-18 6:04 ` [PATCH v6 1/5] ASoC: Add sc7180-lpass binding header hdmi define Srinivasa Rao Mandadapu
2020-09-18 6:04 ` [PATCH v6 2/5] ASoC: dt-bindings: Add dt binding for lpass hdmi Srinivasa Rao Mandadapu
2020-09-23 20:41 ` Rob Herring
2020-09-18 6:04 ` [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API Srinivasa Rao Mandadapu
2020-09-21 21:20 ` Srinivas Kandagatla [this message]
2020-09-22 11:08 ` Mark Brown
2020-09-22 11:22 ` Srinivas Kandagatla
2020-09-22 11:43 ` Mark Brown
2020-09-22 12:53 ` Rohit Kumar
2020-09-22 13:57 ` Srinivas Kandagatla
2020-09-18 6:04 ` [PATCH v6 4/5] ASoC: qcom: Add support for lpass hdmi driver Srinivasa Rao Mandadapu
2020-09-21 21:20 ` Srinivas Kandagatla
2020-09-23 8:41 ` Srinivasa Rao Mandadapu
2020-09-18 6:04 ` [PATCH v6 5/5] ASoC: qcom: sc7180: Add support for audio over DP Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=040290a8-26a3-ab9c-04dc-beb23ee827e8@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srivasam@codeaurora.org \
--cc=tiwai@suse.com \
--cc=vsujithk@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).