From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, robh+dt@kernel.org, plai@codeaurora.org,
bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com,
rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Subject: Re: [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API
Date: Tue, 22 Sep 2020 12:22:38 +0100 [thread overview]
Message-ID: <3866ce69-b7d0-5eb5-e0aa-874d150cd47a@linaro.org> (raw)
In-Reply-To: <20200922110825.GN4792@sirena.org.uk>
On 22/09/2020 12:08, Mark Brown wrote:
>> On 18/09/2020 07:04, Srinivasa Rao Mandadapu wrote:
>>> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-lpaif");
>> Index is always preferred over name w.r.t device tree bindings, so lets
>> stick with that for now!
> It is? That's not usually the case...
>
>> Unless you have any strong reason to lookup resource by name?
> Looking things up by name tends to make the DT easier to read (since
> things are named).
I agree with you on this and I see the point, but Rob had a very
different opinion about the reg-names bindings to start with.
This topic been discussed in the past with Rob in many instances ex:
https://lore.kernel.org/linux-devicetree/CAL_Jsq+MMunmVWqeW9v2RyzsMKP+=kMzeTHNMG4JDHM7Fy0HBg@mail.gmail.com/
According to him, reg-names seems to be highly discouraged as it came
along for the OMAP folks and was related to the hwmods stuff.
--srini
next prev parent reply other threads:[~2020-09-22 11:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 6:04 [PATCH v6 0/5] Qualcomm's lpass-hdmi ASoC driver to support audio over dp port Srinivasa Rao Mandadapu
2020-09-18 6:04 ` [PATCH v6 1/5] ASoC: Add sc7180-lpass binding header hdmi define Srinivasa Rao Mandadapu
2020-09-18 6:04 ` [PATCH v6 2/5] ASoC: dt-bindings: Add dt binding for lpass hdmi Srinivasa Rao Mandadapu
2020-09-23 20:41 ` Rob Herring
2020-09-18 6:04 ` [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API Srinivasa Rao Mandadapu
2020-09-21 21:20 ` Srinivas Kandagatla
2020-09-22 11:08 ` Mark Brown
2020-09-22 11:22 ` Srinivas Kandagatla [this message]
2020-09-22 11:43 ` Mark Brown
2020-09-22 12:53 ` Rohit Kumar
2020-09-22 13:57 ` Srinivas Kandagatla
2020-09-18 6:04 ` [PATCH v6 4/5] ASoC: qcom: Add support for lpass hdmi driver Srinivasa Rao Mandadapu
2020-09-21 21:20 ` Srinivas Kandagatla
2020-09-23 8:41 ` Srinivasa Rao Mandadapu
2020-09-18 6:04 ` [PATCH v6 5/5] ASoC: qcom: sc7180: Add support for audio over DP Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3866ce69-b7d0-5eb5-e0aa-874d150cd47a@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srivasam@codeaurora.org \
--cc=tiwai@suse.com \
--cc=vsujithk@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).