From: Vijay Balakrishna <vijayb@linux.microsoft.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>, Song Liu <songliubraving@fb.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Allen Pais <apais@microsoft.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged
Date: Mon, 14 Sep 2020 22:04:11 -0700 [thread overview]
Message-ID: <041b4c73-42b0-5cb1-716f-0a0d466fcdf0@linux.microsoft.com> (raw)
In-Reply-To: <20200910220145.5j7iogqulmvg5vr6@black.fi.intel.com>
On 9/10/2020 3:01 PM, Kirill A. Shutemov wrote:
> On Thu, Sep 10, 2020 at 01:47:39PM -0700, Vijay Balakrishna wrote:
>> When memory is hotplug added or removed the min_free_kbytes must be
>> recalculated based on what is expected by khugepaged. Currently
>> after hotplug, min_free_kbytes will be set to a lower default and higher
>> default set when THP enabled is lost. This leaves the system with small
>> min_free_kbytes which isn't suitable for systems especially with network
>> intensive loads. Typical failure symptoms include HW WATCHDOG reset,
>> soft lockup hang notices, NETDEVICE WATCHDOG timeouts, and OOM process
>> kills.
>>
>> Fixes: f000565adb77 ("thp: set recommended min free kbytes")
>>
>> Signed-off-by: Vijay Balakrishna <vijayb@linux.microsoft.com>
>> Cc: stable@vger.kernel.org
>
> NAK. It would override min_free_kbytes set by user.
Hi Kirill,
To fix the issue you raised I just submitted
https://lore.kernel.org/lkml/1600145748-26518-1-git-send-email-vijayb@linux.microsoft.com/
Thanks,
Vijay
>
next prev parent reply other threads:[~2020-09-15 5:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 20:47 [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged Vijay Balakrishna
2020-09-10 22:01 ` Kirill A. Shutemov
2020-09-10 22:28 ` Pavel Tatashin
2020-09-10 22:56 ` Vijay Balakrishna
2020-09-15 5:04 ` Vijay Balakrishna [this message]
2020-09-14 14:33 ` Michal Hocko
2020-09-14 16:57 ` Vijay Balakrishna
2020-09-15 8:18 ` Michal Hocko
2020-09-15 15:48 ` Vijay Balakrishna
2020-09-16 6:53 ` Michal Hocko
2020-09-16 18:28 ` Vijay Balakrishna
2020-09-17 12:12 ` Michal Hocko
2020-09-17 18:03 ` Vijay Balakrishna
2020-09-18 5:45 ` Michal Hocko
2020-09-18 15:32 ` Vijay Balakrishna
2020-09-21 7:00 ` Michal Hocko
2020-09-15 18:22 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=041b4c73-42b0-5cb1-716f-0a0d466fcdf0@linux.microsoft.com \
--to=vijayb@linux.microsoft.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apais@microsoft.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
--cc=pasha.tatashin@soleen.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).