From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Enrico Weigelt, metux IT consult" <info@metux.net>,
jslaby@suse.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] drivers: tty: serial: 8250_bcm2835aux: use devm_platform_ioremap_resource()
Date: Wed, 13 Mar 2019 18:13:40 +0100 [thread overview]
Message-ID: <0458c818-085f-53f3-4078-557fa752854b@metux.net> (raw)
In-Reply-To: <20190313143654.GA7489@kroah.com>
On 13.03.19 15:36, Greg KH wrote:
> Also, usually RFC like patches and series are ignored, I know I almost
> always ignore them because if the author doesn't think they are ready to
> be reviewed, why would I spend time on them compared to other patches
> that their authors think are ready for review.
Okay, but then, how is the best way to ask for help ?
In my case here, there're several things still unclear to me, eg:
* struct uart_port -> mapbase:
=> seems to be used by most drivers, but some also clear it later, eg.
uartlite does so when uart_add_one_port() call failed. is that
really necessary ?
* struct uart_port -> mapsize:
=> seems to be used only rarely. most drivers use either fixed params
on the memory mapping functions, or take it from some function.
wouldn't it be better if all would fill out that field and later
use it consistently ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
next prev parent reply other threads:[~2019-03-13 17:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 14:57 RFC: cleaning up the serial drivers and use struct resource Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 1/8] drivers: tty: serial: 8250_bcm2835aux: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
2019-03-12 16:33 ` Greg KH
2019-03-13 6:59 ` Enrico Weigelt, metux IT consult
2019-03-13 11:28 ` Miguel Ojeda
2019-03-13 14:09 ` Enrico Weigelt, metux IT consult
2019-03-13 14:36 ` Greg KH
2019-03-13 17:13 ` Enrico Weigelt, metux IT consult [this message]
2019-03-12 14:57 ` [PATCH 2/8] drivers: tty: serial: 8250_dw: use devm_ioremap_resource() Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 3/8] drivers: tty: serial: 8250_ingenic: " Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 4/8] drivers: tty: serial: " Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 5/8] drivers: tty: serial: introduce struct resource Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 6/8] drivers: tty: serial: vt8500: use memres Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 7/8] drivers: tty: serial: " Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 8/8] drivers: tty: serial: xilinx_uartps: use helpers Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0458c818-085f-53f3-4078-557fa752854b@metux.net \
--to=lkml@metux.net \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).