linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	"Enrico Weigelt, metux IT consult" <info@metux.net>,
	Jiri Slaby <jslaby@suse.com>,
	linux-serial@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/8] drivers: tty: serial: 8250_bcm2835aux: use devm_platform_ioremap_resource()
Date: Wed, 13 Mar 2019 15:09:23 +0100	[thread overview]
Message-ID: <939d94a2-f44d-27a6-e894-1f846c6b3b5c@metux.net> (raw)
In-Reply-To: <CANiq72=SBFzRVhpkH8V+=5E-adzJ4v6UGAPKfr18wnCB0rcoQA@mail.gmail.com>

On 13.03.19 12:28, Miguel Ojeda wrote:

Hi,

> The intro letter seems to be an independent message with a different> subject line -- not sure what threading you expected (?).
hmm, I've sent it via git-send-email --compose. IMHO, this should
send the intro as the first message and the actual patches as reply.

But it seems that didn't work as I hoped.

>> I wrote that this is yet WIP, not meant for actual submission, instead>> just to ask you folks whether my approach in general would be work.>
> That will indeed cause confusion. If you are requesting comments
only,> please do so placing [RFC] or similar in the subject of each patch

Ah, good idea. So I also have this tag in the git repo.
BTW: are there more such conventions I should be aware of ?

> Another option is sending a message with the repo URL where> development is happening, so interested parties can take a look.
Ok. I had the impression that people here don't really like to look
at some git repos for reviews.

> Even if you are sending some draft patches, it is still a bad idea to> send them incomplete. Basically you are making it harder for early>
reviewers simply by not having written an explanation or at least a>
reference to the explanation.
Understood.


--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287

  reply	other threads:[~2019-03-13 14:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 14:57 RFC: cleaning up the serial drivers and use struct resource Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 1/8] drivers: tty: serial: 8250_bcm2835aux: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
2019-03-12 16:33   ` Greg KH
2019-03-13  6:59     ` Enrico Weigelt, metux IT consult
2019-03-13 11:28       ` Miguel Ojeda
2019-03-13 14:09         ` Enrico Weigelt, metux IT consult [this message]
2019-03-13 14:36       ` Greg KH
2019-03-13 17:13         ` Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 2/8] drivers: tty: serial: 8250_dw: use devm_ioremap_resource() Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 3/8] drivers: tty: serial: 8250_ingenic: " Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 4/8] drivers: tty: serial: " Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 5/8] drivers: tty: serial: introduce struct resource Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 6/8] drivers: tty: serial: vt8500: use memres Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 7/8] drivers: tty: serial: " Enrico Weigelt, metux IT consult
2019-03-12 14:57 ` [PATCH 8/8] drivers: tty: serial: xilinx_uartps: use helpers Enrico Weigelt, metux IT consult

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=939d94a2-f44d-27a6-e894-1f846c6b3b5c@metux.net \
    --to=lkml@metux.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=info@metux.net \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).