linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/hdmi: Use force connectivity quirk on another HP desktop
@ 2020-08-11  9:53 Kai-Heng Feng
  2020-08-12 15:43 ` Kai-Heng Feng
  0 siblings, 1 reply; 4+ messages in thread
From: Kai-Heng Feng @ 2020-08-11  9:53 UTC (permalink / raw)
  To: tiwai
  Cc: Kai-Heng Feng, Jaroslav Kysela, Kai Vehmanen, Nikhil Mahale,
	Pierre-Louis Bossart, Aaron Plattner, Harsha Priya,
	moderated list:SOUND, open list

There's another HP desktop has buggy BIOS which flags the Port
Connectivity bit as no connection.

Apply force connectivity quirk to enable DP/HDMI audio.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 sound/pci/hda/patch_hdmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 4bbd12d3b1b5..b8c8490e568b 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1863,6 +1863,7 @@ static int hdmi_add_cvt(struct hda_codec *codec, hda_nid_t cvt_nid)
 }
 
 static const struct snd_pci_quirk force_connect_list[] = {
+	SND_PCI_QUIRK(0x103c, 0x870f, "HP", 1),
 	SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1),
 	{}
 };
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda/hdmi: Use force connectivity quirk on another HP desktop
  2020-08-11  9:53 [PATCH] ALSA: hda/hdmi: Use force connectivity quirk on another HP desktop Kai-Heng Feng
@ 2020-08-12 15:43 ` Kai-Heng Feng
  2020-08-12 15:47   ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Kai-Heng Feng @ 2020-08-12 15:43 UTC (permalink / raw)
  To: tiwai
  Cc: Jaroslav Kysela, Kai Vehmanen, Nikhil Mahale,
	Pierre-Louis Bossart, Aaron Plattner, Harsha Priya,
	moderated list:SOUND, open list

Hi,

> On Aug 11, 2020, at 17:53, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
> 
> There's another HP desktop has buggy BIOS which flags the Port
> Connectivity bit as no connection.
> 
> Apply force connectivity quirk to enable DP/HDMI audio.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

I guess this patch was omitted as well...

Kai-Heng

> ---
> sound/pci/hda/patch_hdmi.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index 4bbd12d3b1b5..b8c8490e568b 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -1863,6 +1863,7 @@ static int hdmi_add_cvt(struct hda_codec *codec, hda_nid_t cvt_nid)
> }
> 
> static const struct snd_pci_quirk force_connect_list[] = {
> +	SND_PCI_QUIRK(0x103c, 0x870f, "HP", 1),
> 	SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1),
> 	{}
> };
> -- 
> 2.17.1
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda/hdmi: Use force connectivity quirk on another HP desktop
  2020-08-12 15:43 ` Kai-Heng Feng
@ 2020-08-12 15:47   ` Takashi Iwai
  2020-08-12 16:39     ` Kai-Heng Feng
  0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2020-08-12 15:47 UTC (permalink / raw)
  To: Kai-Heng Feng
  Cc: tiwai, Jaroslav Kysela, Kai Vehmanen, Nikhil Mahale,
	Pierre-Louis Bossart, Aaron Plattner, Harsha Priya,
	moderated list:SOUND, open list

On Wed, 12 Aug 2020 17:43:27 +0200,
Kai-Heng Feng wrote:
> 
> Hi,
> 
> > On Aug 11, 2020, at 17:53, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
> > 
> > There's another HP desktop has buggy BIOS which flags the Port
> > Connectivity bit as no connection.
> > 
> > Apply force connectivity quirk to enable DP/HDMI audio.
> > 
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> 
> I guess this patch was omitted as well...

Not omitted but applied to a wrong internal branch, sorry.
Now I rebased to the proper branch and pushed out.


thanks,

Takashi

> 
> Kai-Heng
> 
> > ---
> > sound/pci/hda/patch_hdmi.c | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> > index 4bbd12d3b1b5..b8c8490e568b 100644
> > --- a/sound/pci/hda/patch_hdmi.c
> > +++ b/sound/pci/hda/patch_hdmi.c
> > @@ -1863,6 +1863,7 @@ static int hdmi_add_cvt(struct hda_codec *codec, hda_nid_t cvt_nid)
> > }
> > 
> > static const struct snd_pci_quirk force_connect_list[] = {
> > +	SND_PCI_QUIRK(0x103c, 0x870f, "HP", 1),
> > 	SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1),
> > 	{}
> > };
> > -- 
> > 2.17.1
> > 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda/hdmi: Use force connectivity quirk on another HP desktop
  2020-08-12 15:47   ` Takashi Iwai
@ 2020-08-12 16:39     ` Kai-Heng Feng
  0 siblings, 0 replies; 4+ messages in thread
From: Kai-Heng Feng @ 2020-08-12 16:39 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: tiwai, Jaroslav Kysela, Kai Vehmanen, Nikhil Mahale,
	Pierre-Louis Bossart, Aaron Plattner, Harsha Priya,
	moderated list:SOUND, open list



> On Aug 12, 2020, at 23:47, Takashi Iwai <tiwai@suse.de> wrote:
> 
> On Wed, 12 Aug 2020 17:43:27 +0200,
> Kai-Heng Feng wrote:
>> 
>> Hi,
>> 
>>> On Aug 11, 2020, at 17:53, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
>>> 
>>> There's another HP desktop has buggy BIOS which flags the Port
>>> Connectivity bit as no connection.
>>> 
>>> Apply force connectivity quirk to enable DP/HDMI audio.
>>> 
>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> 
>> I guess this patch was omitted as well...
> 
> Not omitted but applied to a wrong internal branch, sorry.
> Now I rebased to the proper branch and pushed out.

Thanks a lot!

Kai-Heng

> 
> 
> thanks,
> 
> Takashi
> 
>> 
>> Kai-Heng
>> 
>>> ---
>>> sound/pci/hda/patch_hdmi.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>> 
>>> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
>>> index 4bbd12d3b1b5..b8c8490e568b 100644
>>> --- a/sound/pci/hda/patch_hdmi.c
>>> +++ b/sound/pci/hda/patch_hdmi.c
>>> @@ -1863,6 +1863,7 @@ static int hdmi_add_cvt(struct hda_codec *codec, hda_nid_t cvt_nid)
>>> }
>>> 
>>> static const struct snd_pci_quirk force_connect_list[] = {
>>> +	SND_PCI_QUIRK(0x103c, 0x870f, "HP", 1),
>>> 	SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1),
>>> 	{}
>>> };
>>> -- 
>>> 2.17.1
>>> 
>> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-08-12 16:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11  9:53 [PATCH] ALSA: hda/hdmi: Use force connectivity quirk on another HP desktop Kai-Heng Feng
2020-08-12 15:43 ` Kai-Heng Feng
2020-08-12 15:47   ` Takashi Iwai
2020-08-12 16:39     ` Kai-Heng Feng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).