From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Randy Dunlap <rdunlap@infradead.org>, rui.zhang@intel.com
Cc: amit.kucheria@verdurent.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] thermal: netlink: Fix compilation error when CONFIG_NET=n
Date: Tue, 7 Jul 2020 17:49:11 +0200 [thread overview]
Message-ID: <04a6904d-9220-9045-6816-12cf84781f4d@linaro.org> (raw)
In-Reply-To: <66b4c589-48e0-8975-b3b1-79168e3ea5e4@infradead.org>
On 07/07/2020 17:47, Randy Dunlap wrote:
> On 7/7/20 2:01 AM, Daniel Lezcano wrote:
>> When the network is not configured, the netlink are disabled on all
>> the system. The thermal framework assumed the netlink are always
>> opt-in.
>>
>> Fix this by adding a Kconfig option for the netlink notification,
>> defaulting to yes and depending on CONFIG_NET.
>>
>> As the change implies multiple stubs and in order to not pollute the
>> internal thermal header, the thermal_nelink.h has been added and
>> included in the thermal_core.h, so this one regain some kind of
>> clarity.
>>
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---
>> drivers/thermal/Kconfig | 10 ++++
>> drivers/thermal/Makefile | 5 +-
>> drivers/thermal/thermal_core.h | 20 +------
>> drivers/thermal/thermal_netlink.h | 98 +++++++++++++++++++++++++++++++
>> 4 files changed, 114 insertions(+), 19 deletions(-)
>> create mode 100644 drivers/thermal/thermal_netlink.h
>>
>
>
> Hm, now I get this:
>
> ../drivers/thermal/thermal_helpers.c: In function ‘thermal_cdev_set_cur_state’:
> ../drivers/thermal/thermal_helpers.c:182:2: error: implicit declaration of function ‘thermal_notify_cdev_update’; did you mean ‘thermal_notify_cdev_delete’? [-Werror=implicit-function-declaration]
> thermal_notify_cdev_update(cdev->id, target);
>
>
> or should that call be to thermal_notify_cdev_state_update()?
Ah right, the patch applies on top of the v4 which is not yet in
linux-next, I'm waiting for the kernelci loop result.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-07-07 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 9:01 [PATCH] thermal: netlink: Fix compilation error when CONFIG_NET=n Daniel Lezcano
2020-07-07 15:47 ` Randy Dunlap
2020-07-07 15:49 ` Daniel Lezcano [this message]
2020-07-07 15:50 ` Randy Dunlap
2020-07-21 7:33 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04a6904d-9220-9045-6816-12cf84781f4d@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).