* [PATCH] extcon: max3355: include mod_devicetable.h
@ 2018-07-11 15:50 ` Arnd Bergmann
2018-07-12 1:30 ` Chanwoo Choi
2018-07-12 2:26 ` Randy Dunlap
0 siblings, 2 replies; 5+ messages in thread
From: Arnd Bergmann @ 2018-07-11 15:50 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Randy Dunlap, Arnd Bergmann, MyungJoo Ham, Chanwoo Choi,
Lee Jones, Sebastian Reichel, Kishon Vijay Abraham I,
linux-kernel
Another driver turned up that is missing linux/mod_devicetable.h after
the device IDs are split out from linux/platform_device.h:
drivers/extcon/extcon-max3355.c:127:34: error: array type has incomplete element type 'struct of_device_id'
static const struct of_device_id max3355_match_table[] = {
Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Greg, please add that to the char-misc tree that already has
other related patches.
---
drivers/extcon/extcon-max3355.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c
index 0aa410836f4e..1335a476bfec 100644
--- a/drivers/extcon/extcon-max3355.c
+++ b/drivers/extcon/extcon-max3355.c
@@ -14,6 +14,7 @@
#include <linux/gpio/consumer.h>
#include <linux/interrupt.h>
#include <linux/module.h>
+#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>
struct max3355_data {
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] extcon: max3355: include mod_devicetable.h
2018-07-11 15:50 ` [PATCH] extcon: max3355: include mod_devicetable.h Arnd Bergmann
@ 2018-07-12 1:30 ` Chanwoo Choi
2018-07-12 1:31 ` Chanwoo Choi
2018-07-12 2:26 ` Randy Dunlap
1 sibling, 1 reply; 5+ messages in thread
From: Chanwoo Choi @ 2018-07-12 1:30 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman
Cc: Randy Dunlap, MyungJoo Ham, Lee Jones, Sebastian Reichel,
Kishon Vijay Abraham I, linux-kernel
On 2018년 07월 12일 00:50, Arnd Bergmann wrote:
> Another driver turned up that is missing linux/mod_devicetable.h after
> the device IDs are split out from linux/platform_device.h:
>
> drivers/extcon/extcon-max3355.c:127:34: error: array type has incomplete element type 'struct of_device_id'
> static const struct of_device_id max3355_match_table[] = {
>
> Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Greg, please add that to the char-misc tree that already has
> other related patches.
> ---
> drivers/extcon/extcon-max3355.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c
> index 0aa410836f4e..1335a476bfec 100644
> --- a/drivers/extcon/extcon-max3355.c
> +++ b/drivers/extcon/extcon-max3355.c
> @@ -14,6 +14,7 @@
> #include <linux/gpio/consumer.h>
> #include <linux/interrupt.h>
> #include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/platform_device.h>
>
> struct max3355_data {
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] extcon: max3355: include mod_devicetable.h
2018-07-12 1:30 ` Chanwoo Choi
@ 2018-07-12 1:31 ` Chanwoo Choi
2018-07-12 6:11 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Chanwoo Choi @ 2018-07-12 1:31 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman
Cc: Randy Dunlap, MyungJoo Ham, Lee Jones, Sebastian Reichel,
Kishon Vijay Abraham I, linux-kernel
On 2018년 07월 12일 10:30, Chanwoo Choi wrote:
> On 2018년 07월 12일 00:50, Arnd Bergmann wrote:
>> Another driver turned up that is missing linux/mod_devicetable.h after
>> the device IDs are split out from linux/platform_device.h:
>>
>> drivers/extcon/extcon-max3355.c:127:34: error: array type has incomplete element type 'struct of_device_id'
>> static const struct of_device_id max3355_match_table[] = {
>>
>> Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> Greg, please add that to the char-misc tree that already has
>> other related patches.
>> ---
>> drivers/extcon/extcon-max3355.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c
>> index 0aa410836f4e..1335a476bfec 100644
>> --- a/drivers/extcon/extcon-max3355.c
>> +++ b/drivers/extcon/extcon-max3355.c
>> @@ -14,6 +14,7 @@
>> #include <linux/gpio/consumer.h>
>> #include <linux/interrupt.h>
>> #include <linux/module.h>
>> +#include <linux/mod_devicetable.h>
>> #include <linux/platform_device.h>
>>
>> struct max3355_data {
>>
>
> Applied it. Thanks.
>
If Greg pick up this patch, I'll drop it from extcon git.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] extcon: max3355: include mod_devicetable.h
2018-07-11 15:50 ` [PATCH] extcon: max3355: include mod_devicetable.h Arnd Bergmann
2018-07-12 1:30 ` Chanwoo Choi
@ 2018-07-12 2:26 ` Randy Dunlap
1 sibling, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2018-07-12 2:26 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman
Cc: MyungJoo Ham, Chanwoo Choi, Lee Jones, Sebastian Reichel,
Kishon Vijay Abraham I, linux-kernel
On 07/11/2018 08:50 AM, Arnd Bergmann wrote:
> Another driver turned up that is missing linux/mod_devicetable.h after
> the device IDs are split out from linux/platform_device.h:
>
> drivers/extcon/extcon-max3355.c:127:34: error: array type has incomplete element type 'struct of_device_id'
> static const struct of_device_id max3355_match_table[] = {
>
> Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Sorry for the delay. I've been traveling.
And Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Greg, please add that to the char-misc tree that already has
> other related patches.
> ---
> drivers/extcon/extcon-max3355.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c
> index 0aa410836f4e..1335a476bfec 100644
> --- a/drivers/extcon/extcon-max3355.c
> +++ b/drivers/extcon/extcon-max3355.c
> @@ -14,6 +14,7 @@
> #include <linux/gpio/consumer.h>
> #include <linux/interrupt.h>
> #include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/platform_device.h>
>
> struct max3355_data {
>
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] extcon: max3355: include mod_devicetable.h
2018-07-12 1:31 ` Chanwoo Choi
@ 2018-07-12 6:11 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2018-07-12 6:11 UTC (permalink / raw)
To: Chanwoo Choi
Cc: Arnd Bergmann, Randy Dunlap, MyungJoo Ham, Lee Jones,
Sebastian Reichel, Kishon Vijay Abraham I, linux-kernel
On Thu, Jul 12, 2018 at 10:31:45AM +0900, Chanwoo Choi wrote:
> On 2018년 07월 12일 10:30, Chanwoo Choi wrote:
> > On 2018년 07월 12일 00:50, Arnd Bergmann wrote:
> >> Another driver turned up that is missing linux/mod_devicetable.h after
> >> the device IDs are split out from linux/platform_device.h:
> >>
> >> drivers/extcon/extcon-max3355.c:127:34: error: array type has incomplete element type 'struct of_device_id'
> >> static const struct of_device_id max3355_match_table[] = {
> >>
> >> Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> ---
> >> Greg, please add that to the char-misc tree that already has
> >> other related patches.
> >> ---
> >> drivers/extcon/extcon-max3355.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c
> >> index 0aa410836f4e..1335a476bfec 100644
> >> --- a/drivers/extcon/extcon-max3355.c
> >> +++ b/drivers/extcon/extcon-max3355.c
> >> @@ -14,6 +14,7 @@
> >> #include <linux/gpio/consumer.h>
> >> #include <linux/interrupt.h>
> >> #include <linux/module.h>
> >> +#include <linux/mod_devicetable.h>
> >> #include <linux/platform_device.h>
> >>
> >> struct max3355_data {
> >>
> >
> > Applied it. Thanks.
> >
>
> If Greg pick up this patch, I'll drop it from extcon git.
Greg picked it up already :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-12 6:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20180711155116epcas3p1d50af5ed86f7f55f607657d195492582@epcas3p1.samsung.com>
2018-07-11 15:50 ` [PATCH] extcon: max3355: include mod_devicetable.h Arnd Bergmann
2018-07-12 1:30 ` Chanwoo Choi
2018-07-12 1:31 ` Chanwoo Choi
2018-07-12 6:11 ` Greg Kroah-Hartman
2018-07-12 2:26 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).