net/wireless/shipped-certs.c:2:1: error: expected expression at end of input

net/wireless/shipped-certs.c:2:1: error: expected expression at end of input

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Dear Linux folks,


Building the Linux kernel fails with the error below on Debian 
Sid/unstable with gcc (Debian 7.2.0-8) 7.2.0.

```
$ git describe
v4.15-rc2-79-gfd6d2e506ce6
$ git log --oneline -1
fd6d2e506ce6 Merge tag 'docs-4.15-fixes' of git://git.lwn.net/linux
$ time ARCH=i386 make deb-pkg -j50
[…]
net/wireless/shipped-certs.c:2:1: error: expected expression at end of input
  const u8 shipped_regdb_certs[] = {
  ^~~~~
[…]
$ more net/wireless/shipped-certs.c
#include "reg.h"
const u8 shipped_regdb_certs[] = {
```


Kind regards,

Paul



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]

Re: net/wireless/shipped-certs.c:2:1: error: expected expression at end of input

[Johannes Berg]

On Tue, 2017-12-05 at 11:01 +0100, Paul Menzel wrote:
> 
> 
> ```
> $ git describe
> v4.15-rc2-79-gfd6d2e506ce6
> $ git log --oneline -1
> fd6d2e506ce6 Merge tag 'docs-4.15-fixes' of git://git.lwn.net/linux
> $ time ARCH=i386 make deb-pkg -j50
> […]
> net/wireless/shipped-certs.c:2:1: error: expected expression at end of input
>   const u8 shipped_regdb_certs[] = {
>   ^~~~~
> […]
> $ more net/wireless/shipped-certs.c
> #include "reg.h"
> const u8 shipped_regdb_certs[] = {
> ```

Ah, here we go - you probably don't have "hexdump" installed on this
system?

I thought about doing hexdump in posix shell/awk/sed/whatever
instead... maybe I should do that.

johannes

Re: net/wireless/shipped-certs.c:2:1: error: expected expression at end of input

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

Dear Johannes,


On 12/05/17 11:03, Johannes Berg wrote:
> On Tue, 2017-12-05 at 11:01 +0100, Paul Menzel wrote:
>
>> ```
>> $ git describe
>> v4.15-rc2-79-gfd6d2e506ce6
>> $ git log --oneline -1
>> fd6d2e506ce6 Merge tag 'docs-4.15-fixes' of git://git.lwn.net/linux
>> $ time ARCH=i386 make deb-pkg -j50
>> […]
>> net/wireless/shipped-certs.c:2:1: error: expected expression at end of input
>>    const u8 shipped_regdb_certs[] = {
>>    ^~~~~
>> […]
>> $ more net/wireless/shipped-certs.c
>> #include "reg.h"
>> const u8 shipped_regdb_certs[] = {
>> ```
> 
> Ah, here we go - you probably don't have "hexdump" installed on this
> system?

Well, I didn’t, but got the error, that hexdump couldn’t be found. After 
installing it, I got the error above, and sent the message.

Removing the file `net/wireless/shipped-certs.c`, and building again, 
fixed the problem. So I guess, the clean-up task(?) in the build script 
has a problem.

> I thought about doing hexdump in posix shell/awk/sed/whatever
> instead... maybe I should do that.

I do not think, it’s necessary, as I got an error, that the executable 
is not there. No idea, if it is documented somewhere though.


Kind regards,

Paul


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]

Re: net/wireless/shipped-certs.c:2:1: error: expected expression at end of input

[Johannes Berg]

Hi,

> > Ah, here we go - you probably don't have "hexdump" installed on this
> > system?
> 
> Well, I didn’t, but got the error, that hexdump couldn’t be found. After 
> installing it, I got the error above, and sent the message.

Ah, ok.

> Removing the file `net/wireless/shipped-certs.c`, and building again, 
> fixed the problem. So I guess, the clean-up task(?) in the build script 
> has a problem.

Did you run "make clean"? I'm not even sure it'd delete the file
though.

I suppose if this target fails we shouldn't create the file, but I
haven't quite figured out how to do that - let me try.

> I do not think, it’s necessary, as I got an error, that the executable 
> is not there. No idea, if it is documented somewhere though.

Fair enough. I do have a patch to use od/sed so perhaps I'll just throw
that in anyway just to not require people to install hexdump.

johannes

Re: net/wireless/shipped-certs.c:2:1: error: expected expression at end of input

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

Dear Johannes,


On 12/05/17 11:31, Johannes Berg wrote:

>>> Ah, here we go - you probably don't have "hexdump" installed on this
>>> system?
>>
>> Well, I didn’t, but got the error, that hexdump couldn’t be found. After
>> installing it, I got the error above, and sent the message.
> 
> Ah, ok.
> 
>> Removing the file `net/wireless/shipped-certs.c`, and building again,
>> fixed the problem. So I guess, the clean-up task(?) in the build script
>> has a problem.
> 
> Did you run "make clean"? I'm not even sure it'd delete the file
> though.

Yes, the target `deb-pkg` does that.

> I suppose if this target fails we shouldn't create the file, but I
> haven't quite figured out how to do that - let me try.

Thank you for looking into this.

>> I do not think, it’s necessary, as I got an error, that the executable
>> is not there. No idea, if it is documented somewhere though.
> 
> Fair enough. I do have a patch to use od/sed so perhaps I'll just throw
> that in anyway just to not require people to install hexdump.

Hmm, my gut says to use `hexdump`, which is clearer, and not some other 
`od/sed` which is probably hard to understand.


Kind regards,

Paul


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]

Re: net/wireless/shipped-certs.c:2:1: error: expected expression at end of input

[Damian Tometzki]

Hello Johannes,

I got. the same Build error. 


VG Damian Tometzki





> Am 05.12.2017 um 11:03 schrieb Johannes Berg <johannes@sipsolutions.net>:
> 
>> On Tue, 2017-12-05 at 11:01 +0100, Paul Menzel wrote:
>> 
>> 
>> ```
>> $ git describe
>> v4.15-rc2-79-gfd6d2e506ce6
>> $ git log --oneline -1
>> fd6d2e506ce6 Merge tag 'docs-4.15-fixes' of git://git.lwn.net/linux
>> $ time ARCH=i386 make deb-pkg -j50
>> […]
>> net/wireless/shipped-certs.c:2:1: error: expected expression at end of input
>>  const u8 shipped_regdb_certs[] = {
>>  ^~~~~
>> […]
>> $ more net/wireless/shipped-certs.c
>> #include "reg.h"
>> const u8 shipped_regdb_certs[] = {
>> ```
> 
> Ah, here we go - you probably don't have "hexdump" installed on this
> system?
> 
> I thought about doing hexdump in posix shell/awk/sed/whatever
> instead... maybe I should do that.
> 
> johannes

Re: net/wireless/shipped-certs.c:2:1: error: expected expression at end of input

[Paul Menzel]

Dear Damian,


On 12/13/17 08:53, Damian Tometzki wrote:

> I got. the same Build error.

So first you didn’t have hexdump installed, and then after installing it 
you got it? Removing the generated file fixed the build?


Kind regards,

Paul

Re: net/wireless/shipped-certs.c:2:1: error: expected expression at end of input

[Damian Tometzki]

Hello Paul,

Hexdump was already installed in the System. 

I commented out this step. 

VG Damian Tometzki
Itelligence AG
+41 79 304 2745



> Am 13.12.2017 um 10:16 schrieb Paul Menzel <pmenzel+linux-wireless@molgen.mpg.de>:
> 
> Dear Damian,
> 
> 
>> On 12/13/17 08:53, Damian Tometzki wrote:
>> 
>> I got. the same Build error.
> 
> So first you didn’t have hexdump installed, and then after installing it you got it? Removing the generated file fixed the build?
> 
> 
> Kind regards,
> 
> Paul

Re: net/wireless/shipped-certs.c:2:1: error: expected expression at end of input

[Paul Menzel]

Dear Damian,


On 12/13/17 12:00, Damian Tometzki wrote:

> Hexdump was already installed in the System.
> 
> I commented out this step.
Please try to reproduce it from a clean environment (`git clean -dfx`, 
save your .config before), and then please give more details.


Kind regards,

Paul

Re: net/wireless/shipped-certs.c:2:1: error: expected expression at end of input

[Damian Tometzki]

On Wed, 13. Dec 12:07, Paul Menzel wrote:
> Dear Damian,
> 
> 
> On 12/13/17 12:00, Damian Tometzki wrote:
> 
> >Hexdump was already installed in the System.
> >
> >I commented out this step.
> Please try to reproduce it from a clean environment (`git clean -dfx`, save
> your .config before), and then please give more details.

After cleaning the environment with  'git clean -dfx' the build was successfully. 
Thanks for you help
 
> 
> 
> Kind regards,
> 
> Paul

Re: net/wireless/shipped-certs.c:2:1: error: expected expression at end of input

[Damian Tometzki]

Hello Paul,

with the cleanup the Build was succesfully. 

Thanks für you help. 

VG Damian Tometzki
Itelligence AG
+41 79 304 2745



> Am 13.12.2017 um 12:07 schrieb Paul Menzel <pmenzel+linux-wireless@molgen.mpg.de>:
> 
> Dear Damian,
> 
> 
>> On 12/13/17 12:00, Damian Tometzki wrote:
>> 
>> Hexdump was already installed in the System.
>> I commented out this step.
> Please try to reproduce it from a clean environment (`git clean -dfx`, save your .config before), and then please give more details.
> 
> 
> Kind regards,
> 
> Paul