linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Allen-KH Cheng (程冠勳)" <Allen-KH.Cheng@mediatek.com>
To: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"nfraprado@collabora.com" <nfraprado@collabora.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org" 
	<linux-mediatek@lists.infradead.org>,
	"angelogioacchino.delregno@collabora.com" 
	<angelogioacchino.delregno@collabora.com>,
	Project_Global_Chrome_Upstream_Group 
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 5/8] dt-bindings: watchdog: mediatek: Convert mtk-wdt to json-schema
Date: Fri, 7 Oct 2022 08:31:48 +0000	[thread overview]
Message-ID: <054b23d46c3ef7960859444d51ce13f760ad7791.camel@mediatek.com> (raw)
In-Reply-To: <e9fe9674-8b33-dd6f-2db4-1ea4ed8d17af@linaro.org>

Hi Krzysztof,

On Fri, 2022-10-07 at 09:25 +0200, Krzysztof Kozlowski wrote:
> On 06/10/2022 14:07, Allen-KH Cheng wrote:
> 
> Thank you for your patch. There is something to discuss/improve.
> 
> 
> > +  - Matthias Brugger <matthias.bgg@gmail.com>
> > +
> > +description:
> > +  The watchdog supports a pre-timeout interrupt that fires
> > +  timeout-sec/2 before the expiry.
> > +
> > +allOf:
> > +  - $ref: watchdog.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +          - enum:
> 
> This is just one enum in "items", so no need for the "items".
> 

Got it, I will drop this for v2.

Thanks,
Allen


> > +              - mediatek,mt2712-wdt
> > +              - mediatek,mt6589-wdt
> > +              - mediatek,mt7986-wdt
> > +              - mediatek,mt8183-wdt
> > +              - mediatek,mt8186-wdt
> > +              - mediatek,mt8192-wdt
> > +              - mediatek,mt8195-wdt
> 
> Best regards,
> Krzysztof
> 

  reply	other threads:[~2022-10-07  8:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 12:07 [PATCH 0/8] MediaTek watchdog: Convert mtk-wdt.txt to dt-schema Allen-KH Cheng
2022-10-06 12:07 ` [PATCH 1/8] arm64: dts: mediatek: mt8186: Fix watchdog compatible Allen-KH Cheng
2022-10-06 12:07 ` [PATCH 2/8] arm64: dts: mediatek: mt8195: " Allen-KH Cheng
2022-10-06 12:07 ` [PATCH 3/8] arm64: dts: mediatek: mt7986: " Allen-KH Cheng
2022-10-06 12:24   ` AngeloGioacchino Del Regno
2022-10-06 12:07 ` [PATCH 4/8] arm64: dts: mediatek: mt8516: Fix the watchdog node name Allen-KH Cheng
2022-10-06 12:07 ` [PATCH 5/8] dt-bindings: watchdog: mediatek: Convert mtk-wdt to json-schema Allen-KH Cheng
2022-10-06 20:11   ` Rob Herring
2022-10-07  7:25   ` Krzysztof Kozlowski
2022-10-07  8:31     ` Allen-KH Cheng (程冠勳) [this message]
2022-10-06 12:07 ` [PATCH 6/8] dt-bindings: watchdog: mediatek,mtk-wdt: Add compatible for MT6795 Allen-KH Cheng
2022-10-06 18:13   ` Guenter Roeck
2022-10-06 12:07 ` [PATCH 7/8] watchdog: mtk_wdt: Add support for MT6795 Helio X10 watchdog and toprgu Allen-KH Cheng
2022-10-06 18:12   ` Guenter Roeck
2022-10-06 12:07 ` [PATCH 8/8] dt-bindings: watchdog: mediatek,mtk-wdt: Add compatible for MT8173 Allen-KH Cheng
2022-10-06 12:27   ` AngeloGioacchino Del Regno
2022-10-06 20:12   ` Rob Herring
2022-10-06 12:28 ` [PATCH 0/8] MediaTek watchdog: Convert mtk-wdt.txt to dt-schema AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=054b23d46c3ef7960859444d51ce13f760ad7791.camel@mediatek.com \
    --to=allen-kh.cheng@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=matthias.bgg@gmail.com \
    --cc=nfraprado@collabora.com \
    --cc=robh+dt@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).