From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Allen-KH Cheng <allen-kh.cheng@mediatek.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
nfraprado@collabora.com
Cc: angelogioacchino.delregno@collabora.com,
Project_Global_Chrome_Upstream_Group@mediatek.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 5/8] dt-bindings: watchdog: mediatek: Convert mtk-wdt to json-schema
Date: Fri, 7 Oct 2022 09:25:05 +0200 [thread overview]
Message-ID: <e9fe9674-8b33-dd6f-2db4-1ea4ed8d17af@linaro.org> (raw)
In-Reply-To: <20221006120715.24815-6-allen-kh.cheng@mediatek.com>
On 06/10/2022 14:07, Allen-KH Cheng wrote:
Thank you for your patch. There is something to discuss/improve.
> + - Matthias Brugger <matthias.bgg@gmail.com>
> +
> +description:
> + The watchdog supports a pre-timeout interrupt that fires
> + timeout-sec/2 before the expiry.
> +
> +allOf:
> + - $ref: watchdog.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
This is just one enum in "items", so no need for the "items".
> + - mediatek,mt2712-wdt
> + - mediatek,mt6589-wdt
> + - mediatek,mt7986-wdt
> + - mediatek,mt8183-wdt
> + - mediatek,mt8186-wdt
> + - mediatek,mt8192-wdt
> + - mediatek,mt8195-wdt
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-07 7:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 12:07 [PATCH 0/8] MediaTek watchdog: Convert mtk-wdt.txt to dt-schema Allen-KH Cheng
2022-10-06 12:07 ` [PATCH 1/8] arm64: dts: mediatek: mt8186: Fix watchdog compatible Allen-KH Cheng
2022-10-06 12:07 ` [PATCH 2/8] arm64: dts: mediatek: mt8195: " Allen-KH Cheng
2022-10-06 12:07 ` [PATCH 3/8] arm64: dts: mediatek: mt7986: " Allen-KH Cheng
2022-10-06 12:24 ` AngeloGioacchino Del Regno
2022-10-06 12:07 ` [PATCH 4/8] arm64: dts: mediatek: mt8516: Fix the watchdog node name Allen-KH Cheng
2022-10-06 12:07 ` [PATCH 5/8] dt-bindings: watchdog: mediatek: Convert mtk-wdt to json-schema Allen-KH Cheng
2022-10-06 20:11 ` Rob Herring
2022-10-07 7:25 ` Krzysztof Kozlowski [this message]
2022-10-07 8:31 ` Allen-KH Cheng (程冠勳)
2022-10-06 12:07 ` [PATCH 6/8] dt-bindings: watchdog: mediatek,mtk-wdt: Add compatible for MT6795 Allen-KH Cheng
2022-10-06 18:13 ` Guenter Roeck
2022-10-06 12:07 ` [PATCH 7/8] watchdog: mtk_wdt: Add support for MT6795 Helio X10 watchdog and toprgu Allen-KH Cheng
2022-10-06 18:12 ` Guenter Roeck
2022-10-06 12:07 ` [PATCH 8/8] dt-bindings: watchdog: mediatek,mtk-wdt: Add compatible for MT8173 Allen-KH Cheng
2022-10-06 12:27 ` AngeloGioacchino Del Regno
2022-10-06 20:12 ` Rob Herring
2022-10-06 12:28 ` [PATCH 0/8] MediaTek watchdog: Convert mtk-wdt.txt to dt-schema AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9fe9674-8b33-dd6f-2db4-1ea4ed8d17af@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).