From: Alex Elder <elder@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
mhi@lists.linux.dev
Cc: quic_hemantk@quicinc.com, quic_bbhatt@quicinc.com,
quic_jhugo@quicinc.com, vinod.koul@linaro.org,
bjorn.andersson@linaro.org, dmitry.baryshkov@linaro.org,
quic_vbadigan@quicinc.com, quic_cang@quicinc.com,
quic_skananth@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 20/25] bus: mhi: ep: Add support for processing command ring
Date: Tue, 15 Feb 2022 16:40:01 -0600 [thread overview]
Message-ID: <05956282-57f4-996b-13ae-282fb40e1578@linaro.org> (raw)
In-Reply-To: <20220212182117.49438-21-manivannan.sadhasivam@linaro.org>
On 2/12/22 12:21 PM, Manivannan Sadhasivam wrote:
> Add support for processing the command ring. Command ring is used by the
> host to issue channel specific commands to the ep device. Following
> commands are supported:
>
> 1. Start channel
> 2. Stop channel
> 3. Reset channel
>
> Once the device receives the command doorbell interrupt from host, it
> executes the command and generates a command completion event to the
> host in the primary event ring.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
I'll let you consider my few comments below, but whether or not you
address them, this looks OK to me.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> drivers/bus/mhi/ep/main.c | 151 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 151 insertions(+)
>
> diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
> index 6378ac5c7e37..4c2ee517832c 100644
> --- a/drivers/bus/mhi/ep/main.c
> +++ b/drivers/bus/mhi/ep/main.c
> @@ -21,6 +21,7 @@
>
> static DEFINE_IDA(mhi_ep_cntrl_ida);
>
> +static int mhi_ep_create_device(struct mhi_ep_cntrl *mhi_cntrl, u32 ch_id);
> static int mhi_ep_destroy_device(struct device *dev, void *data);
>
> static int mhi_ep_send_event(struct mhi_ep_cntrl *mhi_cntrl, u32 ring_idx,
> @@ -185,6 +186,156 @@ void mhi_ep_unmap_free(struct mhi_ep_cntrl *mhi_cntrl, u64 pci_addr, phys_addr_t
> mhi_cntrl->free_addr(mhi_cntrl, phys - offset, virt - offset, size);
> }
>
> +int mhi_ep_process_cmd_ring(struct mhi_ep_ring *ring, struct mhi_ep_ring_element *el)
> +{
> + struct mhi_ep_cntrl *mhi_cntrl = ring->mhi_cntrl;
> + struct device *dev = &mhi_cntrl->mhi_dev->dev;
> + struct mhi_result result = {};
> + struct mhi_ep_chan *mhi_chan;
> + struct mhi_ep_ring *ch_ring;
> + u32 tmp, ch_id;
> + int ret;
> +
> + ch_id = MHI_TRE_GET_CMD_CHID(el);
> + mhi_chan = &mhi_cntrl->mhi_chan[ch_id];
> + ch_ring = &mhi_cntrl->mhi_chan[ch_id].ring;
> +
> + switch (MHI_TRE_GET_CMD_TYPE(el)) {
No MHI_PKT_TYPE_NOOP_CMD?
> + case MHI_PKT_TYPE_START_CHAN_CMD:
> + dev_dbg(dev, "Received START command for channel (%d)\n", ch_id);
> +
> + mutex_lock(&mhi_chan->lock);
> + /* Initialize and configure the corresponding channel ring */
> + if (!ch_ring->started) {
> + ret = mhi_ep_ring_start(mhi_cntrl, ch_ring,
> + (union mhi_ep_ring_ctx *)&mhi_cntrl->ch_ctx_cache[ch_id]);
> + if (ret) {
> + dev_err(dev, "Failed to start ring for channel (%d)\n", ch_id);
> + ret = mhi_ep_send_cmd_comp_event(mhi_cntrl,
> + MHI_EV_CC_UNDEFINED_ERR);
> + if (ret)
> + dev_err(dev, "Error sending completion event (%d)\n",
> + MHI_EV_CC_UNDEFINED_ERR);
Print the value of ret in the above message (not UNDEFINED_ERR).
> +
> + goto err_unlock;
> + }
> + }
> +
> + /* Enable DB for the channel */
> + mhi_ep_mmio_enable_chdb_a7(mhi_cntrl, ch_id);
If an error occurs later, this will be enabled. Is that what
you want? Maybe wait to enable the doorbell until everything
else succeeds.
> +
> + /* Set channel state to RUNNING */
> + mhi_chan->state = MHI_CH_STATE_RUNNING;
> + tmp = le32_to_cpu(mhi_cntrl->ch_ctx_cache[ch_id].chcfg);
> + tmp &= ~CHAN_CTX_CHSTATE_MASK;
> + tmp |= FIELD_PREP(CHAN_CTX_CHSTATE_MASK, MHI_CH_STATE_RUNNING);
> + mhi_cntrl->ch_ctx_cache[ch_id].chcfg = cpu_to_le32(tmp);
> +
> + ret = mhi_ep_send_cmd_comp_event(mhi_cntrl, MHI_EV_CC_SUCCESS);
> + if (ret) {
> + dev_err(dev, "Error sending command completion event (%d)\n",
> + MHI_EV_CC_SUCCESS);
> + goto err_unlock;
> + }
> +
> + mutex_unlock(&mhi_chan->lock);
> +
> + /*
> + * Create MHI device only during UL channel start. Since the MHI
> + * channels operate in a pair, we'll associate both UL and DL
> + * channels to the same device.
> + *
> + * We also need to check for mhi_dev != NULL because, the host
> + * will issue START_CHAN command during resume and we don't
> + * destroy the device during suspend.
> + */
> + if (!(ch_id % 2) && !mhi_chan->mhi_dev) {
> + ret = mhi_ep_create_device(mhi_cntrl, ch_id);
> + if (ret) {
If this occurs, the host will already have been told the
request completed successfully. Is that a problem that
can/should be avoided?
> + dev_err(dev, "Error creating device for channel (%d)\n", ch_id);
> + return ret;
> + }
> + }
> +
> + break;
> + case MHI_PKT_TYPE_STOP_CHAN_CMD:
> + dev_dbg(dev, "Received STOP command for channel (%d)\n", ch_id);
> + if (!ch_ring->started) {
> + dev_err(dev, "Channel (%d) not opened\n", ch_id);
> + return -ENODEV;
> + }
> +
> + mutex_lock(&mhi_chan->lock);
> + /* Disable DB for the channel */
> + mhi_ep_mmio_disable_chdb_a7(mhi_cntrl, ch_id);
> +
> + /* Send channel disconnect status to client drivers */
> + result.transaction_status = -ENOTCONN;
> + result.bytes_xferd = 0;
> + mhi_chan->xfer_cb(mhi_chan->mhi_dev, &result);
> +
> + /* Set channel state to STOP */
> + mhi_chan->state = MHI_CH_STATE_STOP;
> + tmp = le32_to_cpu(mhi_cntrl->ch_ctx_cache[ch_id].chcfg);
> + tmp &= ~CHAN_CTX_CHSTATE_MASK;
> + tmp |= FIELD_PREP(CHAN_CTX_CHSTATE_MASK, MHI_CH_STATE_STOP);
> + mhi_cntrl->ch_ctx_cache[ch_id].chcfg = cpu_to_le32(tmp);
> +
> + ret = mhi_ep_send_cmd_comp_event(mhi_cntrl, MHI_EV_CC_SUCCESS);
> + if (ret) {
> + dev_err(dev, "Error sending command completion event (%d)\n",
> + MHI_EV_CC_SUCCESS);
> + goto err_unlock;
> + }
> +
> + mutex_unlock(&mhi_chan->lock);
> + break;
> + case MHI_PKT_TYPE_RESET_CHAN_CMD:
> + dev_dbg(dev, "Received STOP command for channel (%d)\n", ch_id);
> + if (!ch_ring->started) {
> + dev_err(dev, "Channel (%d) not opened\n", ch_id);
> + return -ENODEV;
> + }
> +
> + mutex_lock(&mhi_chan->lock);
> + /* Stop and reset the transfer ring */
> + mhi_ep_ring_reset(mhi_cntrl, ch_ring);
> +
> + /* Send channel disconnect status to client driver */
> + result.transaction_status = -ENOTCONN;
> + result.bytes_xferd = 0;
> + mhi_chan->xfer_cb(mhi_chan->mhi_dev, &result);
> +
> + /* Set channel state to DISABLED */
> + mhi_chan->state = MHI_CH_STATE_DISABLED;
> + tmp = le32_to_cpu(mhi_cntrl->ch_ctx_cache[ch_id].chcfg);
> + tmp &= ~CHAN_CTX_CHSTATE_MASK;
> + tmp |= FIELD_PREP(CHAN_CTX_CHSTATE_MASK, MHI_CH_STATE_DISABLED);
> + mhi_cntrl->ch_ctx_cache[ch_id].chcfg = cpu_to_le32(tmp);
> +
> + ret = mhi_ep_send_cmd_comp_event(mhi_cntrl, MHI_EV_CC_SUCCESS);
> + if (ret) {
> + dev_err(dev, "Error sending command completion event (%d)\n",
> + MHI_EV_CC_SUCCESS);
> + goto err_unlock;
> + }
> +
> + mutex_unlock(&mhi_chan->lock);
> + break;
> + default:
> + dev_err(dev, "Invalid command received: %d for channel (%d)\n",
> + MHI_TRE_GET_CMD_TYPE(el), ch_id);
> + return -EINVAL;
> + }
> +
> + return 0;
> +
> +err_unlock:
> + mutex_unlock(&mhi_chan->lock);
> +
> + return ret;
> +}
> +
> static int mhi_ep_cache_host_cfg(struct mhi_ep_cntrl *mhi_cntrl)
> {
> struct device *dev = &mhi_cntrl->mhi_dev->dev;
next prev parent reply other threads:[~2022-02-15 22:40 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-12 18:20 [PATCH v3 00/25] Add initial support for MHI endpoint stack Manivannan Sadhasivam
2022-02-12 18:20 ` [PATCH v3 01/25] bus: mhi: Fix pm_state conversion to string Manivannan Sadhasivam
2022-02-15 20:01 ` Alex Elder
2022-02-16 11:33 ` Manivannan Sadhasivam
2022-02-16 13:41 ` Alex Elder
2022-02-12 18:20 ` [PATCH v3 02/25] bus: mhi: Fix MHI DMA structure endianness Manivannan Sadhasivam
2022-02-15 20:02 ` Alex Elder
2022-02-16 7:04 ` Manivannan Sadhasivam
2022-02-16 14:29 ` Alex Elder
2022-02-12 18:20 ` [PATCH v3 03/25] bus: mhi: Move host MHI code to "host" directory Manivannan Sadhasivam
2022-02-15 20:02 ` Alex Elder
2022-02-12 18:20 ` [PATCH v3 04/25] bus: mhi: Move common MHI definitions out of host directory Manivannan Sadhasivam
2022-02-15 0:28 ` Hemant Kumar
2022-02-15 20:02 ` Alex Elder
2022-02-12 18:20 ` [PATCH v3 05/25] bus: mhi: Make mhi_state_str[] array static inline and move to common.h Manivannan Sadhasivam
2022-02-15 0:31 ` Hemant Kumar
2022-02-15 20:02 ` Alex Elder
2022-02-16 11:39 ` Manivannan Sadhasivam
2022-02-16 14:30 ` Alex Elder
2022-02-12 18:20 ` [PATCH v3 06/25] bus: mhi: Cleanup the register definitions used in headers Manivannan Sadhasivam
2022-02-15 0:37 ` Hemant Kumar
2022-02-15 20:02 ` Alex Elder
2022-02-16 17:21 ` Manivannan Sadhasivam
2022-02-16 17:43 ` Manivannan Sadhasivam
2022-02-12 18:20 ` [PATCH v3 07/25] bus: mhi: Get rid of SHIFT macros and use bitfield operations Manivannan Sadhasivam
2022-02-15 20:02 ` Alex Elder
2022-02-16 16:45 ` Manivannan Sadhasivam
2022-02-12 18:21 ` [PATCH v3 08/25] bus: mhi: ep: Add support for registering MHI endpoint controllers Manivannan Sadhasivam
2022-02-15 1:04 ` Hemant Kumar
2022-02-16 17:33 ` Manivannan Sadhasivam
2022-02-15 20:02 ` Alex Elder
2022-02-17 9:53 ` Manivannan Sadhasivam
2022-02-17 14:47 ` Alex Elder
2022-03-04 21:46 ` Jeffrey Hugo
2022-02-12 18:21 ` [PATCH v3 09/25] bus: mhi: ep: Add support for registering MHI endpoint client drivers Manivannan Sadhasivam
2022-02-12 18:32 ` Manivannan Sadhasivam
2022-02-15 1:10 ` Hemant Kumar
2022-02-15 20:02 ` Alex Elder
2022-02-17 10:20 ` Manivannan Sadhasivam
2022-02-17 14:50 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 10/25] bus: mhi: ep: Add support for creating and destroying MHI EP devices Manivannan Sadhasivam
2022-02-15 20:02 ` Alex Elder
2022-02-17 12:04 ` Manivannan Sadhasivam
2022-02-12 18:21 ` [PATCH v3 11/25] bus: mhi: ep: Add support for managing MMIO registers Manivannan Sadhasivam
2022-02-15 1:14 ` Hemant Kumar
2022-02-15 20:03 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 12/25] bus: mhi: ep: Add support for ring management Manivannan Sadhasivam
2022-02-15 20:03 ` Alex Elder
2022-02-18 8:07 ` Manivannan Sadhasivam
2022-02-18 15:23 ` Manivannan Sadhasivam
2022-02-18 15:47 ` Alex Elder
2022-02-18 15:39 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 13/25] bus: mhi: ep: Add support for sending events to the host Manivannan Sadhasivam
2022-02-15 22:39 ` Alex Elder
2022-02-22 6:06 ` Manivannan Sadhasivam
2022-02-22 13:41 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 14/25] bus: mhi: ep: Add support for managing MHI state machine Manivannan Sadhasivam
2022-02-15 22:39 ` Alex Elder
2022-02-22 7:03 ` Manivannan Sadhasivam
2022-02-12 18:21 ` [PATCH v3 15/25] bus: mhi: ep: Add support for processing MHI endpoint interrupts Manivannan Sadhasivam
2022-02-15 22:39 ` Alex Elder
2022-02-22 8:18 ` Manivannan Sadhasivam
2022-02-22 14:08 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 16/25] bus: mhi: ep: Add support for powering up the MHI endpoint stack Manivannan Sadhasivam
2022-02-15 22:39 ` Alex Elder
2022-02-22 9:08 ` Manivannan Sadhasivam
2022-02-22 14:10 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 17/25] bus: mhi: ep: Add support for powering down " Manivannan Sadhasivam
2022-02-15 22:39 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 18/25] bus: mhi: ep: Add support for handling MHI_RESET Manivannan Sadhasivam
2022-02-15 22:39 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 19/25] bus: mhi: ep: Add support for handling SYS_ERR condition Manivannan Sadhasivam
2022-02-15 22:39 ` Alex Elder
2022-02-22 10:29 ` Manivannan Sadhasivam
2022-02-12 18:21 ` [PATCH v3 20/25] bus: mhi: ep: Add support for processing command ring Manivannan Sadhasivam
2022-02-15 22:40 ` Alex Elder [this message]
2022-02-22 10:35 ` Manivannan Sadhasivam
2022-02-12 18:21 ` [PATCH v3 21/25] bus: mhi: ep: Add support for reading from the host Manivannan Sadhasivam
2022-02-15 22:40 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 22/25] bus: mhi: ep: Add support for processing transfer ring Manivannan Sadhasivam
2022-02-15 22:40 ` Alex Elder
2022-02-22 10:50 ` Manivannan Sadhasivam
2022-02-12 18:21 ` [PATCH v3 23/25] bus: mhi: ep: Add support for queueing SKBs to the host Manivannan Sadhasivam
2022-02-15 22:40 ` Alex Elder
2022-02-22 14:38 ` Manivannan Sadhasivam
2022-02-22 15:18 ` Alex Elder
2022-02-22 16:05 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 24/25] bus: mhi: ep: Add support for suspending and resuming channels Manivannan Sadhasivam
2022-02-15 22:40 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 25/25] bus: mhi: ep: Add uevent support for module autoloading Manivannan Sadhasivam
2022-02-15 22:40 ` Alex Elder
2022-02-15 20:01 ` [PATCH v3 00/25] Add initial support for MHI endpoint stack Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05956282-57f4-996b-13ae-282fb40e1578@linaro.org \
--to=elder@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=quic_bbhatt@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_hemantk@quicinc.com \
--cc=quic_jhugo@quicinc.com \
--cc=quic_skananth@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).