From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Alex Elder <elder@linaro.org>
Cc: mhi@lists.linux.dev, quic_hemantk@quicinc.com,
quic_bbhatt@quicinc.com, quic_jhugo@quicinc.com,
vinod.koul@linaro.org, bjorn.andersson@linaro.org,
dmitry.baryshkov@linaro.org, quic_vbadigan@quicinc.com,
quic_cang@quicinc.com, quic_skananth@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 22/25] bus: mhi: ep: Add support for processing transfer ring
Date: Tue, 22 Feb 2022 16:20:23 +0530 [thread overview]
Message-ID: <20220222105023.GG5029@thinkpad> (raw)
In-Reply-To: <f91de912-977b-4e78-2e8c-12f4c09134bd@linaro.org>
On Tue, Feb 15, 2022 at 04:40:18PM -0600, Alex Elder wrote:
> On 2/12/22 12:21 PM, Manivannan Sadhasivam wrote:
> > Add support for processing the transfer ring from host. For the transfer
> > ring associated with DL channel, the xfer callback will simply invoked.
> > For the case of UL channel, the ring elements will be read in a buffer
> > till the write pointer and later passed to the client driver using the
> > xfer callback.
> >
> > The client drivers should provide the callbacks for both UL and DL
> > channels during registration.
>
> I think you already checked and guaranteed that.
>
> I have a question and suggestion below. But it could
> be considered an optimization that could be implemented
> in the future, so:
>
> Reviewed-by: Alex Elder <elder@linaro.org>
>
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > drivers/bus/mhi/ep/main.c | 49 +++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 49 insertions(+)
> >
> > diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
> > index b937c6cda9ba..baf383a4857b 100644
> > --- a/drivers/bus/mhi/ep/main.c
> > +++ b/drivers/bus/mhi/ep/main.c
> > @@ -439,6 +439,55 @@ static int mhi_ep_read_channel(struct mhi_ep_cntrl *mhi_cntrl,
> > return 0;
> > }
> > +int mhi_ep_process_tre_ring(struct mhi_ep_ring *ring, struct mhi_ep_ring_element *el)
> > +{
> > + struct mhi_ep_cntrl *mhi_cntrl = ring->mhi_cntrl;
> > + struct mhi_result result = {};
> > + u32 len = MHI_EP_DEFAULT_MTU;
> > + struct mhi_ep_chan *mhi_chan;
> > + int ret;
> > +
> > + mhi_chan = &mhi_cntrl->mhi_chan[ring->ch_id];
> > +
> > + /*
> > + * Bail out if transfer callback is not registered for the channel.
> > + * This is most likely due to the client driver not loaded at this point.
> > + */
> > + if (!mhi_chan->xfer_cb) {
> > + dev_err(&mhi_chan->mhi_dev->dev, "Client driver not available\n");
> > + return -ENODEV;
> > + }
> > +
> > + if (ring->ch_id % 2) {
> > + /* DL channel */
> > + result.dir = mhi_chan->dir;
> > + mhi_chan->xfer_cb(mhi_chan->mhi_dev, &result);
> > + } else {
> > + /* UL channel */
> > + do {
> > + result.buf_addr = kzalloc(len, GFP_KERNEL);
>
> So you allocate an 8KB buffer into which you copy
> received data, then pass that to the ->xfer_cb()
> function. Then you free that buffer. Repeatedly.
>
> Two questions about this:
> - This suggests that after copying the data in, the
> ->xfer_cb() function will copy it again, is that
> correct?
> - If that is correct, why not just reuse the same 8KB
> buffer, allocated once outside the loop?
>
The allocation was moved into the loop so that the TRE length buffer could be
allocated but I somehow decided to allocate the Max length buffer. So this could
be moved outside of the loop.
Thanks,
Mani
> It might also be nice to consider whether you could
> allocate the buffer here and have the ->xfer_cb()
> function be responsible for freeing it (and ideally,
> pass it along rather than copying it again).
>
> > + if (!result.buf_addr)
> > + return -ENOMEM;
> > +
> > + ret = mhi_ep_read_channel(mhi_cntrl, ring, &result, len);
> > + if (ret < 0) {
> > + dev_err(&mhi_chan->mhi_dev->dev, "Failed to read channel\n");
> > + kfree(result.buf_addr);
> > + return ret;
> > + }
> > +
> > + result.dir = mhi_chan->dir;
> > + mhi_chan->xfer_cb(mhi_chan->mhi_dev, &result);
> > + kfree(result.buf_addr);
> > + result.bytes_xferd = 0;
> > +
> > + /* Read until the ring becomes empty */
> > + } while (!mhi_ep_queue_is_empty(mhi_chan->mhi_dev, DMA_TO_DEVICE));
> > + }
> > +
> > + return 0;
> > +}
> > +
> > static int mhi_ep_cache_host_cfg(struct mhi_ep_cntrl *mhi_cntrl)
> > {
> > struct device *dev = &mhi_cntrl->mhi_dev->dev;
>
next prev parent reply other threads:[~2022-02-22 10:50 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-12 18:20 [PATCH v3 00/25] Add initial support for MHI endpoint stack Manivannan Sadhasivam
2022-02-12 18:20 ` [PATCH v3 01/25] bus: mhi: Fix pm_state conversion to string Manivannan Sadhasivam
2022-02-15 20:01 ` Alex Elder
2022-02-16 11:33 ` Manivannan Sadhasivam
2022-02-16 13:41 ` Alex Elder
2022-02-12 18:20 ` [PATCH v3 02/25] bus: mhi: Fix MHI DMA structure endianness Manivannan Sadhasivam
2022-02-15 20:02 ` Alex Elder
2022-02-16 7:04 ` Manivannan Sadhasivam
2022-02-16 14:29 ` Alex Elder
2022-02-12 18:20 ` [PATCH v3 03/25] bus: mhi: Move host MHI code to "host" directory Manivannan Sadhasivam
2022-02-15 20:02 ` Alex Elder
2022-02-12 18:20 ` [PATCH v3 04/25] bus: mhi: Move common MHI definitions out of host directory Manivannan Sadhasivam
2022-02-15 0:28 ` Hemant Kumar
2022-02-15 20:02 ` Alex Elder
2022-02-12 18:20 ` [PATCH v3 05/25] bus: mhi: Make mhi_state_str[] array static inline and move to common.h Manivannan Sadhasivam
2022-02-15 0:31 ` Hemant Kumar
2022-02-15 20:02 ` Alex Elder
2022-02-16 11:39 ` Manivannan Sadhasivam
2022-02-16 14:30 ` Alex Elder
2022-02-12 18:20 ` [PATCH v3 06/25] bus: mhi: Cleanup the register definitions used in headers Manivannan Sadhasivam
2022-02-15 0:37 ` Hemant Kumar
2022-02-15 20:02 ` Alex Elder
2022-02-16 17:21 ` Manivannan Sadhasivam
2022-02-16 17:43 ` Manivannan Sadhasivam
2022-02-12 18:20 ` [PATCH v3 07/25] bus: mhi: Get rid of SHIFT macros and use bitfield operations Manivannan Sadhasivam
2022-02-15 20:02 ` Alex Elder
2022-02-16 16:45 ` Manivannan Sadhasivam
2022-02-12 18:21 ` [PATCH v3 08/25] bus: mhi: ep: Add support for registering MHI endpoint controllers Manivannan Sadhasivam
2022-02-15 1:04 ` Hemant Kumar
2022-02-16 17:33 ` Manivannan Sadhasivam
2022-02-15 20:02 ` Alex Elder
2022-02-17 9:53 ` Manivannan Sadhasivam
2022-02-17 14:47 ` Alex Elder
2022-03-04 21:46 ` Jeffrey Hugo
2022-02-12 18:21 ` [PATCH v3 09/25] bus: mhi: ep: Add support for registering MHI endpoint client drivers Manivannan Sadhasivam
2022-02-12 18:32 ` Manivannan Sadhasivam
2022-02-15 1:10 ` Hemant Kumar
2022-02-15 20:02 ` Alex Elder
2022-02-17 10:20 ` Manivannan Sadhasivam
2022-02-17 14:50 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 10/25] bus: mhi: ep: Add support for creating and destroying MHI EP devices Manivannan Sadhasivam
2022-02-15 20:02 ` Alex Elder
2022-02-17 12:04 ` Manivannan Sadhasivam
2022-02-12 18:21 ` [PATCH v3 11/25] bus: mhi: ep: Add support for managing MMIO registers Manivannan Sadhasivam
2022-02-15 1:14 ` Hemant Kumar
2022-02-15 20:03 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 12/25] bus: mhi: ep: Add support for ring management Manivannan Sadhasivam
2022-02-15 20:03 ` Alex Elder
2022-02-18 8:07 ` Manivannan Sadhasivam
2022-02-18 15:23 ` Manivannan Sadhasivam
2022-02-18 15:47 ` Alex Elder
2022-02-18 15:39 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 13/25] bus: mhi: ep: Add support for sending events to the host Manivannan Sadhasivam
2022-02-15 22:39 ` Alex Elder
2022-02-22 6:06 ` Manivannan Sadhasivam
2022-02-22 13:41 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 14/25] bus: mhi: ep: Add support for managing MHI state machine Manivannan Sadhasivam
2022-02-15 22:39 ` Alex Elder
2022-02-22 7:03 ` Manivannan Sadhasivam
2022-02-12 18:21 ` [PATCH v3 15/25] bus: mhi: ep: Add support for processing MHI endpoint interrupts Manivannan Sadhasivam
2022-02-15 22:39 ` Alex Elder
2022-02-22 8:18 ` Manivannan Sadhasivam
2022-02-22 14:08 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 16/25] bus: mhi: ep: Add support for powering up the MHI endpoint stack Manivannan Sadhasivam
2022-02-15 22:39 ` Alex Elder
2022-02-22 9:08 ` Manivannan Sadhasivam
2022-02-22 14:10 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 17/25] bus: mhi: ep: Add support for powering down " Manivannan Sadhasivam
2022-02-15 22:39 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 18/25] bus: mhi: ep: Add support for handling MHI_RESET Manivannan Sadhasivam
2022-02-15 22:39 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 19/25] bus: mhi: ep: Add support for handling SYS_ERR condition Manivannan Sadhasivam
2022-02-15 22:39 ` Alex Elder
2022-02-22 10:29 ` Manivannan Sadhasivam
2022-02-12 18:21 ` [PATCH v3 20/25] bus: mhi: ep: Add support for processing command ring Manivannan Sadhasivam
2022-02-15 22:40 ` Alex Elder
2022-02-22 10:35 ` Manivannan Sadhasivam
2022-02-12 18:21 ` [PATCH v3 21/25] bus: mhi: ep: Add support for reading from the host Manivannan Sadhasivam
2022-02-15 22:40 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 22/25] bus: mhi: ep: Add support for processing transfer ring Manivannan Sadhasivam
2022-02-15 22:40 ` Alex Elder
2022-02-22 10:50 ` Manivannan Sadhasivam [this message]
2022-02-12 18:21 ` [PATCH v3 23/25] bus: mhi: ep: Add support for queueing SKBs to the host Manivannan Sadhasivam
2022-02-15 22:40 ` Alex Elder
2022-02-22 14:38 ` Manivannan Sadhasivam
2022-02-22 15:18 ` Alex Elder
2022-02-22 16:05 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 24/25] bus: mhi: ep: Add support for suspending and resuming channels Manivannan Sadhasivam
2022-02-15 22:40 ` Alex Elder
2022-02-12 18:21 ` [PATCH v3 25/25] bus: mhi: ep: Add uevent support for module autoloading Manivannan Sadhasivam
2022-02-15 22:40 ` Alex Elder
2022-02-15 20:01 ` [PATCH v3 00/25] Add initial support for MHI endpoint stack Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222105023.GG5029@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=elder@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhi@lists.linux.dev \
--cc=quic_bbhatt@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_hemantk@quicinc.com \
--cc=quic_jhugo@quicinc.com \
--cc=quic_skananth@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).