* [PATCH] sched/fair: Fix decision matrix of type misfit_task
@ 2022-04-24 7:56 zgpeng
2022-04-25 9:01 ` Dietmar Eggemann
0 siblings, 1 reply; 2+ messages in thread
From: zgpeng @ 2022-04-24 7:56 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman, bristot, linux-kernel
When the group type of the busiest is misfit_task, as
long as the type of the local group is not equal to
has_spare, those situation already filtered while
updating statistics.
Signed-off-by: zgpeng <zgpeng@tencent.com>
Reviewed-by: Samuel Liao <samuelliao@tencent.com>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index d4bd299..b8c67e7 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -9495,7 +9495,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
* busiest \ local has_spare fully_busy misfit asym imbalanced overloaded
* has_spare nr_idle balanced N/A N/A balanced balanced
* fully_busy nr_idle nr_idle N/A N/A balanced balanced
- * misfit_task force N/A N/A N/A force force
+ * misfit_task force N/A N/A N/A N/A N/A
* asym_packing force force N/A N/A force force
* imbalanced force force N/A N/A force force
* overloaded force force N/A N/A force avg_load
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sched/fair: Fix decision matrix of type misfit_task
2022-04-24 7:56 [PATCH] sched/fair: Fix decision matrix of type misfit_task zgpeng
@ 2022-04-25 9:01 ` Dietmar Eggemann
0 siblings, 0 replies; 2+ messages in thread
From: Dietmar Eggemann @ 2022-04-25 9:01 UTC (permalink / raw)
To: zgpeng, mingo, peterz, juri.lelli, vincent.guittot, rostedt,
bsegall, mgorman, bristot, linux-kernel
On 24/04/2022 09:56, zgpeng wrote:
> When the group type of the busiest is misfit_task, as
> long as the type of the local group is not equal to
> has_spare, those situation already filtered while
> updating statistics.
>
> Signed-off-by: zgpeng <zgpeng@tencent.com>
> Reviewed-by: Samuel Liao <samuelliao@tencent.com>
> ---
> kernel/sched/fair.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index d4bd299..b8c67e7 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -9495,7 +9495,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
> * busiest \ local has_spare fully_busy misfit asym imbalanced overloaded
> * has_spare nr_idle balanced N/A N/A balanced balanced
> * fully_busy nr_idle nr_idle N/A N/A balanced balanced
> - * misfit_task force N/A N/A N/A force force
> + * misfit_task force N/A N/A N/A N/A N/A
> * asym_packing force force N/A N/A force force
> * imbalanced force force N/A N/A force force
> * overloaded force force N/A N/A force avg_load
This issue has been sorted. Patch from Tao Zhou <tao.zhou@linux.dev> is
already on tip sched/core.
https://lkml.kernel.org/r/165062326028.4207.17060214721845047142.tip-bot2@tip-bot2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-25 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-24 7:56 [PATCH] sched/fair: Fix decision matrix of type misfit_task zgpeng
2022-04-25 9:01 ` Dietmar Eggemann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).