* [PATCH 1/1] riscv: sort select statements alphanumerically
@ 2020-05-19 3:42 Zong Li
2020-05-26 19:31 ` Palmer Dabbelt
0 siblings, 1 reply; 2+ messages in thread
From: Zong Li @ 2020-05-19 3:42 UTC (permalink / raw)
To: paul.walmsley, palmer, linux-riscv, linux-kernel; +Cc: Zong Li
Like patch b1b3f49 ("ARM: config: sort select statements alphanumerically")
, we sort all our select statements alphanumerically by using the perl
script in patch b1b3f49 as above.
As suggested by Andrew Morton:
This is a pet peeve of mine. Any time there's a long list of items
(header file inclusions, kconfig entries, array initalisers, etc) and
someone wants to add a new item, they *always* go and stick it at the
end of the list.
Guys, don't do this. Either put the new item into a randomly-chosen
position or, probably better, alphanumerically sort the list.
Signed-off-by: Zong Li <zong.li@sifive.com>
---
arch/riscv/Kconfig | 70 +++++++++++++++++++++++-----------------------
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index 74ce5c5249e9..8244b8f7e7c3 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -12,64 +12,64 @@ config 32BIT
config RISCV
def_bool y
- select OF
- select OF_EARLY_FLATTREE
- select OF_IRQ
select ARCH_HAS_BINFMT_FLAT
+ select ARCH_HAS_DEBUG_VIRTUAL if MMU
+ select ARCH_HAS_DEBUG_WX
+ select ARCH_HAS_GCOV_PROFILE_ALL
+ select ARCH_HAS_GIGANTIC_PAGE
+ select ARCH_HAS_MMIOWB
+ select ARCH_HAS_PTE_SPECIAL
+ select ARCH_HAS_SET_DIRECT_MAP
+ select ARCH_HAS_SET_MEMORY
+ select ARCH_HAS_STRICT_KERNEL_RWX if MMU
+ select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT if MMU
select ARCH_WANT_FRAME_POINTERS
+ select ARCH_WANT_HUGE_PMD_SHARE if 64BIT
select CLONE_BACKWARDS
select COMMON_CLK
+ select EDAC_SUPPORT
+ select GENERIC_ARCH_TOPOLOGY if SMP
+ select GENERIC_ATOMIC64 if !64BIT
select GENERIC_CLOCKEVENTS
+ select GENERIC_IOREMAP
+ select GENERIC_IRQ_MULTI_HANDLER
select GENERIC_IRQ_SHOW
select GENERIC_PCI_IOMAP
+ select GENERIC_PTDUMP if MMU
select GENERIC_SCHED_CLOCK
+ select GENERIC_SMP_IDLE_THREAD
select GENERIC_STRNCPY_FROM_USER if MMU
select GENERIC_STRNLEN_USER if MMU
- select GENERIC_SMP_IDLE_THREAD
- select GENERIC_ATOMIC64 if !64BIT
- select GENERIC_IOREMAP
- select GENERIC_PTDUMP if MMU
select HAVE_ARCH_AUDITSYSCALL
+ select HAVE_ARCH_KASAN if MMU && 64BIT
+ select HAVE_ARCH_KGDB
+ select HAVE_ARCH_KGDB_QXFER_PKT
+ select HAVE_ARCH_MMAP_RND_BITS if MMU
select HAVE_ARCH_SECCOMP_FILTER
+ select HAVE_ARCH_TRACEHOOK
select HAVE_ASM_MODVERSIONS
+ select HAVE_COPY_THREAD_TLS
select HAVE_DMA_CONTIGUOUS if MMU
+ select HAVE_EBPF_JIT if MMU
select HAVE_FUTEX_CMPXCHG if FUTEX
+ select HAVE_PCI
select HAVE_PERF_EVENTS
select HAVE_PERF_REGS
select HAVE_PERF_USER_STACK_DUMP
select HAVE_SYSCALL_TRACEPOINTS
select IRQ_DOMAIN
- select SPARSE_IRQ
- select SYSCTL_EXCEPTION_TRACE
- select HAVE_ARCH_TRACEHOOK
- select HAVE_PCI
select MODULES_USE_ELF_RELA if MODULES
select MODULE_SECTIONS if MODULES
- select THREAD_INFO_IN_TASK
+ select OF
+ select OF_EARLY_FLATTREE
+ select OF_IRQ
select PCI_DOMAINS_GENERIC if PCI
select PCI_MSI if PCI
select RISCV_TIMER
- select GENERIC_IRQ_MULTI_HANDLER
- select GENERIC_ARCH_TOPOLOGY if SMP
- select ARCH_HAS_PTE_SPECIAL
- select ARCH_HAS_MMIOWB
- select ARCH_HAS_DEBUG_VIRTUAL if MMU
- select HAVE_EBPF_JIT if MMU
- select EDAC_SUPPORT
- select ARCH_HAS_GIGANTIC_PAGE
- select ARCH_HAS_SET_DIRECT_MAP
- select ARCH_HAS_SET_MEMORY
- select ARCH_HAS_STRICT_KERNEL_RWX if MMU
- select ARCH_WANT_HUGE_PMD_SHARE if 64BIT
select SPARSEMEM_STATIC if 32BIT
- select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT if MMU
- select HAVE_ARCH_MMAP_RND_BITS if MMU
- select ARCH_HAS_GCOV_PROFILE_ALL
- select HAVE_COPY_THREAD_TLS
- select HAVE_ARCH_KASAN if MMU && 64BIT
- select HAVE_ARCH_KGDB
- select HAVE_ARCH_KGDB_QXFER_PKT
- select ARCH_HAS_DEBUG_WX
+ select SPARSE_IRQ
+ select SYSCTL_EXCEPTION_TRACE
+ select THREAD_INFO_IN_TASK
config ARCH_MMAP_RND_BITS_MIN
default 18 if 64BIT
@@ -196,11 +196,11 @@ config ARCH_RV64I
bool "RV64I"
select 64BIT
select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 && GCC_VERSION >= 50000
- select HAVE_FUNCTION_TRACER
- select HAVE_FUNCTION_GRAPH_TRACER
- select HAVE_FTRACE_MCOUNT_RECORD
select HAVE_DYNAMIC_FTRACE if MMU
select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE
+ select HAVE_FTRACE_MCOUNT_RECORD
+ select HAVE_FUNCTION_GRAPH_TRACER
+ select HAVE_FUNCTION_TRACER
select SWIOTLB if MMU
endchoice
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] riscv: sort select statements alphanumerically
2020-05-19 3:42 [PATCH 1/1] riscv: sort select statements alphanumerically Zong Li
@ 2020-05-26 19:31 ` Palmer Dabbelt
0 siblings, 0 replies; 2+ messages in thread
From: Palmer Dabbelt @ 2020-05-26 19:31 UTC (permalink / raw)
To: zong.li; +Cc: Paul Walmsley, linux-riscv, linux-kernel, zong.li
On Mon, 18 May 2020 20:42:04 PDT (-0700), zong.li@sifive.com wrote:
> Like patch b1b3f49 ("ARM: config: sort select statements alphanumerically")
> , we sort all our select statements alphanumerically by using the perl
> script in patch b1b3f49 as above.
>
> As suggested by Andrew Morton:
>
> This is a pet peeve of mine. Any time there's a long list of items
> (header file inclusions, kconfig entries, array initalisers, etc) and
> someone wants to add a new item, they *always* go and stick it at the
> end of the list.
>
> Guys, don't do this. Either put the new item into a randomly-chosen
> position or, probably better, alphanumerically sort the list.
>
> Signed-off-by: Zong Li <zong.li@sifive.com>
> ---
> arch/riscv/Kconfig | 70 +++++++++++++++++++++++-----------------------
> 1 file changed, 35 insertions(+), 35 deletions(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 74ce5c5249e9..8244b8f7e7c3 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -12,64 +12,64 @@ config 32BIT
>
> config RISCV
> def_bool y
> - select OF
> - select OF_EARLY_FLATTREE
> - select OF_IRQ
> select ARCH_HAS_BINFMT_FLAT
> + select ARCH_HAS_DEBUG_VIRTUAL if MMU
> + select ARCH_HAS_DEBUG_WX
> + select ARCH_HAS_GCOV_PROFILE_ALL
> + select ARCH_HAS_GIGANTIC_PAGE
> + select ARCH_HAS_MMIOWB
> + select ARCH_HAS_PTE_SPECIAL
> + select ARCH_HAS_SET_DIRECT_MAP
> + select ARCH_HAS_SET_MEMORY
> + select ARCH_HAS_STRICT_KERNEL_RWX if MMU
> + select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT if MMU
> select ARCH_WANT_FRAME_POINTERS
> + select ARCH_WANT_HUGE_PMD_SHARE if 64BIT
> select CLONE_BACKWARDS
> select COMMON_CLK
> + select EDAC_SUPPORT
> + select GENERIC_ARCH_TOPOLOGY if SMP
> + select GENERIC_ATOMIC64 if !64BIT
> select GENERIC_CLOCKEVENTS
> + select GENERIC_IOREMAP
> + select GENERIC_IRQ_MULTI_HANDLER
> select GENERIC_IRQ_SHOW
> select GENERIC_PCI_IOMAP
> + select GENERIC_PTDUMP if MMU
> select GENERIC_SCHED_CLOCK
> + select GENERIC_SMP_IDLE_THREAD
> select GENERIC_STRNCPY_FROM_USER if MMU
> select GENERIC_STRNLEN_USER if MMU
> - select GENERIC_SMP_IDLE_THREAD
> - select GENERIC_ATOMIC64 if !64BIT
> - select GENERIC_IOREMAP
> - select GENERIC_PTDUMP if MMU
> select HAVE_ARCH_AUDITSYSCALL
> + select HAVE_ARCH_KASAN if MMU && 64BIT
> + select HAVE_ARCH_KGDB
> + select HAVE_ARCH_KGDB_QXFER_PKT
> + select HAVE_ARCH_MMAP_RND_BITS if MMU
> select HAVE_ARCH_SECCOMP_FILTER
> + select HAVE_ARCH_TRACEHOOK
> select HAVE_ASM_MODVERSIONS
> + select HAVE_COPY_THREAD_TLS
> select HAVE_DMA_CONTIGUOUS if MMU
> + select HAVE_EBPF_JIT if MMU
> select HAVE_FUTEX_CMPXCHG if FUTEX
> + select HAVE_PCI
> select HAVE_PERF_EVENTS
> select HAVE_PERF_REGS
> select HAVE_PERF_USER_STACK_DUMP
> select HAVE_SYSCALL_TRACEPOINTS
> select IRQ_DOMAIN
> - select SPARSE_IRQ
> - select SYSCTL_EXCEPTION_TRACE
> - select HAVE_ARCH_TRACEHOOK
> - select HAVE_PCI
> select MODULES_USE_ELF_RELA if MODULES
> select MODULE_SECTIONS if MODULES
> - select THREAD_INFO_IN_TASK
> + select OF
> + select OF_EARLY_FLATTREE
> + select OF_IRQ
> select PCI_DOMAINS_GENERIC if PCI
> select PCI_MSI if PCI
> select RISCV_TIMER
> - select GENERIC_IRQ_MULTI_HANDLER
> - select GENERIC_ARCH_TOPOLOGY if SMP
> - select ARCH_HAS_PTE_SPECIAL
> - select ARCH_HAS_MMIOWB
> - select ARCH_HAS_DEBUG_VIRTUAL if MMU
> - select HAVE_EBPF_JIT if MMU
> - select EDAC_SUPPORT
> - select ARCH_HAS_GIGANTIC_PAGE
> - select ARCH_HAS_SET_DIRECT_MAP
> - select ARCH_HAS_SET_MEMORY
> - select ARCH_HAS_STRICT_KERNEL_RWX if MMU
> - select ARCH_WANT_HUGE_PMD_SHARE if 64BIT
> select SPARSEMEM_STATIC if 32BIT
> - select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT if MMU
> - select HAVE_ARCH_MMAP_RND_BITS if MMU
> - select ARCH_HAS_GCOV_PROFILE_ALL
> - select HAVE_COPY_THREAD_TLS
> - select HAVE_ARCH_KASAN if MMU && 64BIT
> - select HAVE_ARCH_KGDB
> - select HAVE_ARCH_KGDB_QXFER_PKT
> - select ARCH_HAS_DEBUG_WX
> + select SPARSE_IRQ
> + select SYSCTL_EXCEPTION_TRACE
> + select THREAD_INFO_IN_TASK
>
> config ARCH_MMAP_RND_BITS_MIN
> default 18 if 64BIT
> @@ -196,11 +196,11 @@ config ARCH_RV64I
> bool "RV64I"
> select 64BIT
> select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 && GCC_VERSION >= 50000
> - select HAVE_FUNCTION_TRACER
> - select HAVE_FUNCTION_GRAPH_TRACER
> - select HAVE_FTRACE_MCOUNT_RECORD
> select HAVE_DYNAMIC_FTRACE if MMU
> select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE
> + select HAVE_FTRACE_MCOUNT_RECORD
> + select HAVE_FUNCTION_GRAPH_TRACER
> + select HAVE_FUNCTION_TRACER
> select SWIOTLB if MMU
>
> endchoice
Thanks. This is on for-next, except I re-ran the script as there have been
some changes.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-26 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19 3:42 [PATCH 1/1] riscv: sort select statements alphanumerically Zong Li
2020-05-26 19:31 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).