* [PATCH] xen-netback: remove unecessary condition check before debugfs_remove_recursive
@ 2018-09-08 13:53 zhong jiang
2018-09-11 8:00 ` Paul Durrant
2018-09-12 6:02 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: zhong jiang @ 2018-09-08 13:53 UTC (permalink / raw)
To: davem, paul.durrant, wei.liu2; +Cc: xen-devel, netdev, linux-kernel
debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
remove the condition check before debugfs_remove_recursive.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/net/xen-netback/netback.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 3621e05..80aae3a 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -1660,8 +1660,7 @@ static int __init netback_init(void)
static void __exit netback_fini(void)
{
#ifdef CONFIG_DEBUG_FS
- if (!IS_ERR_OR_NULL(xen_netback_dbg_root))
- debugfs_remove_recursive(xen_netback_dbg_root);
+ debugfs_remove_recursive(xen_netback_dbg_root);
#endif /* CONFIG_DEBUG_FS */
xenvif_xenbus_fini();
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] xen-netback: remove unecessary condition check before debugfs_remove_recursive
2018-09-08 13:53 [PATCH] xen-netback: remove unecessary condition check before debugfs_remove_recursive zhong jiang
@ 2018-09-11 8:00 ` Paul Durrant
2018-09-12 6:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Paul Durrant @ 2018-09-11 8:00 UTC (permalink / raw)
To: 'zhong jiang', davem, Wei Liu; +Cc: xen-devel, netdev, linux-kernel
> -----Original Message-----
> From: zhong jiang [mailto:zhongjiang@huawei.com]
> Sent: 08 September 2018 14:54
> To: davem@davemloft.net; Paul Durrant <Paul.Durrant@citrix.com>; Wei Liu
> <wei.liu2@citrix.com>
> Cc: xen-devel@lists.xenproject.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] xen-netback: remove unecessary condition check before
> debugfs_remove_recursive
>
> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
> remove the condition check before debugfs_remove_recursive.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> drivers/net/xen-netback/netback.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-
> netback/netback.c
> index 3621e05..80aae3a 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1660,8 +1660,7 @@ static int __init netback_init(void)
> static void __exit netback_fini(void)
> {
> #ifdef CONFIG_DEBUG_FS
> - if (!IS_ERR_OR_NULL(xen_netback_dbg_root))
> - debugfs_remove_recursive(xen_netback_dbg_root);
> + debugfs_remove_recursive(xen_netback_dbg_root);
> #endif /* CONFIG_DEBUG_FS */
> xenvif_xenbus_fini();
> }
> --
> 1.7.12.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-netback: remove unecessary condition check before debugfs_remove_recursive
2018-09-08 13:53 [PATCH] xen-netback: remove unecessary condition check before debugfs_remove_recursive zhong jiang
2018-09-11 8:00 ` Paul Durrant
@ 2018-09-12 6:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-09-12 6:02 UTC (permalink / raw)
To: zhongjiang; +Cc: paul.durrant, wei.liu2, xen-devel, netdev, linux-kernel
From: zhong jiang <zhongjiang@huawei.com>
Date: Sat, 8 Sep 2018 21:53:42 +0800
> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
> remove the condition check before debugfs_remove_recursive.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-12 6:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-08 13:53 [PATCH] xen-netback: remove unecessary condition check before debugfs_remove_recursive zhong jiang
2018-09-11 8:00 ` Paul Durrant
2018-09-12 6:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).