* [PATCH] fs/9p: fix warnings found by checkpatch.pl
@ 2021-10-01 6:34 Sohaib Mohamed
2021-10-01 12:59 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Sohaib Mohamed @ 2021-10-01 6:34 UTC (permalink / raw)
Cc: Sohaib Mohamed, Eric Van Hensbergen, Latchesar Ionkov,
Dominique Martinet, v9fs-developer, linux-kernel
Signed-off-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
---
fs/9p/v9fs.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/9p/v9fs.h b/fs/9p/v9fs.h
index 92124b235a6d..5dd031252236 100644
--- a/fs/9p/v9fs.h
+++ b/fs/9p/v9fs.h
@@ -135,8 +135,8 @@ static inline struct fscache_cookie *v9fs_inode_cookie(struct v9fs_inode *v9inod
extern int v9fs_show_options(struct seq_file *m, struct dentry *root);
-struct p9_fid *v9fs_session_init(struct v9fs_session_info *, const char *,
- char *);
+struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses, const char
+ *dev_name, char *data);
extern void v9fs_session_close(struct v9fs_session_info *v9ses);
extern void v9fs_session_cancel(struct v9fs_session_info *v9ses);
extern void v9fs_session_begin_cancel(struct v9fs_session_info *v9ses);
@@ -167,7 +167,7 @@ extern struct inode *v9fs_inode_from_fid_dotl(struct v9fs_session_info *v9ses,
static inline struct v9fs_session_info *v9fs_inode2v9ses(struct inode *inode)
{
- return (inode->i_sb->s_fs_info);
+ return inode->i_sb->s_fs_info;
}
static inline struct v9fs_session_info *v9fs_dentry2v9ses(struct dentry *dentry)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/9p: fix warnings found by checkpatch.pl
2021-10-01 6:34 [PATCH] fs/9p: fix warnings found by checkpatch.pl Sohaib Mohamed
@ 2021-10-01 12:59 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2021-10-01 12:59 UTC (permalink / raw)
To: Sohaib Mohamed
Cc: Eric Van Hensbergen, Latchesar Ionkov, Dominique Martinet,
v9fs-developer, linux-kernel
On Fri, 2021-10-01 at 08:34 +0200, Sohaib Mohamed wrote:
> Signed-off-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
try using checkpatch on your proposed patch.
> diff --git a/fs/9p/v9fs.h b/fs/9p/v9fs.h
[]
> @@ -135,8 +135,8 @@ static inline struct fscache_cookie *v9fs_inode_cookie(struct v9fs_inode *v9inod
>
>
> extern int v9fs_show_options(struct seq_file *m, struct dentry *root);
>
>
> -struct p9_fid *v9fs_session_init(struct v9fs_session_info *, const char *,
> - char *);
> +struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses, const char
> + *dev_name, char *data);
That's really not pretty as it separates the type of the 2nd argument.
Perhaps:
struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses,
const char *dev_name, char *data);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-01 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-01 6:34 [PATCH] fs/9p: fix warnings found by checkpatch.pl Sohaib Mohamed
2021-10-01 12:59 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).