From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: Rob Herring <robh@kernel.org>
Cc: <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<broonie@kernel.org>, <linux-spi@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v1 2/7] dt-bindings: spi: Add Tegra QSPI device tree binding
Date: Thu, 10 Dec 2020 10:08:16 -0800 [thread overview]
Message-ID: <061c6770-860a-8b5b-7d14-32745a630922@nvidia.com> (raw)
In-Reply-To: <1a9f0391-321d-2463-827b-284bba38e07d@nvidia.com>
On 12/9/20 12:28 PM, Sowjanya Komatineni wrote:
>
> On 12/9/20 9:26 AM, Rob Herring wrote:
>> On Tue, Dec 01, 2020 at 01:12:43PM -0800, Sowjanya Komatineni wrote:
>>> This patch adds YAML based device tree binding document for Tegra
>>> QSPI driver.
>>>
>>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>>> ---
>>> .../devicetree/bindings/spi/nvidia,tegra-qspi.yaml | 77
>>> ++++++++++++++++++++++
>>> 1 file changed, 77 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/spi/nvidia,tegra-qspi.yaml
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/spi/nvidia,tegra-qspi.yaml
>>> b/Documentation/devicetree/bindings/spi/nvidia,tegra-qspi.yaml
>>> new file mode 100644
>>> index 0000000..038a085
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra-qspi.yaml
>>> @@ -0,0 +1,77 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/spi/nvidia,tegra-qspi.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Tegra Quad SPI Controller
>>> +
>>> +maintainers:
>>> + - Thierry Reding <thierry.reding@gmail.com>
>>> + - Jonathan Hunter <jonathanh@nvidia.com>
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - nvidia,tegra210-qspi
>>> + - nvidia,tegra186-qspi
>>> + - nvidia,tegra194-qspi
>>> +
>>> + reg:
>>> + items:
>>> + - description: QSPI registers
>> Just 'maxItems: 1'
>>
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: qspi
>> Kind of a pointless name.
> Thanks Rob for feedback. Do you mean to change name something like
> qspi-clk instead of qspi?
Rob, reason I added clock name is later when we add ddr mode we will
have additional clock.
So driver uses clock name to retrieve.
Will add both clocks to dt-binding doc in v2 although support for ddr
mode in qspi driver can be implemented later.
>>
>>> +
>>> + clocks:
>>> + maxItems: 1
>>> +
>>> + reset-names:
>>> + minItems: 1
>>> + items:
>>> + - const: qspi
>> Same here.
>>
>>> +
>>> + resets:
>>> + maxItems: 1
>>> +
>>> + dmas:
>>> + maxItems: 2
>>> +
>>> + dma-names:
>>> + items:
>>> + - const: rx
>>> + - const: tx
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - interrupts
>>> + - clock-names
>>> + - clocks
>>> + - reset-names
>>> + - resets
>>> +
>>> +additionalProperties: true
>>> +
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/clock/tegra210-car.h>
>>> + #include <dt-bindings/reset/tegra210-car.h>
>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +
>>> + spi@70410000 {
>>> + compatible = "nvidia,tegra210-qspi";
>>> + reg = <0x70410000 0x1000>;
>>> + interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&tegra_car TEGRA210_CLK_QSPI>;
>>> + clock-names = "qspi";
>>> + resets = <&tegra_car 211>;
>>> + reset-names = "qspi";
>>> + dmas = <&apbdma 5>, <&apbdma 5>;
>>> + dma-names = "rx", "tx";
>>> + };
>>> --
>>> 2.7.4
>>>
next prev parent reply other threads:[~2020-12-10 18:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 21:12 [PATCH v1 0/7] Add Tegra QSPI driver Sowjanya Komatineni
2020-12-01 21:12 ` [PATCH v1 1/7] MAINTAINERS: Add Tegra QSPI driver section Sowjanya Komatineni
2020-12-01 21:12 ` [PATCH v1 2/7] dt-bindings: spi: Add Tegra QSPI device tree binding Sowjanya Komatineni
2020-12-09 17:26 ` Rob Herring
2020-12-09 20:28 ` Sowjanya Komatineni
2020-12-10 18:08 ` Sowjanya Komatineni [this message]
2020-12-01 21:12 ` [PATCH v1 3/7] spi: qspi-tegra: Add support for Tegra210 QSPI controller Sowjanya Komatineni
2020-12-02 0:09 ` kernel test robot
2020-12-02 17:27 ` Mark Brown
2020-12-02 19:17 ` Sowjanya Komatineni
2020-12-04 0:22 ` Sowjanya Komatineni
2020-12-04 18:52 ` Mark Brown
2020-12-04 21:04 ` Sowjanya Komatineni
2020-12-04 22:46 ` Mark Brown
2020-12-05 4:10 ` Sowjanya Komatineni
[not found] ` <70f69d4c-8a99-3893-76ea-7860eedb11fa@nvidia.com>
2020-12-08 12:00 ` Mark Brown
2020-12-04 12:26 ` Thierry Reding
2020-12-04 12:17 ` Thierry Reding
2020-12-04 12:11 ` Thierry Reding
2020-12-04 22:42 ` Sowjanya Komatineni
2020-12-04 14:41 ` Jon Hunter
2020-12-04 22:34 ` Sowjanya Komatineni
2020-12-06 18:16 ` Lukas Wunner
2020-12-08 0:14 ` Sowjanya Komatineni
2020-12-08 7:44 ` Lukas Wunner
2020-12-01 21:12 ` [PATCH v1 4/7] spi: qspi-tegra: Add Tegra186 and Tegra194 QSPI compatibles Sowjanya Komatineni
2020-12-02 17:06 ` Mark Brown
2020-12-01 21:12 ` [PATCH v1 5/7] arm64: tegra: Enable QSPI on Jetson Nano Sowjanya Komatineni
2020-12-01 21:12 ` [PATCH v1 6/7] arm64: tegra: Add QSPI nodes on Tegra194 Sowjanya Komatineni
2020-12-01 21:12 ` [PATCH v1 7/7] arm64: tegra: Enable QSPI on Jetson Xavier NX Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=061c6770-860a-8b5b-7d14-32745a630922@nvidia.com \
--to=skomatineni@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).