linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: bcm2835-rpi-zero-w: Fix led polarity
@ 2020-04-18 12:35 Vincent Stehlé
  2020-04-19  9:06 ` Stefan Wahren
  2020-04-21 22:27 ` Florian Fainelli
  0 siblings, 2 replies; 3+ messages in thread
From: Vincent Stehlé @ 2020-04-18 12:35 UTC (permalink / raw)
  To: devicetree, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
	bcm-kernel-feedback-list
  Cc: Rob Herring, Ray Jui, Scott Branden, Nicolas Saenz Julienne,
	Vincent Stehlé,
	Stefan Wahren, Florian Fainelli

The status "ACT" led on the Raspberry Pi Zero W is on when GPIO 47 is low.

This has been verified on a board and somewhat confirmed by both the GPIO
name ("STATUS_LED_N") and the reduced schematics [1].

[1]: https://www.raspberrypi.org/documentation/hardware/raspberrypi/schematics/rpi_SCH_ZeroW_1p1_reduced.pdf

Fixes: 2c7c040c73e9 ("ARM: dts: bcm2835: Add Raspberry Pi Zero W")
Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Cc: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
---
 arch/arm/boot/dts/bcm2835-rpi-zero-w.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts b/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
index 4c3f606e5b8d8..f65448c01e317 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
@@ -24,7 +24,7 @@ chosen {
 
 	leds {
 		act {
-			gpios = <&gpio 47 GPIO_ACTIVE_HIGH>;
+			gpios = <&gpio 47 GPIO_ACTIVE_LOW>;
 		};
 	};
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: bcm2835-rpi-zero-w: Fix led polarity
  2020-04-18 12:35 [PATCH] ARM: dts: bcm2835-rpi-zero-w: Fix led polarity Vincent Stehlé
@ 2020-04-19  9:06 ` Stefan Wahren
  2020-04-21 22:27 ` Florian Fainelli
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Wahren @ 2020-04-19  9:06 UTC (permalink / raw)
  To: Vincent Stehlé,
	devicetree, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
	bcm-kernel-feedback-list
  Cc: Rob Herring, Ray Jui, Scott Branden, Nicolas Saenz Julienne,
	Florian Fainelli

Am 18.04.20 um 14:35 schrieb Vincent Stehlé:
> The status "ACT" led on the Raspberry Pi Zero W is on when GPIO 47 is low.
>
> This has been verified on a board and somewhat confirmed by both the GPIO
> name ("STATUS_LED_N") and the reduced schematics [1].
>
> [1]: https://www.raspberrypi.org/documentation/hardware/raspberrypi/schematics/rpi_SCH_ZeroW_1p1_reduced.pdf
>
> Fixes: 2c7c040c73e9 ("ARM: dts: bcm2835: Add Raspberry Pi Zero W")
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Stefan Wahren <stefan.wahren@i2se.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> ---

Tested-by: Stefan Wahren <stefan.wahren@i2se.com>

Thanks


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: bcm2835-rpi-zero-w: Fix led polarity
  2020-04-18 12:35 [PATCH] ARM: dts: bcm2835-rpi-zero-w: Fix led polarity Vincent Stehlé
  2020-04-19  9:06 ` Stefan Wahren
@ 2020-04-21 22:27 ` Florian Fainelli
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2020-04-21 22:27 UTC (permalink / raw)
  To: bcm-kernel-feedback-list, Vincent Stehlé,
	devicetree, linux-rpi-kernel, linux-arm-kernel, linux-kernel
  Cc: Rob Herring, Ray Jui, Scott Branden, Nicolas Saenz Julienne,
	Stefan Wahren

On Sat, 18 Apr 2020 14:35:22 +0200, Vincent Stehlé <vincent.stehle@laposte.net> wrote:
> The status "ACT" led on the Raspberry Pi Zero W is on when GPIO 47 is low.
> 
> This has been verified on a board and somewhat confirmed by both the GPIO
> name ("STATUS_LED_N") and the reduced schematics [1].
> 
> [1]: https://www.raspberrypi.org/documentation/hardware/raspberrypi/schematics/rpi_SCH_ZeroW_1p1_reduced.pdf
> 
> Fixes: 2c7c040c73e9 ("ARM: dts: bcm2835: Add Raspberry Pi Zero W")
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Stefan Wahren <stefan.wahren@i2se.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> ---

Applied to devicetree/fixes, thanks!
--
Florian

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-21 22:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-18 12:35 [PATCH] ARM: dts: bcm2835-rpi-zero-w: Fix led polarity Vincent Stehlé
2020-04-19  9:06 ` Stefan Wahren
2020-04-21 22:27 ` Florian Fainelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).