* [PATCH RESEND] phy: exynos5-usbdrd: Remove "static" from local variable
@ 2016-08-12 9:27 Axel Lin
2016-08-12 9:31 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2016-08-12 9:27 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Kukjin Kim, Krzysztof Kozlowski, linux-kernel, Axel Lin
The 'reg' local variable does not need to be static.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
This patch was sent on http://www.spinics.net/lists/linux-samsung-soc/msg51405.html
drivers/phy/phy-exynos5-usbdrd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c
index 20696f5..07ed608 100644
--- a/drivers/phy/phy-exynos5-usbdrd.c
+++ b/drivers/phy/phy-exynos5-usbdrd.c
@@ -249,7 +249,7 @@ static void exynos5_usbdrd_phy_isol(struct phy_usb_instance *inst,
static unsigned int
exynos5_usbdrd_pipe3_set_refclk(struct phy_usb_instance *inst)
{
- static u32 reg;
+ u32 reg;
struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst);
/* restore any previous reference clock settings */
@@ -295,7 +295,7 @@ exynos5_usbdrd_pipe3_set_refclk(struct phy_usb_instance *inst)
static unsigned int
exynos5_usbdrd_utmi_set_refclk(struct phy_usb_instance *inst)
{
- static u32 reg;
+ u32 reg;
struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst);
/* restore any previous reference clock settings */
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] phy: exynos5-usbdrd: Remove "static" from local variable
2016-08-12 9:27 [PATCH RESEND] phy: exynos5-usbdrd: Remove "static" from local variable Axel Lin
@ 2016-08-12 9:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2016-08-12 9:31 UTC (permalink / raw)
To: Axel Lin, Kishon Vijay Abraham I; +Cc: Kukjin Kim, linux-kernel
On 08/12/2016 11:27 AM, Axel Lin wrote:
> The 'reg' local variable does not need to be static.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> This patch was sent on http://www.spinics.net/lists/linux-samsung-soc/msg51405.html
>
> drivers/phy/phy-exynos5-usbdrd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Looks correct, good catch!
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-12 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-12 9:27 [PATCH RESEND] phy: exynos5-usbdrd: Remove "static" from local variable Axel Lin
2016-08-12 9:31 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).