* [PATCH 1/2] arm64: dts: qcom: ipq6018: fix NAND node name
@ 2022-09-27 20:12 Robert Marko
2022-09-27 20:12 ` [PATCH 2/2] arm64: dts: qcom: ipq6018: move ARMv8 timer out of SoC node Robert Marko
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Robert Marko @ 2022-09-27 20:12 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel
Cc: Robert Marko
Per schema it should be nand-controller@79b0000 instead of nand@79b0000.
Fix it to match nand-controller.yaml requirements.
Signed-off-by: Robert Marko <robimarko@gmail.com>
---
arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index a7c7ca980a71..57978a8ab498 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -348,7 +348,7 @@ qpic_bam: dma-controller@7984000 {
status = "disabled";
};
- qpic_nand: nand@79b0000 {
+ qpic_nand: nand-controller@79b0000 {
compatible = "qcom,ipq6018-nand";
reg = <0x0 0x079b0000 0x0 0x10000>;
#address-cells = <1>;
--
2.37.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/2] arm64: dts: qcom: ipq6018: move ARMv8 timer out of SoC node 2022-09-27 20:12 [PATCH 1/2] arm64: dts: qcom: ipq6018: fix NAND node name Robert Marko @ 2022-09-27 20:12 ` Robert Marko 2022-09-28 7:43 ` Neil Armstrong 2022-09-28 8:02 ` Krzysztof Kozlowski 2022-09-28 7:43 ` [PATCH 1/2] arm64: dts: qcom: ipq6018: fix NAND node name Neil Armstrong ` (2 subsequent siblings) 3 siblings, 2 replies; 7+ messages in thread From: Robert Marko @ 2022-09-27 20:12 UTC (permalink / raw) To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel Cc: Robert Marko The ARM timer is usually considered not part of SoC node, just like other ARM designed blocks (PMU, PSCI). This fixes dtbs_check warning: arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb: soc: timer: {'compatible': ['arm,armv8-timer'], 'interrupts': [[1, 2, 3848], [1, 3, 3848], [1, 4, 3848], [1, 1, 3848]]} should not be valid under {'type': 'object'} From schema: dtschema/schemas/simple-bus.yaml Signed-off-by: Robert Marko <robimarko@gmail.com> --- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi index 57978a8ab498..428e99e127c3 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -511,14 +511,6 @@ a53pll: clock@b116000 { clock-names = "xo"; }; - timer { - compatible = "arm,armv8-timer"; - interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, - <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, - <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, - <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; - }; - timer@b120000 { #address-cells = <1>; #size-cells = <1>; @@ -770,6 +762,14 @@ dwc_0: usb@8a00000 { }; }; + timer { + compatible = "arm,armv8-timer"; + interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; + }; + wcss: wcss-smp2p { compatible = "qcom,smp2p"; qcom,smem = <435>, <428>; -- 2.37.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: ipq6018: move ARMv8 timer out of SoC node 2022-09-27 20:12 ` [PATCH 2/2] arm64: dts: qcom: ipq6018: move ARMv8 timer out of SoC node Robert Marko @ 2022-09-28 7:43 ` Neil Armstrong 2022-09-28 8:02 ` Krzysztof Kozlowski 1 sibling, 0 replies; 7+ messages in thread From: Neil Armstrong @ 2022-09-28 7:43 UTC (permalink / raw) To: Robert Marko, agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel On 27/09/2022 22:12, Robert Marko wrote: > The ARM timer is usually considered not part of SoC node, just like > other ARM designed blocks (PMU, PSCI). This fixes dtbs_check warning: > > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb: soc: timer: {'compatible': ['arm,armv8-timer'], 'interrupts': [[1, 2, 3848], [1, 3, 3848], [1, 4, 3848], [1, 1, 3848]]} should not be valid under {'type': 'object'} > From schema: dtschema/schemas/simple-bus.yaml > > Signed-off-by: Robert Marko <robimarko@gmail.com> > --- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > index 57978a8ab498..428e99e127c3 100644 > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > @@ -511,14 +511,6 @@ a53pll: clock@b116000 { > clock-names = "xo"; > }; > > - timer { > - compatible = "arm,armv8-timer"; > - interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > - <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > - <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > - <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; > - }; > - > timer@b120000 { > #address-cells = <1>; > #size-cells = <1>; > @@ -770,6 +762,14 @@ dwc_0: usb@8a00000 { > }; > }; > > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > + <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > + <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > + <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; > + }; > + > wcss: wcss-smp2p { > compatible = "qcom,smp2p"; > qcom,smem = <435>, <428>; Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: ipq6018: move ARMv8 timer out of SoC node 2022-09-27 20:12 ` [PATCH 2/2] arm64: dts: qcom: ipq6018: move ARMv8 timer out of SoC node Robert Marko 2022-09-28 7:43 ` Neil Armstrong @ 2022-09-28 8:02 ` Krzysztof Kozlowski 1 sibling, 0 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2022-09-28 8:02 UTC (permalink / raw) To: Robert Marko, agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel On 27/09/2022 22:12, Robert Marko wrote: > The ARM timer is usually considered not part of SoC node, just like > other ARM designed blocks (PMU, PSCI). This fixes dtbs_check warning: > > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb: soc: timer: {'compatible': ['arm,armv8-timer'], 'interrupts': [[1, 2, 3848], [1, 3, 3848], [1, 4, 3848], [1, 1, 3848]]} should not be valid under {'type': 'object'} > From schema: dtschema/schemas/simple-bus.yaml > > Signed-off-by: Robert Marko <robimarko@gmail.com> > --- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 16 ++++++++-------- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: ipq6018: fix NAND node name 2022-09-27 20:12 [PATCH 1/2] arm64: dts: qcom: ipq6018: fix NAND node name Robert Marko 2022-09-27 20:12 ` [PATCH 2/2] arm64: dts: qcom: ipq6018: move ARMv8 timer out of SoC node Robert Marko @ 2022-09-28 7:43 ` Neil Armstrong 2022-09-28 8:03 ` Krzysztof Kozlowski 2022-10-18 3:14 ` (subset) " Bjorn Andersson 3 siblings, 0 replies; 7+ messages in thread From: Neil Armstrong @ 2022-09-28 7:43 UTC (permalink / raw) To: Robert Marko, agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel On 27/09/2022 22:12, Robert Marko wrote: > Per schema it should be nand-controller@79b0000 instead of nand@79b0000. > Fix it to match nand-controller.yaml requirements. > > Signed-off-by: Robert Marko <robimarko@gmail.com> > --- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > index a7c7ca980a71..57978a8ab498 100644 > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > @@ -348,7 +348,7 @@ qpic_bam: dma-controller@7984000 { > status = "disabled"; > }; > > - qpic_nand: nand@79b0000 { > + qpic_nand: nand-controller@79b0000 { > compatible = "qcom,ipq6018-nand"; > reg = <0x0 0x079b0000 0x0 0x10000>; > #address-cells = <1>; Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: ipq6018: fix NAND node name 2022-09-27 20:12 [PATCH 1/2] arm64: dts: qcom: ipq6018: fix NAND node name Robert Marko 2022-09-27 20:12 ` [PATCH 2/2] arm64: dts: qcom: ipq6018: move ARMv8 timer out of SoC node Robert Marko 2022-09-28 7:43 ` [PATCH 1/2] arm64: dts: qcom: ipq6018: fix NAND node name Neil Armstrong @ 2022-09-28 8:03 ` Krzysztof Kozlowski 2022-10-18 3:14 ` (subset) " Bjorn Andersson 3 siblings, 0 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2022-09-28 8:03 UTC (permalink / raw) To: Robert Marko, agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel On 27/09/2022 22:12, Robert Marko wrote: > Per schema it should be nand-controller@79b0000 instead of nand@79b0000. > Fix it to match nand-controller.yaml requirements. > > Signed-off-by: Robert Marko <robimarko@gmail.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: (subset) [PATCH 1/2] arm64: dts: qcom: ipq6018: fix NAND node name 2022-09-27 20:12 [PATCH 1/2] arm64: dts: qcom: ipq6018: fix NAND node name Robert Marko ` (2 preceding siblings ...) 2022-09-28 8:03 ` Krzysztof Kozlowski @ 2022-10-18 3:14 ` Bjorn Andersson 3 siblings, 0 replies; 7+ messages in thread From: Bjorn Andersson @ 2022-10-18 3:14 UTC (permalink / raw) To: konrad.dybcio, devicetree, krzysztof.kozlowski+dt, linux-kernel, agross, robh+dt, linux-arm-msm, robimarko On Tue, 27 Sep 2022 22:12:17 +0200, Robert Marko wrote: > Per schema it should be nand-controller@79b0000 instead of nand@79b0000. > Fix it to match nand-controller.yaml requirements. > > Applied, thanks! [1/2] arm64: dts: qcom: ipq6018: fix NAND node name commit: 8857b0ab6a562c473c5bded0efda9390b82a84d4 [2/2] arm64: dts: qcom: ipq6018: move ARMv8 timer out of SoC node commit: feeef118fda562cf9081edef8ad464d89db070f4 Best regards, -- Bjorn Andersson <andersson@kernel.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-10-18 3:22 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-27 20:12 [PATCH 1/2] arm64: dts: qcom: ipq6018: fix NAND node name Robert Marko 2022-09-27 20:12 ` [PATCH 2/2] arm64: dts: qcom: ipq6018: move ARMv8 timer out of SoC node Robert Marko 2022-09-28 7:43 ` Neil Armstrong 2022-09-28 8:02 ` Krzysztof Kozlowski 2022-09-28 7:43 ` [PATCH 1/2] arm64: dts: qcom: ipq6018: fix NAND node name Neil Armstrong 2022-09-28 8:03 ` Krzysztof Kozlowski 2022-10-18 3:14 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).