archive mirror
 help / color / mirror / Atom feed
From: "Richard Purdie" <>
To: "Alan Cox" <>
Cc: "Linux Kernel Mailing List" <>
Subject: Re: Flaw in ide_unregister()
Date: Mon, 10 Jan 2005 21:17:11 -0000	[thread overview]
Message-ID: <06ae01c4f759$c6036dc0$0f01a8c0@max> (raw)
In-Reply-To: 1105382277.12054.94.camel@localhost.localdomain

Alan Cox:
> Currently there are four things in the -ac tree that use this feature
> 1. ISA PnP, where we don't support hotplug (and anyway the only maker of
> consumer hotpluggable ISA docking stations I know of - IBM - wont
> provide docs on them)
> 2. ide-cs
> 3. delkin (cardbus IDE)
> 4. PCI layer
> Of those the PCI one is a common shared function so I put the supporting
> logic in the IDE PCI helper function, The others need different handling
> at the PCMCIA or Cardbus level in order to free up resources and clean
> up.

PCI seems to use __ide_unregister_hwif() directly. Case 2 and 3 seem to need 
the "retry until the device is unregistered" behaviour and case 1 seems to 
be compatible with that.

That suggests ide_unregister_hwif() could call itself back via a work queue 
until the device unregisters successfully. Anything that doesn't want this 
behaviour can use __ide_unregister_hwif() directly as PCI does?


      reply	other threads:[~2005-01-11  2:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-31 12:04 Flaw in ide_unregister() Richard Purdie
2005-01-02 14:36 ` Alan Cox
2005-01-09 22:37   ` Richard Purdie
2005-01-10 11:09     ` Alan Cox
2005-01-10 12:39       ` Richard Purdie
2005-01-10 19:23         ` Alan Cox
2005-01-10 21:17           ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='06ae01c4f759$c6036dc0$0f01a8c0@max' \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).