From: <Austin.Bolen@dell.com>
To: <kbusch@kernel.org>, <Austin.Bolen@dell.com>
Cc: <hch@infradead.org>, <Alex_Gagniuc@Dellteam.com>,
<torvalds@linux-foundation.org>, <keith.busch@intel.com>,
<sagi@grimberg.me>, <linux-kernel@vger.kernel.org>,
<linux-nvme@lists.infradead.org>, <axboe@fb.com>,
<mr.nuke.me@gmail.com>, <hch@lst.de>,
<jonathan.derrick@intel.com>
Subject: Re: [PATCH] nvme-pci: Prevent mmio reads if pci channel offline
Date: Fri, 1 Mar 2019 01:52:02 +0000 [thread overview]
Message-ID: <06eb10e5a7324bb5ac537fd57e015d73@AUSX13MPC131.AMER.DELL.COM> (raw)
In-Reply-To: 20190301003026.GA22712@localhost.localdomain
On 2/28/2019 6:30 PM, Keith Busch wrote:
>
> For single port drives, yes, but that wouldn't work so well for multi-port
> devices connected to different busses, maybe even across multiple hosts.
> The equivalent of an FLR across all ports should have been sufficient,
> IMO.
>
In that case I'd argue that it really is a surprise down to the other
host and escalating as such is appropriate. Agree that something like
FLR that reset everything in the subsystem but kept link up may have
been sufficient.
prev parent reply other threads:[~2019-03-01 2:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 1:05 [PATCH] nvme-pci: Prevent mmio reads if pci channel offline Jon Derrick
2019-02-22 21:28 ` Linus Torvalds
2019-02-22 21:59 ` Keith Busch
2019-02-24 20:37 ` Alex_Gagniuc
2019-02-24 22:42 ` Linus Torvalds
2019-02-24 23:27 ` Alex_Gagniuc
2019-02-25 0:43 ` Linus Torvalds
2019-02-25 15:55 ` Keith Busch
2019-02-26 22:37 ` Alex_Gagniuc
2019-02-27 1:01 ` Linus Torvalds
2019-02-27 16:42 ` Alex_Gagniuc
2019-02-27 17:51 ` Keith Busch
2019-02-27 18:07 ` Alex_Gagniuc
2019-02-27 17:55 ` Austin.Bolen
2019-02-27 20:04 ` Austin.Bolen
2019-02-28 14:16 ` Christoph Hellwig
2019-02-28 23:10 ` Austin.Bolen
2019-02-28 23:20 ` Keith Busch
2019-02-28 23:43 ` Austin.Bolen
2019-03-01 0:30 ` Keith Busch
2019-03-01 1:52 ` Austin.Bolen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06eb10e5a7324bb5ac537fd57e015d73@AUSX13MPC131.AMER.DELL.COM \
--to=austin.bolen@dell.com \
--cc=Alex_Gagniuc@Dellteam.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jonathan.derrick@intel.com \
--cc=kbusch@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mr.nuke.me@gmail.com \
--cc=sagi@grimberg.me \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).