From: Keith Busch <keith.busch@intel.com>
To: "Alex_Gagniuc@Dellteam.com" <Alex_Gagniuc@Dellteam.com>
Cc: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"axboe@fb.com" <axboe@fb.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"mr.nuke.me@gmail.com" <mr.nuke.me@gmail.com>,
"hch@lst.de" <hch@lst.de>,
"Derrick, Jonathan" <jonathan.derrick@intel.com>
Subject: Re: [PATCH] nvme-pci: Prevent mmio reads if pci channel offline
Date: Mon, 25 Feb 2019 08:55:01 -0700 [thread overview]
Message-ID: <20190225155501.GI10237@localhost.localdomain> (raw)
In-Reply-To: <cbe2ed1562a64609be6538f5816ec1b6@ausx13mps321.AMER.DELL.COM>
On Sun, Feb 24, 2019 at 03:27:09PM -0800, Alex_Gagniuc@Dellteam.com wrote:
>
> More like "fatal error, just panic". It looks like this (from a serial
> console):
>
> [ 57.680494] {1}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 1
> [ 57.680495] {1}[Hardware Error]: event severity: fatal
> [ 57.680496] {1}[Hardware Error]: Error 0, type: fatal
> [ 57.680496] {1}[Hardware Error]: section_type: PCIe error
> [ 57.680497] {1}[Hardware Error]: port_type: 6, downstream switch port
> [ 57.680498] {1}[Hardware Error]: version: 3.0
> [ 57.680498] {1}[Hardware Error]: command: 0x0407, status: 0x0010
> [ 57.680499] {1}[Hardware Error]: device_id: 0000:3c:07.0
> [ 57.680499] {1}[Hardware Error]: slot: 1
> [ 57.680500] {1}[Hardware Error]: secondary_bus: 0x40
> [ 57.680500] {1}[Hardware Error]: vendor_id: 0x10b5, device_id: 0x9733
> [ 57.680501] {1}[Hardware Error]: class_code: 000406
> [ 57.680502] {1}[Hardware Error]: bridge: secondary_status: 0x0000, > control: 0x0003
This is a reaction to a ERR_FATAL message, right? What happens if we
ignore firmware first and override control of the AER masking with a
set to the Unsupported Request Error Mask in the root and downstream
ports? You can do a quick test like this for the above's hardware:
# setpci -s 3c:07.0 ECAP_AER+8.l=100000:100000
You'd probably have to do the same command to the root port BDf, and any
other switches you have them in the hierarchy.
next prev parent reply other threads:[~2019-02-25 15:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 1:05 [PATCH] nvme-pci: Prevent mmio reads if pci channel offline Jon Derrick
2019-02-22 21:28 ` Linus Torvalds
2019-02-22 21:59 ` Keith Busch
2019-02-24 20:37 ` Alex_Gagniuc
2019-02-24 22:42 ` Linus Torvalds
2019-02-24 23:27 ` Alex_Gagniuc
2019-02-25 0:43 ` Linus Torvalds
2019-02-25 15:55 ` Keith Busch [this message]
2019-02-26 22:37 ` Alex_Gagniuc
2019-02-27 1:01 ` Linus Torvalds
2019-02-27 16:42 ` Alex_Gagniuc
2019-02-27 17:51 ` Keith Busch
2019-02-27 18:07 ` Alex_Gagniuc
2019-02-27 17:55 ` Austin.Bolen
2019-02-27 20:04 ` Austin.Bolen
2019-02-28 14:16 ` Christoph Hellwig
2019-02-28 23:10 ` Austin.Bolen
2019-02-28 23:20 ` Keith Busch
2019-02-28 23:43 ` Austin.Bolen
2019-03-01 0:30 ` Keith Busch
2019-03-01 1:52 ` Austin.Bolen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225155501.GI10237@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=Alex_Gagniuc@Dellteam.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jonathan.derrick@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mr.nuke.me@gmail.com \
--cc=sagi@grimberg.me \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).