* [PATCH v4] modules_install: make missing $DEPMOD a Warning instead of an Error
@ 2018-08-28 19:59 Randy Dunlap
2018-08-31 16:23 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2018-08-28 19:59 UTC (permalink / raw)
To: linux-kbuild, Masahiro Yamada, LKML
Cc: H. Nikolaus Schaller, stable, Lucas De Marchi, Lucas De Marchi,
Michal Marek, Jessica Yu, Chih-Wei Huang
From: Randy Dunlap <rdunlap@infradead.org>
When $DEPMOD is not found, only print a warning instead of exiting
with an error message and error status:
Warning: 'make modules_install' requires /sbin/depmod. Please install it.
This is probably in the kmod package.
Change the Error to a Warning because "not all build hosts for cross
compiling Linux are Linux systems and are able to provide a working
port of depmod, especially at the file patch /sbin/depmod."
I.e., "make modules_install" may be used to copy/install the
loadable modules files to a target directory on a build system and
then transferred to an embedded device where /sbin/depmod is run
instead of it being run on the build system.
Fixes: 934193a654c1 ("kbuild: verify that $DEPMOD is installed")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
Cc: stable@vger.kernel.org
Cc: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: Michal Marek <michal.lkml@markovi.net>
Cc: Jessica Yu <jeyu@kernel.org>
Cc: Chih-Wei Huang <cwhuang@linux.org.tw>
Cc: H. Nikolaus Schaller <hns@goldelico.com>
---
v2: add missing "exit 0" and update the commit message (no Error).
v3: add Fixes: and Cc: stable
v4: add Reported-by: and more explanation for the patch.
scripts/depmod.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- lnx-418.orig/scripts/depmod.sh
+++ lnx-418/scripts/depmod.sh
@@ -15,9 +15,9 @@ if ! test -r System.map ; then
fi
if [ -z $(command -v $DEPMOD) ]; then
- echo "'make modules_install' requires $DEPMOD. Please install it." >&2
+ echo "Warning: 'make modules_install' requires $DEPMOD. Please install it." >&2
echo "This is probably in the kmod package." >&2
- exit 1
+ exit 0
fi
# older versions of depmod require the version string to start with three
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v4] modules_install: make missing $DEPMOD a Warning instead of an Error
2018-08-28 19:59 [PATCH v4] modules_install: make missing $DEPMOD a Warning instead of an Error Randy Dunlap
@ 2018-08-31 16:23 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2018-08-31 16:23 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kbuild, LKML, H. Nikolaus Schaller, stable,
Lucas De Marchi, Lucas De Marchi, Michal Marek, Jessica Yu,
Chih-Wei Huang
2018-08-29 4:59 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> When $DEPMOD is not found, only print a warning instead of exiting
> with an error message and error status:
>
> Warning: 'make modules_install' requires /sbin/depmod. Please install it.
> This is probably in the kmod package.
>
> Change the Error to a Warning because "not all build hosts for cross
> compiling Linux are Linux systems and are able to provide a working
> port of depmod, especially at the file patch /sbin/depmod."
>
> I.e., "make modules_install" may be used to copy/install the
> loadable modules files to a target directory on a build system and
> then transferred to an embedded device where /sbin/depmod is run
> instead of it being run on the build system.
>
> Fixes: 934193a654c1 ("kbuild: verify that $DEPMOD is installed")
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
> Cc: stable@vger.kernel.org
> Cc: Lucas De Marchi <lucas.demarchi@profusion.mobi>
> Cc: Lucas De Marchi <lucas.de.marchi@gmail.com>
> Cc: Michal Marek <michal.lkml@markovi.net>
> Cc: Jessica Yu <jeyu@kernel.org>
> Cc: Chih-Wei Huang <cwhuang@linux.org.tw>
> Cc: H. Nikolaus Schaller <hns@goldelico.com>
> ---
Applied to linux-kbuild/fixes. Thanks!
> v2: add missing "exit 0" and update the commit message (no Error).
> v3: add Fixes: and Cc: stable
> v4: add Reported-by: and more explanation for the patch.
>
> scripts/depmod.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- lnx-418.orig/scripts/depmod.sh
> +++ lnx-418/scripts/depmod.sh
> @@ -15,9 +15,9 @@ if ! test -r System.map ; then
> fi
>
> if [ -z $(command -v $DEPMOD) ]; then
> - echo "'make modules_install' requires $DEPMOD. Please install it." >&2
> + echo "Warning: 'make modules_install' requires $DEPMOD. Please install it." >&2
> echo "This is probably in the kmod package." >&2
> - exit 1
> + exit 0
> fi
>
> # older versions of depmod require the version string to start with three
>
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-31 16:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-28 19:59 [PATCH v4] modules_install: make missing $DEPMOD a Warning instead of an Error Randy Dunlap
2018-08-31 16:23 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).