* [patch] ARM: fix module-bound check in setting page attributes
@ 2015-03-25 4:20 Hillf Danton
2015-04-07 8:30 ` Hillf Danton
2015-05-01 18:25 ` Laura Abbott
0 siblings, 2 replies; 5+ messages in thread
From: Hillf Danton @ 2015-03-25 4:20 UTC (permalink / raw)
To: 'Laura Abbott'
Cc: 'Russell King', linux-kernel, linux, Hillf Danton
It was introduced in commit f2ca09f381a59
(ARM: 8311/1: Don't use is_module_addr in setting page attributes)
We have no need to check start twice, but see if end is also in range.
Signed-off-by: Hillf Danton <hillf.zj@alibaba-inc.com>
---
--- a/arch/arm/mm/pageattr.c Wed Mar 25 11:55:13 2015
+++ b/arch/arm/mm/pageattr.c Wed Mar 25 11:57:31 2015
@@ -52,7 +52,7 @@ static int change_memory_common(unsigned
if (start < MODULES_VADDR || start >= MODULES_END)
return -EINVAL;
- if (end < MODULES_VADDR || start >= MODULES_END)
+ if (end < MODULES_VADDR || end >= MODULES_END)
return -EINVAL;
data.set_mask = set_mask;
--
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] ARM: fix module-bound check in setting page attributes
2015-03-25 4:20 [patch] ARM: fix module-bound check in setting page attributes Hillf Danton
@ 2015-04-07 8:30 ` Hillf Danton
2015-04-14 6:20 ` Hillf Danton
2015-05-01 18:25 ` Laura Abbott
1 sibling, 1 reply; 5+ messages in thread
From: Hillf Danton @ 2015-04-07 8:30 UTC (permalink / raw)
To: Hillf Danton, 'Laura Abbott'
Cc: 'Russell King', 'linux-kernel', linux
Ping
>
> It was introduced in commit f2ca09f381a59
> (ARM: 8311/1: Don't use is_module_addr in setting page attributes)
>
> We have no need to check start twice, but see if end is also in range.
>
> Signed-off-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> ---
>
> --- a/arch/arm/mm/pageattr.c Wed Mar 25 11:55:13 2015
> +++ b/arch/arm/mm/pageattr.c Wed Mar 25 11:57:31 2015
> @@ -52,7 +52,7 @@ static int change_memory_common(unsigned
> if (start < MODULES_VADDR || start >= MODULES_END)
> return -EINVAL;
>
> - if (end < MODULES_VADDR || start >= MODULES_END)
> + if (end < MODULES_VADDR || end >= MODULES_END)
> return -EINVAL;
>
> data.set_mask = set_mask;
> --
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] ARM: fix module-bound check in setting page attributes
2015-04-07 8:30 ` Hillf Danton
@ 2015-04-14 6:20 ` Hillf Danton
0 siblings, 0 replies; 5+ messages in thread
From: Hillf Danton @ 2015-04-14 6:20 UTC (permalink / raw)
To: Hillf Danton, 'Laura Abbott'
Cc: 'Russell King', 'linux-kernel',
linux, 'Arnd Bergmann'
Ping
> -----Original Message-----
> From: Hillf Danton [mailto:hillf.zj@alibaba-inc.com]
> Sent: Tuesday, April 07, 2015 4:31 PM
> To: Hillf Danton; 'Laura Abbott'
> Cc: 'Russell King'; 'linux-kernel'; linux@arm.linux.org.uk
> Subject: Re: [patch] ARM: fix module-bound check in setting page attributes
>
> Ping
> >
> > It was introduced in commit f2ca09f381a59
> > (ARM: 8311/1: Don't use is_module_addr in setting page attributes)
> >
> > We have no need to check start twice, but see if end is also in range.
> >
> > Signed-off-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> > ---
> >
> > --- a/arch/arm/mm/pageattr.c Wed Mar 25 11:55:13 2015
> > +++ b/arch/arm/mm/pageattr.c Wed Mar 25 11:57:31 2015
> > @@ -52,7 +52,7 @@ static int change_memory_common(unsigned
> > if (start < MODULES_VADDR || start >= MODULES_END)
> > return -EINVAL;
> >
> > - if (end < MODULES_VADDR || start >= MODULES_END)
> > + if (end < MODULES_VADDR || end >= MODULES_END)
> > return -EINVAL;
> >
> > data.set_mask = set_mask;
> > --
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] ARM: fix module-bound check in setting page attributes
2015-03-25 4:20 [patch] ARM: fix module-bound check in setting page attributes Hillf Danton
2015-04-07 8:30 ` Hillf Danton
@ 2015-05-01 18:25 ` Laura Abbott
2015-05-04 2:52 ` Hillf Danton
1 sibling, 1 reply; 5+ messages in thread
From: Laura Abbott @ 2015-05-01 18:25 UTC (permalink / raw)
To: Hillf Danton; +Cc: 'Russell King', linux-kernel, linux
On 3/24/15 9:20 PM, Hillf Danton wrote:
> It was introduced in commit f2ca09f381a59
> (ARM: 8311/1: Don't use is_module_addr in setting page attributes)
>
> We have no need to check start twice, but see if end is also in range.
>
> Signed-off-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> ---
>
> --- a/arch/arm/mm/pageattr.c Wed Mar 25 11:55:13 2015
> +++ b/arch/arm/mm/pageattr.c Wed Mar 25 11:57:31 2015
> @@ -52,7 +52,7 @@ static int change_memory_common(unsigned
> if (start < MODULES_VADDR || start >= MODULES_END)
> return -EINVAL;
>
> - if (end < MODULES_VADDR || start >= MODULES_END)
> + if (end < MODULES_VADDR || end >= MODULES_END)
> return -EINVAL;
>
> data.set_mask = set_mask;
> --
>
>
Sorry for the delay, that e-mail address is being phased out.
Please remember to Cc linux-arm-kernel when sending anything
in arch/arm. If this hasn't been picked up, please resend
with linux-arm-kernel Cc'ed and you can add
Acked-by: Laura Abbott <laura@labbott.name>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [patch] ARM: fix module-bound check in setting page attributes
2015-05-01 18:25 ` Laura Abbott
@ 2015-05-04 2:52 ` Hillf Danton
0 siblings, 0 replies; 5+ messages in thread
From: Hillf Danton @ 2015-05-04 2:52 UTC (permalink / raw)
To: 'Laura Abbott'
Cc: 'Russell King', 'linux-kernel', linux-arm-kernel
It was introduced in commit f2ca09f381a59
(ARM: 8311/1: Don't use is_module_addr in setting page attributes)
We have no need to check start twice, but see if end is also in range.
Signed-off-by: Hillf Danton <hillf.zj@alibaba-inc.com>
Acked-by: Laura Abbott <laura@labbott.name>
---
--- a/arch/arm/mm/pageattr.c Mon May 4 10:33:49 2015
+++ b/arch/arm/mm/pageattr.c Mon May 4 10:35:32 2015
@@ -52,7 +52,7 @@ static int change_memory_common(unsigned
if (start < MODULES_VADDR || start >= MODULES_END)
return -EINVAL;
- if (end < MODULES_VADDR || start >= MODULES_END)
+ if (end < MODULES_VADDR || end >= MODULES_END)
return -EINVAL;
data.set_mask = set_mask;
--
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-04 2:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-25 4:20 [patch] ARM: fix module-bound check in setting page attributes Hillf Danton
2015-04-07 8:30 ` Hillf Danton
2015-04-14 6:20 ` Hillf Danton
2015-05-01 18:25 ` Laura Abbott
2015-05-04 2:52 ` Hillf Danton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).