linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: "'Song Bao Hua (Barry Song)'" <song.bao.hua@hisilicon.com>,
	Shakeel Butt <shakeelb@google.com>
Cc: Vitaly Wool <vitaly.wool@konsulko.com>,
	Minchan Kim <minchan@kernel.org>, Mike Galbraith <efault@gmx.de>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	NitinGupta <ngupta@vflare.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: RE: [PATCH] zsmalloc: do not use bit_spin_lock
Date: Tue, 22 Dec 2020 09:20:12 +0000	[thread overview]
Message-ID: <0777a34e3e9246fe83e693ba07405d28@AcuMS.aculab.com> (raw)
In-Reply-To: <8f17abe06057498dba9413f706b86207@hisilicon.com>

From: Song Bao Hua
> Sent: 21 December 2020 23:02
...
> > For decompression, I would like as low latency as possible which I
> > think is only possible by doing decompression on a cpu synchronously.
> 
> One possibility is that we change HW accelerator driver to be sync
> polling for decompression. But this still depends on async api as
> this is the framework nowadays, the difference would be the driver
> won't really block. crypto_wait_req() will return without actual
> sleep.

How long does the HW accelerated compress/decompress need to be before
it is actually worth sleeping the process?
While the HW version might be faster than the SW one, it may not be
enough faster to allow for the hardware interrupt and process sleep.
So it may be worth just spinning (polling the hardware register)
until the request completes.

If decompress are done that way, but compress left async, then
the decompress might need to fallback to SW if the HW is busy.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

  reply	other threads:[~2020-12-22  9:21 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-19 10:04 [patch] zswap: fix zswap_frontswap_load() vs zsmalloc::map/unmap() might_sleep() splat Mike Galbraith
2020-12-19 10:12 ` Mike Galbraith
2020-12-19 10:20   ` Vitaly Wool
2020-12-19 10:27     ` Mike Galbraith
2020-12-19 10:46       ` Vitaly Wool
2020-12-19 10:59         ` Mike Galbraith
2020-12-19 11:03           ` Mike Galbraith
2020-12-20  0:22           ` [PATCH] zsmalloc: do not use bit_spin_lock Vitaly Wool
2020-12-20  1:18             ` Matthew Wilcox
2020-12-20  7:21               ` Vitaly Wool
2021-01-14 16:17                 ` Sebastian Andrzej Siewior
2020-12-20  1:23             ` Mike Galbraith
2020-12-20  4:11               ` Mike Galbraith
2020-12-20  7:47               ` Mike Galbraith
2020-12-20 21:20                 ` Song Bao Hua (Barry Song)
2020-12-20 22:10                   ` Mike Galbraith
2020-12-20  1:56             ` Mike Galbraith
2020-12-21 17:24             ` Minchan Kim
2020-12-21 19:20               ` Vitaly Wool
2020-12-21 19:50                 ` Shakeel Butt
2020-12-21 20:05                   ` Song Bao Hua (Barry Song)
2020-12-21 21:02                     ` Shakeel Butt
2020-12-21 21:25                       ` Song Bao Hua (Barry Song)
2020-12-21 22:11                         ` Vitaly Wool
2020-12-21 22:42                           ` Song Bao Hua (Barry Song)
2020-12-21 23:35                           ` Song Bao Hua (Barry Song)
2020-12-22  0:59                             ` Vitaly Wool
2020-12-22  1:10                               ` Song Bao Hua (Barry Song)
2020-12-22  1:42                               ` Song Bao Hua (Barry Song)
     [not found]                                 ` <CAM4kBBK=5eBdCjWc5VJXcdr=Z4PV1=ZQ2n8fZmJ6ahJbpUyv2A@mail.gmail.com>
2020-12-22  2:07                                   ` Song Bao Hua (Barry Song)
2020-12-22  2:10                                   ` Song Bao Hua (Barry Song)
2020-12-22  9:44                                     ` Vitaly Wool
2020-12-22 21:06                                       ` Song Bao Hua (Barry Song)
2020-12-23  0:11                                         ` Vitaly Wool
2020-12-23 12:44                                           ` tiantao (H)
2020-12-23 18:25                                             ` Vitaly Wool
2021-01-14 16:18                                               ` Sebastian Andrzej Siewior
2021-01-14 16:29                                                 ` Vitaly Wool
2021-01-14 16:56                                                   ` Sebastian Andrzej Siewior
2021-01-14 17:15                                                     ` Vitaly Wool
2021-01-14 17:18                                                       ` Sebastian Andrzej Siewior
2020-12-21 22:46                         ` Shakeel Butt
2020-12-21 23:02                           ` Song Bao Hua (Barry Song)
2020-12-22  9:20                             ` David Laight [this message]
2020-12-21 20:22                 ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0777a34e3e9246fe83e693ba07405d28@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=shakeelb@google.com \
    --cc=song.bao.hua@hisilicon.com \
    --cc=vitaly.wool@konsulko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).