From: Vitaly Wool <vitaly.wool@konsulko.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "tiantao (H)" <tiantao6@huawei.com>,
"Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>,
Shakeel Butt <shakeelb@google.com>,
Minchan Kim <minchan@kernel.org>, Mike Galbraith <efault@gmx.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, NitinGupta <ngupta@vflare.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
"tiantao (H)" <tiantao6@hisilicon.com>
Subject: Re: [PATCH] zsmalloc: do not use bit_spin_lock
Date: Thu, 14 Jan 2021 18:15:08 +0100 [thread overview]
Message-ID: <CAM4kBBLqgh=ymq4pg6URB3OhjhRSH3O=4AEMRBuaC3Z0-hZ4Lg@mail.gmail.com> (raw)
In-Reply-To: <20210114165645.czqpsk3lacmiyiik@linutronix.de>
On Thu, Jan 14, 2021 at 5:56 PM Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
>
> On 2021-01-14 17:29:37 [+0100], Vitaly Wool wrote:
> > On Thu, 14 Jan 2021, 17:18 Sebastian Andrzej Siewior,
> > <bigeasy@linutronix.de> wrote:
> > >
> > > On 2020-12-23 19:25:02 [+0100], Vitaly Wool wrote:
> > > > > write the following patch according to your idea, what do you think ?
> > > >
> > > > Yep, that is basically what I was thinking of. Some nitpicks below:
> > >
> > > Did this go somewhere? The thread just ends here on my end.
> > > Mike, is this patch fixing / helping your case in anyway?
> >
> > Please see
> > * https://marc.info/?l=linux-mm&m=160889419514019&w=2
> > * https://marc.info/?l=linux-mm&m=160889418114011&w=2
> > * https://marc.info/?l=linux-mm&m=160889448814057&w=2
>
> Thank you, that would be
> 1608894171-54174-1-git-send-email-tiantao6@hisilicon.com
>
> for b4 compatibility :)
>
> > Haven't had time to test these yet but seem to be alright.
>
> So zs_map_object() still disables preemption but the mutex part is
> avoided by the patch?
Basically, yes. Minchan was very clear that he didn't want to remove
that inter-function locking, so be it.
I wouldn't really advise to use zsmalloc with zswap because zsmalloc
has no support for reclaim, nevertheless I wouldn't like this
configuration to stop working for those who are already using it.
Would you or Mike be up for testing Tian Taos's patchset?
Best regards,
Vitaly
next prev parent reply other threads:[~2021-01-14 17:16 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 10:04 [patch] zswap: fix zswap_frontswap_load() vs zsmalloc::map/unmap() might_sleep() splat Mike Galbraith
2020-12-19 10:12 ` Mike Galbraith
2020-12-19 10:20 ` Vitaly Wool
2020-12-19 10:27 ` Mike Galbraith
2020-12-19 10:46 ` Vitaly Wool
2020-12-19 10:59 ` Mike Galbraith
2020-12-19 11:03 ` Mike Galbraith
2020-12-20 0:22 ` [PATCH] zsmalloc: do not use bit_spin_lock Vitaly Wool
2020-12-20 1:18 ` Matthew Wilcox
2020-12-20 7:21 ` Vitaly Wool
2021-01-14 16:17 ` Sebastian Andrzej Siewior
2020-12-20 1:23 ` Mike Galbraith
2020-12-20 4:11 ` Mike Galbraith
2020-12-20 7:47 ` Mike Galbraith
2020-12-20 21:20 ` Song Bao Hua (Barry Song)
2020-12-20 22:10 ` Mike Galbraith
2020-12-20 1:56 ` Mike Galbraith
2020-12-21 17:24 ` Minchan Kim
2020-12-21 19:20 ` Vitaly Wool
2020-12-21 19:50 ` Shakeel Butt
2020-12-21 20:05 ` Song Bao Hua (Barry Song)
2020-12-21 21:02 ` Shakeel Butt
2020-12-21 21:25 ` Song Bao Hua (Barry Song)
2020-12-21 22:11 ` Vitaly Wool
2020-12-21 22:42 ` Song Bao Hua (Barry Song)
2020-12-21 23:35 ` Song Bao Hua (Barry Song)
2020-12-22 0:59 ` Vitaly Wool
2020-12-22 1:10 ` Song Bao Hua (Barry Song)
2020-12-22 1:42 ` Song Bao Hua (Barry Song)
[not found] ` <CAM4kBBK=5eBdCjWc5VJXcdr=Z4PV1=ZQ2n8fZmJ6ahJbpUyv2A@mail.gmail.com>
2020-12-22 2:07 ` Song Bao Hua (Barry Song)
2020-12-22 2:10 ` Song Bao Hua (Barry Song)
2020-12-22 9:44 ` Vitaly Wool
2020-12-22 21:06 ` Song Bao Hua (Barry Song)
2020-12-23 0:11 ` Vitaly Wool
2020-12-23 12:44 ` tiantao (H)
2020-12-23 18:25 ` Vitaly Wool
2021-01-14 16:18 ` Sebastian Andrzej Siewior
2021-01-14 16:29 ` Vitaly Wool
2021-01-14 16:56 ` Sebastian Andrzej Siewior
2021-01-14 17:15 ` Vitaly Wool [this message]
2021-01-14 17:18 ` Sebastian Andrzej Siewior
2020-12-21 22:46 ` Shakeel Butt
2020-12-21 23:02 ` Song Bao Hua (Barry Song)
2020-12-22 9:20 ` David Laight
2020-12-21 20:22 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM4kBBLqgh=ymq4pg6URB3OhjhRSH3O=4AEMRBuaC3Z0-hZ4Lg@mail.gmail.com' \
--to=vitaly.wool@konsulko.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=shakeelb@google.com \
--cc=song.bao.hua@hisilicon.com \
--cc=tiantao6@hisilicon.com \
--cc=tiantao6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).