From: Pierre Yves MORDRET <pierre-yves.mordret@st.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
<linux-i2c@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/6] i2c: i2c-stm32f7: Add initial SMBus protocols support
Date: Wed, 4 Apr 2018 11:04:20 +0200 [thread overview]
Message-ID: <07e24b50-0f6e-2960-8543-92d5a2668373@st.com> (raw)
In-Reply-To: <20180403153122.ux6hnnmexwmq3soz@ninjato>
On 04/03/2018 05:31 PM, Wolfram Sang wrote:
>
>>>> All SMBus protocols are implemented except SMBus-specific protocols.
>>>
>>> What does that mean?
>>
>> It miss SMBus Host Notification and SMBBus Alert. They are almost ready but I'm
>> struggling to put them back to operational state after recent changes related to
>> SMBust Host Notification. A more "classic" interrupt base solution has been put
>> in place but I fail to use implement it in my side.
>> Another patch set is going to be delivered for these 2 commands.
>
> This is totally fine to implement it incrementally. Please just update the
> commit message with the more detailed explanation above.
>
Ok. I get.
>>> That is quite some complexity considering we have I2C_FUNC_SMBUS_EMUL. I
>>> don't mind, but you really want that?
>>>
>>
>> All SMBBus commands are implemented as such. I never try to emulation commands.
>> Should we use emulation SMBus commands or real commands... Don't know.
>
> You won't see any difference on the wire. I don't know your HW. It might
> be that SMBus mode is more "automatic" and uses less interrupts. Or
> stuff like Alert or HostNotification only works in this mode. If you and
> the driver maintainers think it is worth the added complexity, I am
> fine, too.
>
Ok. I see.
I am the maintainer. So yes I keep it as such ... with this complexity ;)
next prev parent reply other threads:[~2018-04-04 9:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 16:48 [PATCH v2 0/6] Add different features for I2C Pierre-Yves MORDRET
2018-03-21 16:48 ` [PATCH v2 1/6] i2c: i2c-stm32f7: Add 10-bit address support Pierre-Yves MORDRET
2018-03-24 22:43 ` Wolfram Sang
2018-03-26 7:56 ` Pierre Yves MORDRET
2018-03-26 8:00 ` Wolfram Sang
2018-03-21 16:48 ` [PATCH v2 2/6] i2c: i2c-stm32f7: Add slave support Pierre-Yves MORDRET
2018-03-25 18:16 ` Wolfram Sang
2018-03-26 8:41 ` Pierre Yves MORDRET
2018-04-03 15:26 ` Wolfram Sang
2018-04-04 8:13 ` Pierre Yves MORDRET
2018-04-04 11:07 ` Wolfram Sang
2018-03-21 16:48 ` [PATCH v2 3/6] i2c: i2c-stm32f7: Add initial SMBus protocols support Pierre-Yves MORDRET
2018-03-24 22:49 ` Wolfram Sang
2018-03-26 8:13 ` Pierre Yves MORDRET
2018-04-03 15:31 ` Wolfram Sang
2018-04-04 8:16 ` Pierre Yves MORDRET
2018-04-04 9:04 ` Pierre Yves MORDRET [this message]
2018-04-27 20:48 ` Wolfram Sang
2018-03-21 16:48 ` [PATCH v2 4/6] i2c: i2c-stm32: Add generic DMA API Pierre-Yves MORDRET
2018-03-24 22:51 ` Wolfram Sang
2018-03-26 8:20 ` Pierre Yves MORDRET
2018-03-21 16:48 ` [PATCH v2 5/6] i2c: i2c-stm32f7: Add DMA support Pierre-Yves MORDRET
2018-04-03 15:39 ` Wolfram Sang
2018-04-04 8:20 ` Pierre Yves MORDRET
2018-03-21 16:49 ` [PATCH v2 6/6] i2c: i2c-stm32f7: Implement I2C recovery mechanism Pierre-Yves MORDRET
2018-03-24 22:56 ` Wolfram Sang
2018-03-26 8:21 ` Pierre Yves MORDRET
2018-03-24 22:57 ` [PATCH v2 0/6] Add different features for I2C Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07e24b50-0f6e-2960-8543-92d5a2668373@st.com \
--to=pierre-yves.mordret@st.com \
--cc=alexandre.torgue@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).