From: Pierre Yves MORDRET <pierre-yves.mordret@st.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
<linux-i2c@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 6/6] i2c: i2c-stm32f7: Implement I2C recovery mechanism
Date: Mon, 26 Mar 2018 10:21:19 +0200 [thread overview]
Message-ID: <ad11f5a5-4552-eb4a-7d7f-e0966bc340ea@st.com> (raw)
In-Reply-To: <20180324225630.6jen6mvboxbhyp7n@ninjato>
On 03/24/2018 11:56 PM, Wolfram Sang wrote:
> On Wed, Mar 21, 2018 at 05:49:00PM +0100, Pierre-Yves MORDRET wrote:
>> Feature prevents I2C lock-ups. Mechanism resets I2C state machine
>> and releases SCL/SDA signals but preserves I2C registers.
>>
>> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
>> ---
>> Version history:
>> v1:
>> * Initial
>> v2:
>> * Don't use i2c engine recovery mechanism since driver
>> procedure only recover master and not the slave.
>
> s/recovery/release/ throughout the patch, please. Recovery is really
> something else. Also, I think the dev_info's are too noisy in the log
> files. I'd think the whole driver could be lifted from quite some
> logging...
>
ok. will do.
Do you have example of info's that we should get rid of ?
>> ---
>> ---
>> drivers/i2c/busses/i2c-stm32f7.c | 27 ++++++++++++++++++++++++---
>> 1 file changed, 24 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
>> index 91f73e0..9a9c469 100644
>> --- a/drivers/i2c/busses/i2c-stm32f7.c
>> +++ b/drivers/i2c/busses/i2c-stm32f7.c
>> @@ -718,6 +718,20 @@ static void stm32f7_i2c_smbus_reload(struct stm32f7_i2c_dev *i2c_dev)
>> writel_relaxed(cr2, i2c_dev->base + STM32F7_I2C_CR2);
>> }
>>
>> +static int stm32f7_i2c_recover_bus(struct i2c_adapter *i2c_adap)
>> +{
>> + struct stm32f7_i2c_dev *i2c_dev = i2c_get_adapdata(i2c_adap);
>> +
>> + dev_info(i2c_dev->dev, "Trying to recover bus\n");
>> +
>> + stm32f7_i2c_clr_bits(i2c_dev->base + STM32F7_I2C_CR1,
>> + STM32F7_I2C_CR1_PE);
>> +
>> + stm32f7_i2c_hw_config(i2c_dev);
>> +
>> + return 0;
>> +}
>> +
>> static int stm32f7_i2c_wait_free_bus(struct stm32f7_i2c_dev *i2c_dev)
>> {
>> u32 status;
>> @@ -727,12 +741,18 @@ static int stm32f7_i2c_wait_free_bus(struct stm32f7_i2c_dev *i2c_dev)
>> status,
>> !(status & STM32F7_I2C_ISR_BUSY),
>> 10, 1000);
>> + if (!ret)
>> + return 0;
>> +
>> + dev_info(i2c_dev->dev, "bus busy\n");
>> +
>> + ret = stm32f7_i2c_recover_bus(&i2c_dev->adap);
>> if (ret) {
>> - dev_dbg(i2c_dev->dev, "bus busy\n");
>> - ret = -EBUSY;
>> + dev_err(i2c_dev->dev, "Failed to recover the bus (%d)\n", ret);
>> + return ret;
>> }
>>
>> - return ret;
>> + return -EBUSY;
>> }
>>
>> static void stm32f7_i2c_xfer_msg(struct stm32f7_i2c_dev *i2c_dev,
>> @@ -1474,6 +1494,7 @@ static irqreturn_t stm32f7_i2c_isr_error(int irq, void *data)
>> if (status & STM32F7_I2C_ISR_BERR) {
>> dev_err(dev, "<%s>: Bus error\n", __func__);
>> writel_relaxed(STM32F7_I2C_ICR_BERRCF, base + STM32F7_I2C_ICR);
>> + stm32f7_i2c_recover_bus(&i2c_dev->adap);
>> f7_msg->result = -EIO;
>> }
>>
>> --
>> 2.7.4
>>
next prev parent reply other threads:[~2018-03-26 8:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 16:48 [PATCH v2 0/6] Add different features for I2C Pierre-Yves MORDRET
2018-03-21 16:48 ` [PATCH v2 1/6] i2c: i2c-stm32f7: Add 10-bit address support Pierre-Yves MORDRET
2018-03-24 22:43 ` Wolfram Sang
2018-03-26 7:56 ` Pierre Yves MORDRET
2018-03-26 8:00 ` Wolfram Sang
2018-03-21 16:48 ` [PATCH v2 2/6] i2c: i2c-stm32f7: Add slave support Pierre-Yves MORDRET
2018-03-25 18:16 ` Wolfram Sang
2018-03-26 8:41 ` Pierre Yves MORDRET
2018-04-03 15:26 ` Wolfram Sang
2018-04-04 8:13 ` Pierre Yves MORDRET
2018-04-04 11:07 ` Wolfram Sang
2018-03-21 16:48 ` [PATCH v2 3/6] i2c: i2c-stm32f7: Add initial SMBus protocols support Pierre-Yves MORDRET
2018-03-24 22:49 ` Wolfram Sang
2018-03-26 8:13 ` Pierre Yves MORDRET
2018-04-03 15:31 ` Wolfram Sang
2018-04-04 8:16 ` Pierre Yves MORDRET
2018-04-04 9:04 ` Pierre Yves MORDRET
2018-04-27 20:48 ` Wolfram Sang
2018-03-21 16:48 ` [PATCH v2 4/6] i2c: i2c-stm32: Add generic DMA API Pierre-Yves MORDRET
2018-03-24 22:51 ` Wolfram Sang
2018-03-26 8:20 ` Pierre Yves MORDRET
2018-03-21 16:48 ` [PATCH v2 5/6] i2c: i2c-stm32f7: Add DMA support Pierre-Yves MORDRET
2018-04-03 15:39 ` Wolfram Sang
2018-04-04 8:20 ` Pierre Yves MORDRET
2018-03-21 16:49 ` [PATCH v2 6/6] i2c: i2c-stm32f7: Implement I2C recovery mechanism Pierre-Yves MORDRET
2018-03-24 22:56 ` Wolfram Sang
2018-03-26 8:21 ` Pierre Yves MORDRET [this message]
2018-03-24 22:57 ` [PATCH v2 0/6] Add different features for I2C Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad11f5a5-4552-eb4a-7d7f-e0966bc340ea@st.com \
--to=pierre-yves.mordret@st.com \
--cc=alexandre.torgue@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).