From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>,
tyreld@linux.vnet.ibm.com, benh@kernel.crashing.org,
paulus@samba.org, mpe@ellerman.id.au, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ibmvfc: constify dev_pm_ops structures.
Date: Thu, 29 Jun 2017 15:39:45 -0700 [thread overview]
Message-ID: <07f4c01f-4937-9790-703a-b2db8934ddd8@linux.vnet.ibm.com> (raw)
In-Reply-To: <c0ec5db7e2c3313cb7b417e76330520fd2b6136c.1498722828.git.arvind.yadav.cs@gmail.com>
On 06/29/2017 12:54 AM, Arvind Yadav wrote:
> dev_pm_ops are not supposed to change at runtime. All functions
> working with dev_pm_ops provided by <linux/device.h> work with const
> dev_pm_ops. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 41937 1296 20 43253 a8f5 drivers/scsi/ibmvscsi/ibmvfc.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 42129 1104 20 43253 a8f5 drivers/scsi/ibmvscsi/ibmvfc.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
next prev parent reply other threads:[~2017-06-29 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 7:54 [PATCH] scsi: ibmvfc: constify dev_pm_ops structures Arvind Yadav
2017-06-29 22:39 ` Tyrel Datwyler [this message]
2017-07-01 21:05 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f4c01f-4937-9790-703a-b2db8934ddd8@linux.vnet.ibm.com \
--to=tyreld@linux.vnet.ibm.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).