linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kumar Gala <galak@codeaurora.org>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Nair, Sandeep" <sandeep_n@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>,
	Grant Likely <grant.likely@linaro.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] soc: keystone: add QMSS driver
Date: Wed, 5 Mar 2014 03:55:43 -0600	[thread overview]
Message-ID: <0817AD72-FBD0-4DB0-86C7-6C8EAC84BAA2@codeaurora.org> (raw)
In-Reply-To: <53169036.9060808@ti.com>


On Mar 4, 2014, at 8:47 PM, Santosh Shilimkar <santosh.shilimkar@ti.com> wrote:

> On Wednesday 05 March 2014 01:59 AM, Kumar Gala wrote:
>> 
>> On Feb 28, 2014, at 5:18 PM, Santosh Shilimkar <santosh.shilimkar@ti.com> wrote:
>> 
>>> From: Sandeep Nair <sandeep_n@ti.com>
>>> 
>>> The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
>>> the main hardware sub system which forms the backbone of the Keystone
>>> Multi-core Navigator. QMSS consist of queue managers, packed-data structure
>>> processors(PDSP), linking RAM, descriptor pools and infrastructure
>>> Packet DMA.
>>> 
>>> The Queue Manager is a hardware module that is responsible for accelerating
>>> management of the packet queues. Packets are queued/de-queued by writing or
>>> reading descriptor address to a particular memory mapped location. The PDSPs
>>> perform QMSS related functions like accumulation, QoS, or event management.
>>> Linking RAM registers are used to link the descriptors which are stored in
>>> descriptor RAM. Descriptor RAM is configurable as internal or external memory.
>>> 
>>> The QMSS driver manages the PDSP setups, linking RAM regions,
>>> queue pool management (allocation, push, pop and notify) and descriptor
>>> pool management. The specifics on the device tree bindings for
>>> QMSS can be found in:
>>>       Documentation/devicetree/bindings/soc/keystone-qmss.txt
>>> 
>>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> Cc: Kumar Gala <galak@codeaurora.org>
>>> Cc: Olof Johansson <olof@lixom.net>
>>> Cc: Arnd Bergmann <arnd@arndb.de>
>>> Cc: Grant Likely <grant.likely@linaro.org>
>>> Cc: Rob Herring <robh+dt@kernel.org>
>>> Cc: Mark Rutland <mark.rutland@arm.com>
>>> Signed-off-by: Sandeep Nair <sandeep_n@ti.com>
>>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>> ---
>>> .../devicetree/bindings/soc/keystone-qmss.txt      |  209 +++
>>> drivers/Kconfig                                    |    2 +
>>> drivers/Makefile                                   |    3 +
>>> drivers/soc/Kconfig                                |    2 +
>>> drivers/soc/Makefile                               |    5 +
>>> drivers/soc/keystone/Kconfig                       |   15 +
>>> drivers/soc/keystone/Makefile                      |    5 +
>>> drivers/soc/keystone/qmss_acc.c                    |  591 ++++++++
>>> drivers/soc/keystone/qmss_queue.c                  | 1533 ++++++++++++++++++++
>>> drivers/soc/keystone/qmss_queue.h                  |  236 +++
>>> include/linux/soc/keystone_qmss.h                  |  390 +++++
>>> 11 files changed, 2991 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/soc/keystone-qmss.txt
>>> create mode 100644 drivers/soc/Makefile
>>> create mode 100644 drivers/soc/keystone/Kconfig
>>> create mode 100644 drivers/soc/keystone/Makefile
>>> create mode 100644 drivers/soc/keystone/qmss_acc.c
>>> create mode 100644 drivers/soc/keystone/qmss_queue.c
>>> create mode 100644 drivers/soc/keystone/qmss_queue.h
>>> create mode 100644 include/linux/soc/keystone_qmss.h
>> 
>> Do you see qmss being able to provide HW support for a qdisc or doing processor to processor communication over something like rpmsg?
>> 
>> I ask because I do wondering if we should be looking at a drivers/hwqueue as other vendors have similar hardware.
>> 
> QMSS just provides the programming interfaces so that certain queues can be configured to achieve QOS tree. The actual qdisc should be
> part of the network driver as such. The queues are such a generic hardware that it can be used for wide variety of usecases and 
> supporting that through one driver will be really hard. We did talk of hwqueue last year but looks like the usecase variety is
> too much because of generic nature of them.
> 
> QMSS isn't used as such for message passing but queue hardware can be used as done by APM hardware which Arnd pointed me on the other
> thread. As Arnd recommended, the processor to processor communication related drivers should go under drivers/mailbox. One example,
> was the APM QMTM patchset [1]
> 
> From first look the QMSS(APM) and QMTM(APM) looked very similar but they actually differ largely the way it works. Thanks to Arnd
> for useful discussion here at connect, I better understood how the QMTM works.
> 
> If you know any other hardware, which needs similar interfaces as QMSS, we can surely think of another subsystem. QMSS is
> largely network usecase dominated but not limited to only those usecases. It is also used by pure drivers/crypto/ or
> can also be used for data movement for video etc. 
> 
> Regards,
> Santosh
> 
> [1] https://lkml.org/lkml/2014/2/14/703

The Freescale QorIQ Devices have a Queue Manager (QMan) as part of their Data Path Architecture (DPAA).  I haven’t looked at the QMTM from APM, but not sure if mailbox is the best place for these things.  They seem so much more involved than what I’m guessing most people are thinking with mailbox.

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


  reply	other threads:[~2014-03-05  9:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 23:18 [PATCH 0/3] soc: Introduce drivers/soc and add Keystone QMSS driver Santosh Shilimkar
2014-02-28 23:18 ` [PATCH 1/3] soc: Introduce drivers/soc place-holder for SOC specific drivers Santosh Shilimkar
2014-03-02 17:12   ` One Thousand Gnomes
2014-03-02 20:48     ` Olof Johansson
2014-03-03 16:13       ` Kumar Gala
2014-03-03 16:16   ` Kumar Gala
2014-02-28 23:18 ` [PATCH 2/3] soc: keystone: add QMSS driver Santosh Shilimkar
2014-03-03 16:41   ` Kumar Gala
2014-03-04  7:51     ` Santosh Shilimkar
2014-03-04 17:59   ` Kumar Gala
2014-03-05  2:47     ` Santosh Shilimkar
2014-03-05  9:55       ` Kumar Gala [this message]
2014-03-06  1:46         ` Santosh Shilimkar
2014-03-10 17:02   ` Rob Herring
2014-03-10 21:19     ` Santosh Shilimkar
2014-03-11 14:04       ` Kumar Gala
2014-03-11 14:44         ` Santosh Shilimkar
2014-03-11 15:14         ` Rob Herring
2014-02-28 23:18 ` [PATCH 3/3] firmware: add Keystone QMSS PDSP accumulator firmware blob Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0817AD72-FBD0-4DB0-86C7-6C8EAC84BAA2@codeaurora.org \
    --to=galak@codeaurora.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=sandeep_n@ti.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).