From: Rob Herring <robherring2@gmail.com>
To: Kumar Gala <galak@codeaurora.org>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Sandeep Nair <sandeep_n@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 2/3] soc: keystone: add QMSS driver
Date: Tue, 11 Mar 2014 10:14:23 -0500 [thread overview]
Message-ID: <CAL_JsqLKoZd4L2jjzD5Z8fFO9Cx1SH7cfE-PnEY_Vx2Sx0FRYA@mail.gmail.com> (raw)
In-Reply-To: <5EE98053-31B8-4679-AAE2-4F026C61D1D4@codeaurora.org>
On Tue, Mar 11, 2014 at 9:04 AM, Kumar Gala <galak@codeaurora.org> wrote:
>
> On Mar 10, 2014, at 4:19 PM, Santosh Shilimkar <santosh.shilimkar@ti.com> wrote:
>
>>>> + -- reg-names : Names for the above register regions. The name to be
>>>> + used is as follows:
>>>> + - "config" : Queue configuration region.
>>>> + - "status" : Queue status RAM.
>>>> + - "region" : Descriptor memory setup region.
>>>> + - "push" : Queue Management/Queue Proxy region.
>>>> + - "pop" : Queue Management/Queue Proxy region.
>>>> + - "peek" : Queue Peek region.
>>>
>>> reg-names should be optional. Also you have the order different from
>>> reg. Be consistent as to what is the correct order.
>>>
>> We thought of using reg-names to remove the ordering to index
>> the regs. So if we make the reg-names optional, then indexing
>> by order will be used. We can do that.
>
> We keep having this conversation, why does reg-names need to be optional for new bindings?
Because order is a fundamental part of the reg and interrupts
properties and has been since the beginning of DT. Adding auxiliary
data does not change that. We just discussed this in our weekly DT
meeting[1]. In many cases defining the order is not a burden. For the
exceptions, the binding needs to spell out why the order can't be
fixed.
Rob
[1] http://irclogs.linaro.org/meeting-logs/devicetree/2014/devicetree.2014-03-11-14.09.log.html
next prev parent reply other threads:[~2014-03-11 15:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 23:18 [PATCH 0/3] soc: Introduce drivers/soc and add Keystone QMSS driver Santosh Shilimkar
2014-02-28 23:18 ` [PATCH 1/3] soc: Introduce drivers/soc place-holder for SOC specific drivers Santosh Shilimkar
2014-03-02 17:12 ` One Thousand Gnomes
2014-03-02 20:48 ` Olof Johansson
2014-03-03 16:13 ` Kumar Gala
2014-03-03 16:16 ` Kumar Gala
2014-02-28 23:18 ` [PATCH 2/3] soc: keystone: add QMSS driver Santosh Shilimkar
2014-03-03 16:41 ` Kumar Gala
2014-03-04 7:51 ` Santosh Shilimkar
2014-03-04 17:59 ` Kumar Gala
2014-03-05 2:47 ` Santosh Shilimkar
2014-03-05 9:55 ` Kumar Gala
2014-03-06 1:46 ` Santosh Shilimkar
2014-03-10 17:02 ` Rob Herring
2014-03-10 21:19 ` Santosh Shilimkar
2014-03-11 14:04 ` Kumar Gala
2014-03-11 14:44 ` Santosh Shilimkar
2014-03-11 15:14 ` Rob Herring [this message]
2014-02-28 23:18 ` [PATCH 3/3] firmware: add Keystone QMSS PDSP accumulator firmware blob Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLKoZd4L2jjzD5Z8fFO9Cx1SH7cfE-PnEY_Vx2Sx0FRYA@mail.gmail.com \
--to=robherring2@gmail.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sandeep_n@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).