Re: [PATCH V5 00/11] coresight: Move remaining AMBA ACPI devices into platform driver

From: Anshuman Khandual <anshuman.khandual@arm.com>
To: James Clark <james.clark@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	coresight@lists.linaro.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V5 00/11] coresight: Move remaining AMBA ACPI devices into platform driver
Date: Mon, 11 Mar 2024 15:03:27 +0530	[thread overview]
Message-ID: <081eef3f-3b19-42d1-b70d-8916b867f766@arm.com> (raw)
In-Reply-To: <828d2109-7413-ffe5-da6a-56f15ed2f562@arm.com>

On 3/11/24 14:55, James Clark wrote:
> 
> On 11/03/2024 06:04, Anshuman Khandual wrote:
>>
>> On 3/5/24 23:55, Suzuki K Poulose wrote:
>>> On 22/02/2024 08:21, Anshuman Khandual wrote:
>>>> This moves remaining AMBA ACPI devices into respective platform drivers for
>>>> enabling ACPI based power management support. This series applies on kernel
>>>> v6.8-rc5 release. This series has been built, and boot tested on a DT based
>>>> (RB5) and ACPI supported coresight platform (N1SDP).
>>> Please rebase your series on coresight next and fix build failures with the extra warnings turned ON (should be on by default with next).
>> I did rebase the series (which required some rebase related changes for some) on
>> coresight next i.e with the following commit as HEAD.
>>
>> a4f3057d19ff ("coresight-tpda: Change qcom,dsb-element-size to qcom,dsb-elem-bits")
>>
>> Although did not see any warning either with = m or = y based coresight options.
>> Is there any other particular config which needs to be enabled for these warnings
>> to come up ?
>>
> It doesn't apply cleanly on a4f305 for me, maybe you sent an old version
> after rebasing?

Ohh, I was not clear enough earlier. This series is NOT rebased against coresight next.
I am preparing V6 series respin which is rebased against the above mentioned commit on
coresight next branch instead.

> 
> This change in patch 5 is a warning for example, because not all members
> of the struct are initialised. No special config is required:
> 
> +	{"ARMHC98D", 0}, /* ARM CoreSight Dynamic Replicator */"

Right, will change the above as follows and fix other affected places as well.

	{"ARMHC98D", 0, 0, 0}, /* ARM CoreSight Dynamic Replicator */