From: Anshuman Khandual <anshuman.khandual@arm.com>
To: linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@arm.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
coresight@lists.linaro.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: [PATCH V5 03/11] coresight: tmc: Extract device properties from AMBA pid based table lookup
Date: Thu, 22 Feb 2024 13:51:34 +0530 [thread overview]
Message-ID: <20240222082142.3663983-4-anshuman.khandual@arm.com> (raw)
In-Reply-To: <20240222082142.3663983-1-anshuman.khandual@arm.com>
This extracts device properties from AMBA pid based table lookup. But first
this modifies tmc_etr_setup_caps() to accept csdev access.
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: James Clark <james.clark@arm.com>
Cc: coresight@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Reviewed-by: James Clark <james.clark@arm.com>
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
Changes in V5:
- Modified tmc_etr_setup_caps() to accept struct csdev_access argument
- Reverted back tmc_etr_setup_caps() call site position in tmc_probe()
- Dropped custom mask TMC_AMBA_MASK
drivers/hwtracing/coresight/coresight-tmc-core.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c
index 7ec5365e2b64..43874fa4def0 100644
--- a/drivers/hwtracing/coresight/coresight-tmc-core.c
+++ b/drivers/hwtracing/coresight/coresight-tmc-core.c
@@ -370,16 +370,23 @@ static inline bool tmc_etr_has_non_secure_access(struct tmc_drvdata *drvdata)
return (auth & TMC_AUTH_NSID_MASK) == 0x3;
}
+static const struct amba_id tmc_ids[];
+
/* Detect and initialise the capabilities of a TMC ETR */
-static int tmc_etr_setup_caps(struct device *parent, u32 devid, void *dev_caps)
+static int tmc_etr_setup_caps(struct device *parent, u32 devid,
+ struct csdev_access *access)
{
int rc;
- u32 dma_mask = 0;
+ u32 tmc_pid, dma_mask = 0;
struct tmc_drvdata *drvdata = dev_get_drvdata(parent);
+ void *dev_caps;
if (!tmc_etr_has_non_secure_access(drvdata))
return -EACCES;
+ tmc_pid = coresight_get_pid(access);
+ dev_caps = coresight_get_uci_data_from_amba(tmc_ids, tmc_pid);
+
/* Set the unadvertised capabilities */
tmc_etr_init_caps(drvdata, (u32)(unsigned long)dev_caps);
@@ -497,8 +504,7 @@ static int tmc_probe(struct amba_device *adev, const struct amba_id *id)
desc.type = CORESIGHT_DEV_TYPE_SINK;
desc.subtype.sink_subtype = CORESIGHT_DEV_SUBTYPE_SINK_SYSMEM;
desc.ops = &tmc_etr_cs_ops;
- ret = tmc_etr_setup_caps(dev, devid,
- coresight_get_uci_data(id));
+ ret = tmc_etr_setup_caps(dev, devid, &desc.access);
if (ret)
goto out;
idr_init(&drvdata->idr);
--
2.25.1
next prev parent reply other threads:[~2024-02-22 8:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 8:21 [PATCH V5 00/11] coresight: Move remaining AMBA ACPI devices into platform driver Anshuman Khandual
2024-02-22 8:21 ` [PATCH V5 01/11] coresight: etm4x: Fix unbalanced pm_runtime_enable() Anshuman Khandual
2024-02-22 8:21 ` [PATCH V5 02/11] coresight: stm: Extract device name from AMBA pid based table lookup Anshuman Khandual
2024-02-22 8:21 ` Anshuman Khandual [this message]
2024-03-05 14:36 ` [PATCH V5 03/11] coresight: tmc: Extract device properties " Suzuki K Poulose
2024-03-06 3:54 ` Anshuman Khandual
2024-02-22 8:21 ` [PATCH V5 04/11] coresight: Add helpers registering/removing both AMBA and platform drivers Anshuman Khandual
2024-02-22 8:21 ` [PATCH V5 05/11] coresight: replicator: Move ACPI support from AMBA driver to platform driver Anshuman Khandual
2024-02-22 8:21 ` [PATCH V5 06/11] coresight: funnel: " Anshuman Khandual
2024-02-22 8:21 ` [PATCH V5 07/11] coresight: catu: " Anshuman Khandual
2024-03-05 17:32 ` Suzuki K Poulose
2024-03-06 6:14 ` Anshuman Khandual
2024-03-06 17:21 ` Suzuki K Poulose
2024-03-08 4:25 ` Anshuman Khandual
2024-03-08 10:29 ` Suzuki K Poulose
2024-02-22 8:21 ` [PATCH V5 08/11] coresight: tpiu: " Anshuman Khandual
2024-02-22 8:21 ` [PATCH V5 09/11] coresight: tmc: " Anshuman Khandual
2024-02-22 8:21 ` [PATCH V5 10/11] coresight: stm: " Anshuman Khandual
2024-02-22 8:21 ` [PATCH V5 11/11] coresight: debug: " Anshuman Khandual
2024-03-05 18:25 ` [PATCH V5 00/11] coresight: Move remaining AMBA ACPI devices into " Suzuki K Poulose
2024-03-11 6:04 ` Anshuman Khandual
2024-03-11 9:25 ` James Clark
2024-03-11 9:33 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222082142.3663983-4-anshuman.khandual@arm.com \
--to=anshuman.khandual@arm.com \
--cc=alexandre.torgue@foss.st.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@arm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lpieralisi@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mike.leach@linaro.org \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).