* [PATCH -next] scsi: lpfc: Add dependency on CPU_FREQ
@ 2020-07-22 2:30 Guenter Roeck
2020-07-22 16:13 ` James Smart
2020-07-25 2:50 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Guenter Roeck @ 2020-07-22 2:30 UTC (permalink / raw)
To: Martin K . Petersen
Cc: James E . J . Bottomley, linux-scsi, linux-kernel, Guenter Roeck,
Dick Kennedy, James Smart
Since commit 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for
latency improvment"), the lpfc driver depends on CPUFREQ. Without it,
builds fail with
drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_init_idle_stat_hb':
drivers/scsi/lpfc/lpfc_sli.c:7329:26: error:
implicit declaration of function 'get_cpu_idle_time'
Add the missing dependency.
Fixes: 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for latency improvment")
Cc: Dick Kennedy <dick.kennedy@broadcom.com>
Cc: James Smart <jsmart2021@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/scsi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 571473a58f98..701b61ec76ee 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1154,6 +1154,7 @@ source "drivers/scsi/qedf/Kconfig"
config SCSI_LPFC
tristate "Emulex LightPulse Fibre Channel Support"
depends on PCI && SCSI
+ depends on CPU_FREQ
depends on SCSI_FC_ATTRS
depends on NVME_TARGET_FC || NVME_TARGET_FC=n
depends on NVME_FC || NVME_FC=n
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: lpfc: Add dependency on CPU_FREQ
2020-07-22 2:30 [PATCH -next] scsi: lpfc: Add dependency on CPU_FREQ Guenter Roeck
@ 2020-07-22 16:13 ` James Smart
2020-07-25 2:50 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2020-07-22 16:13 UTC (permalink / raw)
To: Guenter Roeck, Martin K . Petersen
Cc: James E . J . Bottomley, linux-scsi, linux-kernel, Dick Kennedy,
James Smart
On 7/21/2020 7:30 PM, Guenter Roeck wrote:
> Since commit 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for
> latency improvment"), the lpfc driver depends on CPUFREQ. Without it,
> builds fail with
>
> drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_init_idle_stat_hb':
> drivers/scsi/lpfc/lpfc_sli.c:7329:26: error:
> implicit declaration of function 'get_cpu_idle_time'
>
> Add the missing dependency.
>
> Fixes: 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for latency improvment")
> Cc: Dick Kennedy <dick.kennedy@broadcom.com>
> Cc: James Smart <jsmart2021@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/scsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 571473a58f98..701b61ec76ee 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -1154,6 +1154,7 @@ source "drivers/scsi/qedf/Kconfig"
> config SCSI_LPFC
> tristate "Emulex LightPulse Fibre Channel Support"
> depends on PCI && SCSI
> + depends on CPU_FREQ
> depends on SCSI_FC_ATTRS
> depends on NVME_TARGET_FC || NVME_TARGET_FC=n
> depends on NVME_FC || NVME_FC=n
Reviewed-by: James Smart <james.smart@broadcom.com>
-- james
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: lpfc: Add dependency on CPU_FREQ
2020-07-22 2:30 [PATCH -next] scsi: lpfc: Add dependency on CPU_FREQ Guenter Roeck
2020-07-22 16:13 ` James Smart
@ 2020-07-25 2:50 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-07-25 2:50 UTC (permalink / raw)
To: Guenter Roeck
Cc: Martin K . Petersen, linux-kernel, James Smart,
James E . J . Bottomley, linux-scsi, Dick Kennedy
On Tue, 21 Jul 2020 19:30:27 -0700, Guenter Roeck wrote:
> Since commit 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for
> latency improvment"), the lpfc driver depends on CPUFREQ. Without it,
> builds fail with
>
> drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_init_idle_stat_hb':
> drivers/scsi/lpfc/lpfc_sli.c:7329:26: error:
> implicit declaration of function 'get_cpu_idle_time'
>
> [...]
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: lpfc: Add dependency on CPU_FREQ
https://git.kernel.org/mkp/scsi/c/e3d2bf6505dd
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-25 2:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-22 2:30 [PATCH -next] scsi: lpfc: Add dependency on CPU_FREQ Guenter Roeck
2020-07-22 16:13 ` James Smart
2020-07-25 2:50 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).