From: Hayes Wang <hayeswang@realtek.com>
To: Mario Limonciello <mario_limonciello@dell.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>,
Linux USB <linux-usb@vger.kernel.org>,
"pali.rohar@gmail.com" <pali.rohar@gmail.com>,
"anthony.wong@canonical.com" <anthony.wong@canonical.com>,
Greg KH <gregkh@linuxfoundation.org>
Subject: RE: [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD
Date: Tue, 7 Jun 2016 13:59:11 +0000 [thread overview]
Message-ID: <0835B3720019904CB8F7AA43166CEEB2FF1F92@RTITMBSV03.realtek.com.tw> (raw)
In-Reply-To: <1465233569-13585-1-git-send-email-mario_limonciello@dell.com>
Mario Limonciello [mailto:mario_limonciello@dell.com]
[...]
> + ret = hex2bin(buf, obj->string.pointer + 9, 6);
> + if (ret < 0 || !is_valid_ether_addr(buf)) {
> + netif_warn(tp, probe, tp->netdev, "Invalid MAC\n");
> + goto amacout;
> + }
If hex2bin() is success, the ret would be 0.
And you would return 0 when !is_valid_ether_addr(buf) occurs.
I don't think it is what you wants.
Best Regards,
Hayes
prev parent reply other threads:[~2016-06-07 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 17:19 [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD Mario Limonciello
2016-06-06 17:42 ` [EXT] " Konstantin Shkolnyy
2016-06-06 17:48 ` Mario_Limonciello
2016-06-07 7:59 ` Pali Rohár
2016-06-07 13:59 ` Hayes Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0835B3720019904CB8F7AA43166CEEB2FF1F92@RTITMBSV03.realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=anthony.wong@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=netdev@vger.kernel.org \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).