* [PATCH] tee: amdtee: out of bounds read in find_session()
@ 2020-02-27 16:19 Dan Carpenter
2020-03-10 6:22 ` Rijo Thomas
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-02-27 16:19 UTC (permalink / raw)
To: Jens Wiklander, Rijo Thomas
Cc: Herbert Xu, Devaraj Rangasamy, tee-dev, linux-kernel, kernel-janitors
The "index" is a user provided value from 0-USHRT_MAX. If it's over
TEE_NUM_SESSIONS (31) then it results in an out of bounds read when we
call test_bit(index, sess->sess_mask).
Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/tee/amdtee/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c
index 6370bb55f512..dbc238c7c263 100644
--- a/drivers/tee/amdtee/core.c
+++ b/drivers/tee/amdtee/core.c
@@ -139,6 +139,9 @@ static struct amdtee_session *find_session(struct amdtee_context_data *ctxdata,
u32 index = get_session_index(session);
struct amdtee_session *sess;
+ if (index >= TEE_NUM_SESSIONS)
+ return NULL;
+
list_for_each_entry(sess, &ctxdata->sess_list, list_node)
if (ta_handle == sess->ta_handle &&
test_bit(index, sess->sess_mask))
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tee: amdtee: out of bounds read in find_session()
2020-02-27 16:19 [PATCH] tee: amdtee: out of bounds read in find_session() Dan Carpenter
@ 2020-03-10 6:22 ` Rijo Thomas
0 siblings, 0 replies; 2+ messages in thread
From: Rijo Thomas @ 2020-03-10 6:22 UTC (permalink / raw)
To: Dan Carpenter, Jens Wiklander
Cc: Herbert Xu, Devaraj Rangasamy, tee-dev, linux-kernel, kernel-janitors
On 27/02/20 9:49 pm, Dan Carpenter wrote:
> The "index" is a user provided value from 0-USHRT_MAX. If it's over
> TEE_NUM_SESSIONS (31) then it results in an out of bounds read when we
> call test_bit(index, sess->sess_mask).
>
> Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
Thanks,
Rijo
> ---
> drivers/tee/amdtee/core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c
> index 6370bb55f512..dbc238c7c263 100644
> --- a/drivers/tee/amdtee/core.c
> +++ b/drivers/tee/amdtee/core.c
> @@ -139,6 +139,9 @@ static struct amdtee_session *find_session(struct amdtee_context_data *ctxdata,
> u32 index = get_session_index(session);
> struct amdtee_session *sess;
>
> + if (index >= TEE_NUM_SESSIONS)
> + return NULL;
> +
> list_for_each_entry(sess, &ctxdata->sess_list, list_node)
> if (ta_handle == sess->ta_handle &&
> test_bit(index, sess->sess_mask))
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-10 6:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27 16:19 [PATCH] tee: amdtee: out of bounds read in find_session() Dan Carpenter
2020-03-10 6:22 ` Rijo Thomas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).