From: Markus Elfring <Markus.Elfring@web.de>
To: "Tang Bin" <tangbin@cmss.chinamobile.com>,
iommu@lists.linux-foundation.org, linux-arm-msm@vger.kernel.org,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Jörg Rödel" <joro@8bytes.org>, "Rob Clark" <robdclark@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] iommu/qcom: Fix local_base status check
Date: Fri, 3 Apr 2020 19:20:35 +0200 [thread overview]
Message-ID: <084eb9b2-3f5f-4e87-08aa-fe57ed3f5d35@web.de> (raw)
> Release resources when exiting on error.
I have got doubts that such a change description fits to
the proposed source code adjustment.
…
> +++ b/drivers/iommu/qcom_iommu.c
> @@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct platform_device *pdev)
> qcom_iommu->dev = dev;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (res)
> + if (res) {
> qcom_iommu->local_base = devm_ioremap_resource(dev, res);
> + if (IS_ERR(qcom_iommu->local_base))
> + return PTR_ERR(qcom_iommu->local_base);
> + }
>
> qcom_iommu->iface_clk = devm_clk_get(dev, "iface");
…
Will the commit message be improved any further?
Would you like to add the tag “Fixes”?
Regards,
Markus
next reply other threads:[~2020-04-03 17:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 17:20 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-19 12:32 [PATCH v2] iommu/qcom: Fix local_base status check Markus Elfring
2020-04-19 13:10 ` Markus Elfring
2020-04-18 13:47 [PATCH v2]iommu/qcom:fix " Tang Bin
2020-04-20 4:52 ` Bjorn Andersson
2020-05-01 11:37 ` Joerg Roedel
2020-05-01 13:54 ` Tang Bin
2020-04-03 17:45 [PATCH v2] iommu/qcom: Fix " Markus Elfring
2020-04-03 17:45 Markus Elfring
2020-04-02 6:03 [PATCH v2]iommu/qcom:fix " Tang Bin
2020-04-02 6:15 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=084eb9b2-3f5f-4e87-08aa-fe57ed3f5d35@web.de \
--to=markus.elfring@web.de \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).