From: Markus Elfring <Markus.Elfring@web.de>
To: "Tang Bin" <tangbin@cmss.chinamobile.com>,
iommu@lists.linux-foundation.org, linux-arm-msm@vger.kernel.org,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Jörg Rödel" <joro@8bytes.org>, "Rob Clark" <robdclark@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] iommu/qcom: Fix local_base status check
Date: Sun, 19 Apr 2020 14:32:20 +0200 [thread overview]
Message-ID: <73736017-cae3-1c2a-dcf4-d771d0f3bbbf@web.de> (raw)
> The function qcom_iommu_device_probe() does not perform sufficient
> error checking after executing devm_ioremap_resource(), which can
> result in crashes if a critical error path is encountered.
Your update suggestion will be rechecked once more.
* Can it be that the patch would need a higher version number
according to previous review comments?
* Would you like to adjust the patch subject?
…
> +++ b/drivers/iommu/qcom_iommu.c
> @@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct platform_device *pdev)
> qcom_iommu->dev = dev;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (res)
I find the deletion of this check appropriate.
> + if (res) {
> qcom_iommu->local_base = devm_ioremap_resource(dev, res);
But I do not see a need to preserve such a check because this function
performs input parameter validation.
https://elixir.bootlin.com/linux/v5.7-rc1/source/lib/devres.c#L116
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/lib/devres.c?id=50cc09c18985eacbbd666acfd7be2391394733f5#n116
Please take another look at a corresponding usage example.
Regards,
Markus
next reply other threads:[~2020-04-19 12:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 12:32 Markus Elfring [this message]
2020-04-19 13:10 ` [PATCH v2] iommu/qcom: Fix local_base status check Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-04-18 13:47 [PATCH v2]iommu/qcom:fix " Tang Bin
2020-04-20 4:52 ` Bjorn Andersson
2020-05-01 11:37 ` Joerg Roedel
2020-05-01 13:54 ` Tang Bin
2020-04-03 17:45 [PATCH v2] iommu/qcom: Fix " Markus Elfring
2020-04-03 17:45 Markus Elfring
2020-04-03 17:20 Markus Elfring
2020-04-02 6:03 [PATCH v2]iommu/qcom:fix " Tang Bin
2020-04-02 6:15 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73736017-cae3-1c2a-dcf4-d771d0f3bbbf@web.de \
--to=markus.elfring@web.de \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).