From: "Filipe Laíns" <lains@riseup.net>
To: Hamza Mahfooz <someguy@effective-light.com>
Cc: linux-kernel@vger.kernel.org, Bastien Nocera <hadess@hadess.net>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v3] HID: logitech-hidpp: battery: provide CAPACITY property for newer devices
Date: Sat, 31 Jul 2021 23:08:07 +0100 [thread overview]
Message-ID: <084f4be8150e83f865b8a8c768ae9fea6d205330.camel@riseup.net> (raw)
In-Reply-To: <86WPWQ.ODI6WUKUKD0N3@effective-light.com>
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On Fri, 2021-07-23 at 17:39 -0400, Hamza Mahfooz wrote:
>
> On Fri, Jul 23 2021 at 08:42:32 PM +0100, Filipe Laíns
> <lains@riseup.net> wrote:
> > That said, I think we should definitely have a comment here nothing
> > that, and
> > possible have some bounds checks for the reported voltage value
> > hinting that
> > there may be bug.
>
> Hey Filipe,
>
> Do you have any thoughts on what the bounds ought to be?
> 3500 mV seems like a rather safe lower bound, however the upper bound
> seems much more fuzzy.
>
>
Hi Hamza,
Sorry for the delay getting back to you! The most relevant bound would be the
lower one, but I think 5000mV would be a good value.
Cheers,
Filipe Laíns
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-07-31 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 18:57 [PATCH v3] HID: logitech-hidpp: battery: provide CAPACITY property for newer devices Hamza Mahfooz
2021-07-23 19:11 ` Bastien Nocera
2021-07-23 19:42 ` Filipe Laíns
2021-07-23 21:39 ` Hamza Mahfooz
2021-07-31 22:08 ` Filipe Laíns [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=084f4be8150e83f865b8a8c768ae9fea6d205330.camel@riseup.net \
--to=lains@riseup.net \
--cc=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=someguy@effective-light.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).